{"id":196,"url":"http://patchwork.ozlabs.org/api/1.1/patches/196/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1220848104-22284-1-git-send-email-gerickson@nuovations.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.1/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1220848104-22284-1-git-send-email-gerickson@nuovations.com>","date":"2008-09-08T04:28:24","name":"nandwrite: Utilize Standard Exit Mnemonics","commit_ref":"1f3124f8f62fd455fb290ef87c60cec9093a47cb","pull_url":null,"state":"accepted","archived":false,"hash":"fa51180fe2d3609009b508bf3f1917fc5febd075","submitter":{"id":115,"url":"http://patchwork.ozlabs.org/api/1.1/people/115/?format=json","name":"Grant Erickson","email":"gerickson@nuovations.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1220848104-22284-1-git-send-email-gerickson@nuovations.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/196/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/196/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork@ozlabs.org","Delivered-To":"patchwork@ozlabs.org","Received":["from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id B12A2DDDFA\n\tfor ; Mon, 8 Sep 2008 14:28:35 +1000 (EST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KcYMW-0002KB-Ti; Mon, 08 Sep 2008 04:28:28 +0000","from relay03.pair.com ([209.68.5.17])\n\tby bombadil.infradead.org with smtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KcYMU-0002K5-SF\n\tfor linux-mtd@lists.infradead.org; Mon, 08 Sep 2008 04:28:27 +0000","(qmail 51362 invoked by uid 0); 8 Sep 2008 04:28:25 -0000","from unknown (HELO localhost.localdomain) (unknown)\n\tby unknown with SMTP; 8 Sep 2008 04:28:25 -0000"],"X-pair-Authenticated":"66.134.71.115","From":"Grant Erickson ","To":"linux-mtd@lists.infradead.org","Subject":"[PATCH 2/6] [MTD-UTILS] nandwrite: Utilize Standard Exit Mnemonics","Date":"Sun, 7 Sep 2008 21:28:24 -0700","Message-Id":"<1220848104-22284-1-git-send-email-gerickson@nuovations.com>","X-Mailer":"git-send-email 1.6.0.1","Organization":"Nuovation System Designs, LLC","X-Spam-Score":"-1.0 (-)","X-Spam-Report":"SpamAssassin version 3.2.5 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-1.0 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [209.68.5.17 listed in list.dnswl.org]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.9","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linux-mtd-bounces@lists.infradead.org","Errors-To":"linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org"},"content":"Replace main exit and return status codes with equivalent mnemonics.\n\nSigned-off-by: Grant Erickson ","diff":"diff --git a/nandwrite.c b/nandwrite.c\nindex 8e0609d..b1a4307 100644\n--- a/nandwrite.c\n+++ b/nandwrite.c\n@@ -103,7 +103,7 @@ static void display_version (void)\n \t\t\t\"You may redistribute copies of \" PROGRAM \"\\n\"\n \t\t\t\"under the terms of the GNU General Public Licence.\\n\"\n \t\t\t\"See the file `COPYING' for more information.\\n\");\n-\texit(0);\n+\texit (EXIT_SUCCESS);\n }\n \n static const char\t*mtd_device, *img;\n@@ -225,20 +225,20 @@ int main(int argc, char * const argv[])\n \n \tif (pad && writeoob) {\n \t\tfprintf(stderr, \"Can't pad when oob data is present.\\n\");\n-\t\texit(1);\n+\t\texit (EXIT_FAILURE);\n \t}\n \n \t/* Open the device */\n \tif ((fd = open(mtd_device, O_RDWR)) == -1) {\n \t\tperror(\"open flash\");\n-\t\texit(1);\n+\t\texit (EXIT_FAILURE);\n \t}\n \n \t/* Fill in MTD device capability structure */\n \tif (ioctl(fd, MEMGETINFO, &meminfo) != 0) {\n \t\tperror(\"MEMGETINFO\");\n \t\tclose(fd);\n-\t\texit(1);\n+\t\texit (EXIT_FAILURE);\n \t}\n \n \t/* Set erasesize to specified number of blocks - to match jffs2\n@@ -252,7 +252,7 @@ int main(int argc, char * const argv[])\n \t\t\t!(meminfo.oobsize == 128 && meminfo.writesize == 4096)) {\n \t\tfprintf(stderr, \"Unknown flash (not normal NAND)\\n\");\n \t\tclose(fd);\n-\t\texit(1);\n+\t\texit (EXIT_FAILURE);\n \t}\n \n \tif (autoplace) {\n@@ -260,7 +260,7 @@ int main(int argc, char * const argv[])\n \t\tif (ioctl (fd, MEMGETOOBSEL, &old_oobinfo) != 0) {\n \t\t\tperror (\"MEMGETOOBSEL\");\n \t\t\tclose (fd);\n-\t\t\texit (1);\n+\t\t\texit (EXIT_FAILURE);\n \t\t}\n \n \t\t// autoplace ECC ?\n@@ -269,7 +269,7 @@ int main(int argc, char * const argv[])\n \t\t\tif (ioctl (fd, MEMSETOOBSEL, &autoplace_oobinfo) != 0) {\n \t\t\t\tperror (\"MEMSETOOBSEL\");\n \t\t\t\tclose (fd);\n-\t\t\t\texit (1);\n+\t\t\t\texit (EXIT_FAILURE);\n \t\t\t}\n \t\t\toobinfochanged = 1;\n \t\t}\n@@ -285,19 +285,19 @@ int main(int argc, char * const argv[])\n \t\t\t\tif (ioctl (fd, MEMGETOOBSEL, &old_oobinfo) != 0) {\n \t\t\t\t\tperror (\"MEMGETOOBSEL\");\n \t\t\t\t\tclose (fd);\n-\t\t\t\t\texit (1);\n+\t\t\t\t\texit (EXIT_FAILURE);\n \t\t\t\t}\n \t\t\t\tif (ioctl (fd, MEMSETOOBSEL, &none_oobinfo) != 0) {\n \t\t\t\t\tperror (\"MEMSETOOBSEL\");\n \t\t\t\t\tclose (fd);\n-\t\t\t\t\texit (1);\n+\t\t\t\t\texit (EXIT_FAILURE);\n \t\t\t\t}\n \t\t\t\toobinfochanged = 1;\n \t\t\t\tbreak;\n \t\t\tdefault:\n \t\t\t\tperror (\"MTDFILEMODE\");\n \t\t\t\tclose (fd);\n-\t\t\t\texit (1);\n+\t\t\t\texit (EXIT_FAILURE);\n \t\t\t}\n \t\t}\n \t}\n@@ -506,7 +506,7 @@ restoreoob:\n \t\tif (ioctl (fd, MEMSETOOBSEL, &old_oobinfo) != 0) {\n \t\t\tperror (\"MEMSETOOBSEL\");\n \t\t\tclose (fd);\n-\t\t\texit (1);\n+\t\t\texit (EXIT_FAILURE);\n \t\t}\n \t}\n \n@@ -514,9 +514,9 @@ restoreoob:\n \n \tif (imglen > 0) {\n \t\tperror (\"Data was only partially written due to error\\n\");\n-\t\texit (1);\n+\t\texit (EXIT_FAILURE);\n \t}\n \n \t/* Return happy */\n-\treturn 0;\n+\treturn EXIT_SUCCESS;\n }\n","prefixes":[]}