{"id":2230477,"url":"http://patchwork.ozlabs.org/api/1.1/covers/2230477/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20260429190532.26538-1-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429190532.26538-1-mohamed@unpredictable.fr>","date":"2026-04-29T19:05:17","name":"[v21,00/15] HVF: Add support for platform vGIC and nested virtualisation","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.1/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20260429190532.26538-1-mohamed@unpredictable.fr/mbox/","series":[{"id":502138,"url":"http://patchwork.ozlabs.org/api/1.1/series/502138/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502138","date":"2026-04-29T19:05:29","name":"HVF: Add support for platform vGIC and nested virtualisation","version":21,"mbox":"http://patchwork.ozlabs.org/series/502138/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/2230477/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=fnlgP1Td;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Rcd0XLWz1xqf\n\tfor ; Thu, 30 Apr 2026 05:06:57 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIAEG-0001Yy-Tw; Wed, 29 Apr 2026 15:05:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIAEE-0001YD-LK\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:05:46 -0400","from ms-2001b-snip4-4.eps.apple.com ([57.103.73.145]\n helo=outbound.ms.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIAEC-0000DD-9H\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:05:46 -0400","from outbound.ms.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-west-3a-60-percent-6 (Postfix) with ESMTPS id\n 4DE3B18005E1; Wed, 29 Apr 2026 19:05:38 +0000 (UTC)","from localhost.localdomain (unknown [17.57.154.37])\n by p00-icloudmta-asmtp-us-west-3a-60-percent-6 (Postfix) with ESMTPSA id\n 9C05418000C6; Wed, 29 Apr 2026 19:05:35 +0000 (UTC)"],"X-ICL-Out-Info":"\n HUtFAUMHWwJACUgBTUQeDx5WFlZNRAJCTQFIHV8DWRxBAUkdXw9LVxQEFVwFVgZXFHkNXR1FDlYZWgxSD1sOHBZLWFUJCgZdGFgVVgl3HlwASx1XBFQfUxJVHR0LRUtAEwRJAE1fDl4fBBdGGVUERx5dVl4eGQJRHFYNV0NUBF9QSQxBUGxaAEcXSB1dGVlvUF0cDhhZG0AVXRFQGVYJXhUXHkFNWgJWTQVKA18BWwZCAEkKXQJYAF4LTgZeD0YDXVQXWwxaDlYwTBZDH1IPWxNNGVEBUkVUAgdYRxRHDg8TTAtHAlo0Vh9UGVoD","Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1777489540; x=1780081540;\n bh=W43n6LVvCh3Rymerk0s50oQ+N/m7lZANcrqMXqV6cU8=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:x-icloud-hme;\n b=fnlgP1TdlGR1cEKcRBoZ0yR8CK9bKZSD1Lct7bpKkQeJr8rkVLMz8RylqQRtJxgUpzMnlHAyVAVtIm1v9EY6BixPP4PRufDGu88AIu/bK70vei31GgyLADCsPzR8PcsAX/ZQfRphCw5ypitzA6qxvZLiDm2SqdZ4WV9UfrsAz+wvUSduXdzkCqvuWINfTNW9WxQPlMpsAue9TUtQAOCdzBLnZGvfgyG3068gS9rX4pwrdK17oDd2ZJSFzYhNTaTpO4oYLQohV0t3uFWsNK9W5OETKeEUNq7IeMJOezxXHB9WcWLL2ci5FbOq8vTab24iEXAw2REZgf2fTjmoKv32vQ==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"Phil Dennis-Jordan ,\n Yanan Wang , Paolo Bonzini ,\n Roman Bolshakov ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-arm@nongnu.org, Zhao Liu ,\n Alexander Graf , Eduardo Habkost ,\n Marcel Apfelbaum ,\n Peter Maydell ,\n Mohamed Mediouni ","Subject":"[PATCH v21 00/15] HVF: Add support for platform vGIC and nested\n virtualisation","Date":"Wed, 29 Apr 2026 21:05:17 +0200","Message-ID":"<20260429190532.26538-1-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI5MDE5MCBTYWx0ZWRfX4JKT4dLScaCq\n nW+bln3xZHvW6SBF3ekj521sWYxa9ihI0KEKrQ78BMvmZljIzaKHJoejtOqog7SFVyl/M23st0q\n pB5zCbDyjZOq2e9aqp8ScNeKjWrpF5XklxcTYydpJmxjyO0DFgZEtbzX3aI5rhwcYs0GXqwV4t/\n M3BsN+ox4BvsTyncIiYueLfxLun2uudqCwZ193WASe4dfBFhH21UcXl1hvF+fAL96DegJUl8y+p\n hayYufPrnKZe3IqrzMxwQRhVG+gSnMfSVfIsJpsuZYLsdX8H3xt6Eu9pLtOUci/fYWiOLAh6TZz\n VM7M9lcETP6Kv64F5b7HAAgYiorVaH2n4vJn9REtuVF5gJU5fCCsotN+ZqXkHw=","X-Authority-Info-Out":"v=2.4 cv=dtnWylg4 c=1 sm=1 tr=0 ts=69f25684\n cx=c_apl:c_pps:t_out a=qkKslKyYc0ctBTeLUVfTFg==:117 a=IkcTkHD0fZMA:10\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=NEAV23lmAAAA:8\n a=jwI92-NncrociDarPsAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10","X-Proofpoint-ORIG-GUID":"eIELW4XmlcxAnWRfGI947F6AZlE2sQO7","X-Proofpoint-GUID":"eIELW4XmlcxAnWRfGI947F6AZlE2sQO7","Received-SPF":"pass client-ip=57.103.73.145;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.ms.icloud.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Link to branch: https://github.com/mediouni-m/qemu hvf-irqchip-and-nested\n(tag for this submission: hvf-irqchip-and-nested-v21)\n\nThis series adds support for nested virtualisation when using HVF on arm64 Macs.\n\nThe first two patches are from the SME enablement series and are present for the\nseries to be buildable on its own.\n\nIt has two parts:\n- Apple vGICv3 support and necessary infrastructure changes for it\n- Nested virtualisation support. Note that the nested virtualisation implementation\nshipping as of macOS 26.3 is nVHE only (but it _does_ use VNCR as shipped).\n\nKnown issues:\n- when nested virt is enabled, no UI response within EDK2\nand a permanent wait. Workaround: -boot menu=on,splash-time=0.\n\nApple Feedback Assistant item: FB21649319\n\nWhen the VM is running at EL2 at the very moment the virtual timer fires:\nHV_EXIT_REASON_VTIMER_ACTIVATED doesn’t fire (when not using the provided vGIC)\n- using a GICv2 doesn’t require having transition notifiers which Hypervisor.framework doesn’t have…)\n\nand when using the provided vGIC, the interrupt never gets delivered back to the guest\n\nLinux as a guest OS is fine with this… but the reference ArmVirtQemu edk2 build always uses the virtual timer even when running EFI at EL2, so it gets broken unless this patch is applied to edk2:\n\ndiff of ArmVirtPkg/ArmVirt.dsc.inc:\n\n- ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerVirtCounterLib/ArmGenericTimerVirtCounterLib.inf\n+ ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf^M\n\nChangelog:\n\nv1->v2:\nOops. I did a mistake when preparing my patches.\n\n- Add hvf_arm_el2_enable(_) call to virt_set_virt\n- Fix nested virt support check to add HVF\n\nv2->v3:\n- LORC_EL1 patch was merged separately, remove from this series.\n- fix LPIs when kernel-irqchip disabled and using TCG\n- remove spurious if case in vGIC supported version detection (inapplicable now)\n- Add hvf_enabled() check in combination with hvf kernel-irqchip checks\n- cleanly fail on attempt to use the platform vGIC together with ITS\n\nv3->v4:\n- GIC state save improvements, including saving the opaque Apple-specific state\n- Saving HVF system register state when using the vGIC and/or EL2\n\nv5:\n- oops, fixed up save/restore to be functional\n- misc changes otherwise\n\nv6:\n- Addressing review comments\n\nv7:\n- Address review comments, adapt around Qemu changes and bugfixes.\n\nv8:\n- Rebase, and misc fixes\n\nv9:\n- Misc fixes from WHPX review comments\n- Split enablement commit for EL2 into its own separate commit\n\nv10:\n\n- A bit of changes across the board\n- move HVF irqchip save/restore into irqchip code\n- block nested virt support when kernel-irqchip=off with a GICv2 as\nwe don't implement an emulated physical timer yet.\n\nv11:\n- fixups for the save/restore Apple GIC state patch\n- block the same registers as the revert in 28b0ed32b32c7e5094cf2f1ec9c0645c65fad2aa\nfor \"hvf: sync registers used at EL2\"\n- drop patch that warns instead of aborts on mismatch\n\nv12:\n- Have the SME2 series at the start of this.\n- Adaptation for the SME2 series.\n\nv13:\n- include \"fix SME capabilities reporting\" patch instead of it being standalone\n- include \"remove hvf_arm.h include\" patch at the beginning of the series\n\nv14:\n- Turns out that the HVF SME2 patches broke the build for pretty much anything\nnon-macOS, and didn't address that properly in v13\n- Addressed some checkpatch nits\n\nv15:\n- Pick new revision of SME2 patches\n- separate disable nested virt when SME on patch\n\nv16/17:\n- Availability checks as needed except for the vGIC code, where they're\njust skipped instead as availability is checked elsewhere.\n- Some tiny cleanups\n- v17: one more (optional to take) cleanup commit\n\nv18:\n\n- Some tiny nits here and there but that's about it.\n- Drop some patches on top as CI isn't ready for them yet\n\nv19:\n\n- change hvf_nested_virt_enable(bool) from a macro to a function call\n\nv20:\n\n- Only enable kernel-irqchip=on when running with -M virt-11.1 or later\n- Enable nested virt to work with kernel-irqchip=off when using a GICv2\n\nv21:\n- Rebase.\n- Addressing review comments but not switching things to HVFState at least\nfor now\n\nMohamed Mediouni (15):\n hw/intc: Add hvf vGIC interrupt controller support\n hw/intc: arm_gicv3_hvf: save/restore Apple GIC state\n accel, hw/arm, include/system/hvf: infrastructure changes for HVF vGIC\n target/arm: hvf: instantiate GIC early\n hw/arm, target/arm: nested virtualisation on HVF\n hvf: only call hvf_sync_vtimer() when running without the platform\n vGIC\n hvf: gate ARM_FEATURE_PMU register emulation when using the Apple vGIC\n hvf: arm: allow exposing minimal PMU for kernel-irqchip=on\n target/arm: hvf: add asserts for code paths not leveraged when using\n the vGIC\n hvf: sync registers used at EL2\n target/arm: hvf: pass through CNTHCTL_EL2 and MDCCINT_EL1\n hvf: arm: disable SME when nested virt is active\n hvf: arm: physical timer emulation\n hvf: enable nested virtualisation support\n hvf: arm: enable vGIC by default for virt-11.1 and later\n\n accel/hvf/hvf-all.c | 62 +++\n accel/stubs/hvf-stub.c | 11 +\n hw/arm/virt.c | 45 +-\n hw/intc/arm_gicv3_common.c | 4 +\n hw/intc/arm_gicv3_hvf.c | 826 +++++++++++++++++++++++++++++\n hw/intc/arm_gicv3_hvf_stub.c | 25 +\n hw/intc/meson.build | 2 +\n include/hw/arm/virt.h | 2 +\n include/hw/core/boards.h | 1 +\n include/hw/intc/arm_gicv3_common.h | 4 +\n include/system/hvf.h | 8 +\n include/system/hvf_int.h | 1 +\n system/vl.c | 2 +\n target/arm/hvf/hvf.c | 208 +++++++-\n target/arm/hvf/sysreg.c.inc | 44 ++\n target/arm/hvf_arm.h | 5 +\n 16 files changed, 1225 insertions(+), 25 deletions(-)\n create mode 100644 hw/intc/arm_gicv3_hvf.c\n create mode 100644 hw/intc/arm_gicv3_hvf_stub.c"}