{"id":2230405,"url":"http://patchwork.ozlabs.org/api/1.1/covers/2230405/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/cover/20260429-rust_leds-v15-0-97e97b27ebb5@posteo.de/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260429-rust_leds-v15-0-97e97b27ebb5@posteo.de>","date":"2026-04-29T18:00:35","name":"[v15,0/3] rust: leds: add led classdev abstractions","submitter":{"id":91819,"url":"http://patchwork.ozlabs.org/api/1.1/people/91819/?format=json","name":"Markus Probst","email":"markus.probst@posteo.de"},"mbox":"http://patchwork.ozlabs.org/project/linux-pci/cover/20260429-rust_leds-v15-0-97e97b27ebb5@posteo.de/mbox/","series":[{"id":502121,"url":"http://patchwork.ozlabs.org/api/1.1/series/502121/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=502121","date":"2026-04-29T18:00:39","name":"rust: leds: add led classdev abstractions","version":15,"mbox":"http://patchwork.ozlabs.org/series/502121/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/2230405/comments/","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=posteo.de header.i=@posteo.de header.a=rsa-sha256\n header.s=2017 header.b=N2Ii3/5A;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-53410-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de\n header.b=\"N2Ii3/5A\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=185.67.36.65","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=posteo.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=posteo.de"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5QCd2yrZz1yHX\n\tfor ; Thu, 30 Apr 2026 04:03:41 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 340873055A5F\n\tfor ; Wed, 29 Apr 2026 18:00:44 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id F2EC93FE640;\n\tWed, 29 Apr 2026 18:00:40 +0000 (UTC)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id CCBA83BA25B\n\tfor ; Wed, 29 Apr 2026 18:00:38 +0000 (UTC)","from submission (posteo.de [185.67.36.169])\n\tby mout01.posteo.de (Postfix) with ESMTPS id 13057240028\n\tfor ; Wed, 29 Apr 2026 20:00:36 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4g5Q801j66z9rxt;\n\tWed, 29 Apr 2026 20:00:32 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777485640; cv=none;\n b=BqpmqSGYBhv9vcx3c/e1aTw7ethdE0jFFZiC3xQDVy0zk0+P2pfoalsZvxx62ZAw3sD3pM0rROPktiMG1yoFt33R4jjm9vmKrIEBlr2XE1LKQ4mXhWmjCVia5JBx2SiqyApI6xCFZ8PIIsUkfHAuKCrWaJNeh71rER8zBjHvI74=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777485640; c=relaxed/simple;\n\tbh=1DV2nAnJ382/1X9Ep7gcs4VAK24c09kbZ5ONsYgWC6M=;\n\th=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc;\n b=NjA9nQVFd1hn7B6clwsFfXQekq5jgm1/hLDHlXmSYT/+iUcLhD4eqEscSVRRpLYYNWfUWGc6USlim1Ko0nPET0i6dcyE1YdJu3HqCLaEpfexEPoGMjYEKd7Tcu5DlL3WosNDAyPe61SM25W2xUS/sDv8zhDd/NPDis+AADQPAaQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=posteo.de;\n spf=pass smtp.mailfrom=posteo.de;\n dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de\n header.b=N2Ii3/5A; arc=none smtp.client-ip=185.67.36.65","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=2017;\n\tt=1777485637; bh=BJZDKZl760TXI0WLOikc2bCAXSwjOR7rcKiq2jaeDsc=;\n\th=From:Subject:Date:Message-Id:MIME-Version:Content-Type:\n\t Content-Transfer-Encoding:To:Cc:Autocrypt:OpenPGP:From;\n\tb=N2Ii3/5AgepxCT+8DEnHArFxEMcXxtlOUHlvTjcbwWyAt1krTl/HE51CQ7fy/tA3w\n\t 7EZMu5PV3jnn09sdQkvxJhsmh/ZViSXOAA4RC4iY57fuX+eh9iPc3Tjo4xZfSPXBJn\n\t ryp3Nc3mkf++11rptgemPtFbzkYsudu9qLzHhAvY4ZLXo0JF1LSwHuT/Tz5Tp/EVHb\n\t /1OMNG2Ah+Ze1xP+7ukCfvXKCAPiP9WgfsxVuA8MTEjYBWi/qOjh/coLyYYz2xoqvU\n\t qAAV8VJxfF1jWxfTHdo+NZbjTrMuKKxa7c+7QwtcMtlDPtLfH+86Gn+9KUZyTEONOw\n\t /HaLk3vc+Z1wA==","From":"Markus Probst ","Subject":"[PATCH v15 0/3] rust: leds: add led classdev abstractions","Date":"Wed, 29 Apr 2026 18:00:35 +0000","Message-Id":"<20260429-rust_leds-v15-0-97e97b27ebb5@posteo.de>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","X-B4-Tracking":"v=1; b=H4sIADdH8mkC/2XSUWvDIBAH8K9SfJ7FM17UPu17jDGMnquwNp2mY\n aP0u8+2lCTLi3DH/f4i54UVyokK220uLNOYSuqPtQB82TC/d8dP4inUBpNCIgAons9l+PiiULi\n zaKP2MupoWZ0/ZYrp5x729l7rfSpDn3/v2aO5dZ8pOEsZDRc8WKcgNojYmNdTXwbqt4HYLWW0c\n 2nn0lZpWg8YHFjRNv8liCdtBYh2TkFUS8IBtsoYFe3KwmTrsbBQLRoM4E1HUviVlXOrF1ZWG0O\n HYBToTuPKNpNt5OK50FQrwaG1HjsZYGXVZJVc3quqVVF1oAkDQju318fyMn2f6wcYHhtknSvEf\n X84pGG3GfUWePZQh69/FlSYLzUCAAA=","X-Change-ID":"20251114-rust_leds-a959f7c2f7f9","To":"Lee Jones , Pavel Machek ,\n Greg Kroah-Hartman ,\n Dave Ertman , Ira Weiny ,\n Leon Romanovsky , Miguel Ojeda ,\n Alex Gaynor , Gary Guo ,\n\t=?utf-8?q?Bj=C3=B6rn_Roy_Baron?= ,\n Benno Lossin , Andreas Hindborg ,\n Alice Ryhl , Trevor Gross ,\n Danilo Krummrich , \"Rafael J. Wysocki\" ,\n Bjorn Helgaas ,\n =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ,\n Boqun Feng , Boqun Feng ","Cc":"rust-for-linux@vger.kernel.org, linux-leds@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n Markus Probst ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4682;\n i=markus.probst@posteo.de; h=from:subject:message-id;\n bh=1DV2nAnJ382/1X9Ep7gcs4VAK24c09kbZ5ONsYgWC6M=;\n b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBp8kc/K+5+8SdugIgxVyiPqm5GiHRa3Mwh/uwyg\n DU9olxZHE2JAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCafJHPxsUgAAAAAAEAA5t\n YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9LTCg//Zscduo9zWoIDQYg2Bfhm66yXHQrnLb4\n xLRzeY61pc0mVYa4P2rupxQ9kJEVLg99nF36k2M8SpmUiRpXSQ/rvb/iJ2LHCqoJ0eRNQr+fH7Q\n 8cke84vd4+zb8dqqYk/ScvSo+fekq186Q1tqMDP606hHRbnPuyYgz9NBH7si3VQfPn+CUId3V5q\n sKMemTE/2OpUSixZvWdSS6frim0m1gechMgnvE9GeU8uTcE6dlxc2Ogp4Rr2xqf4ZqyJgUU9x4P\n 4DCLzi5g1l92We2FSx9WhNLJFq9eBi2Wfh05mY3vVmVo407mtaUmrbp4+p/kEOf4e2XqEcVcP77\n WhmpgtUQsBz0yLXZkmwWvqc3+wECGZaWmBSERn2SZV4/8nonpE+6C9PP/8JN+jZ4H89eo2hW29H\n 7aMIRcpZU+T7BJcpX+6P0LDHZK9JJiJ9vMI+NWSw35OvqkgaoQ8jhJ+az4MbVFc/hjFM9vTq3qV\n NnAgyLv7pH5qtwjVOEw0VUcMrNdYWVDo6WgOBwRV+RZUdGI11Kt0nxj9HqEFQU3cSBCJZ+lyANH\n dbcZmDKR/LBrqaArH1N/XhtDOt5fOtI2SEmfcNKsfXJ9Uf3kMt/1jjFcOWhu6i1UrIRWHY+vozr\n qo1t/GzZD/LxnXi7P/PiK9OvzxJTCglgXTNkWGs8t3XwtSCLHet0=","X-Developer-Key":"i=markus.probst@posteo.de; a=openpgp;\n fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2","Autocrypt":"addr=markus.probst@posteo.de; prefer-encrypt=mutual;\n keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO\n WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+\n /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA\n RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja\n oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ\n xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+\n FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6\n OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8\n 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC\n XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0\n rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2\n H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH\n 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV\n HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS\n B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9\n lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP\n ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm\n 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5\n F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV\n G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM\n L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj\n BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo\n 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO\n 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3\n IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD\n +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4\n 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe\n Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu\n 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj\n Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF\n AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec\n Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv\n oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp\n xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN\n jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD\n DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR\n wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU\n 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc\n l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A\n aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8=","OpenPGP":"url=https://posteo.de/keys/markus.probst@posteo.de.asc;\n preference=encrypt"},"content":"This patch series has previously been contained in\nhttps://lore.kernel.org/rust-for-linux/20251008181027.662616-1-markus.probst@posteo.de/T/#t\nwhich added a rust written led driver for a microcontroller via i2c.\n\nAs the reading and writing to the i2c client via the register!\nmacro has not been implemented yet [1], the patch series will only\ncontain the additional abstractions required.\n\n[1] https://lore.kernel.org/rust-for-linux/DDDS2V0V2NVJ.16ZKXCKUA1HUV@kernel.org/\n\nThe following changes were made:\n* add basic led classdev abstractions to register and unregister leds\n\n* add basic led classdev abstractions to register and unregister\n multicolor leds\n\nChanges since v14:\n* fix issues reported by Sashiko bot:\n * add missing inlines\n * add missing Sync trait bound\n * fix vertical import layout for public export of private types\n * fix potential memory leak, if a multicolor led device with over\n `u32::MAX` subleds is registered\n* remove default_trigger option\n* fix missing CAST doc\n\nChanges since v13:\n* rebased onto v7.1-rc1\n\nChanges since v12:\n* add `led::DeviceBuilder::name()` and `DeviceBuilderState'\n* add `led::Color::as_c_str`\n\nChanges since v11:\n* use `led::DeviceBuilder` instead of `led::InitData`\n* use static_assert instead of const { assert!(...) }\n* restructured patches to avoid moving `led::Device` from\n rust/kernel/led.rs to rust/kernel/led/normal.rs in the 2. patch\n\nChanges since v10:\n* allow in-place initialization of `LedOps`\n* run rustfmt for code inside `try_pin_init!`\n\nChanges since v9:\n* add missing periods in documentation\n* duplicate `led::Device` and `led::Adapter` instead of using a complex\n trait\n* fix imports not using prelude\n* adapt to CStr change\n* documented `led::Color::Multi` and `led::Color::Rgb`\n\nChanges since v8:\n* accept `Option>` in `led::InitData::fwnode()`\n* make functions in `MultiColorSubLed` const\n* drop the \"rust: Add trait to convert a device reference to a bus\n device reference\" patch, as it has been picked into driver-core\n\nChanges since v7:\n* adjusted import style\n* added classdev parameter to callback functions in `LedOps`\n* implement `led::Color`\n* extend `led::InitData` with\n - initial_brightness\n - default_trigger\n - default_color\n* split generic and normal led classdev abstractions up (see patch 3/4)\n* add multicolor led class device abstractions (see patch 4/4)\n* added MAINTAINERS entry\n\nChanges since v6:\n* fixed typos\n* improved documentation\n\nChanges since v5:\n* rename `IntoBusDevice` trait into `AsBusDevice`\n* fix documentation about `LedOps::BLOCKING`\n* removed dependency on i2c bindings\n* added `AsBusDevice` implementation for `platform::Device`\n* removed `device::Device` fallback implementation\n* document that `AsBusDevice` must not be used by drivers and is\n intended for bus and class device abstractions only.\n\nChanges since v4:\n* add abstraction to convert a device reference to a bus device\n reference\n* require the bus device as parent device and provide it in class device\n callbacks\n* remove Pin> abstraction (as not relevant for the led\n abstractions)\n* fixed formatting in `led::Device::new`\n* fixed `LedOps::BLOCKING` did the inverse effect\n\nChanges since v3:\n* fixed kunit tests failing because of example in documentation\n\nChanges since v2:\n* return `Devres` on `led::Device` creation\n* replace KBox with T in struct definition\n* increment and decrement reference-count of fwnode\n* make a device parent mandatory for led classdev creation\n* rename `led::Handler` to `led::LedOps`\n* add optional `brightness_get` function to `led::LedOps`\n* use `#[vtable]` instead of `const BLINK: bool`\n* use `Opaque::cast_from` instead of casting a pointer\n* improve documentation\n* improve support for older rust versions\n* use `&Device` for parent\n\nChanges since v1:\n* fixed typos noticed by Onur Özkan\n\nSigned-off-by: Markus Probst \n---\nMarkus Probst (3):\n rust: leds: add basic led classdev abstractions\n rust: leds: add Mode trait\n rust: leds: add multicolor classdev abstractions\n\n MAINTAINERS | 8 +\n rust/bindings/bindings_helper.h | 1 +\n rust/kernel/led.rs | 351 +++++++++++++++++++++++++++++++++++\n rust/kernel/led/multicolor.rs | 396 ++++++++++++++++++++++++++++++++++++++++\n rust/kernel/led/normal.rs | 229 +++++++++++++++++++++++\n rust/kernel/lib.rs | 1 +\n 6 files changed, 986 insertions(+)\n---\nbase-commit: 5e9b7d093f3f77cb0af4409559e3d139babfb443\nchange-id: 20251114-rust_leds-a959f7c2f7f9"}