{"id":2228490,"url":"http://patchwork.ozlabs.org/api/1.1/covers/2228490/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/cover/cover.1777214801.git.lucien.xin@gmail.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"","date":"2026-04-26T14:46:39","name":"[net,v2,0/2] sctp: fix a vtag verification failure caused by stale INITs","submitter":{"id":61073,"url":"http://patchwork.ozlabs.org/api/1.1/people/61073/?format=json","name":"Xin Long","email":"lucien.xin@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/cover/cover.1777214801.git.lucien.xin@gmail.com/mbox/","series":[{"id":501540,"url":"http://patchwork.ozlabs.org/api/1.1/series/501540/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=501540","date":"2026-04-26T14:46:39","name":"sctp: fix a vtag verification failure caused by stale INITs","version":2,"mbox":"http://patchwork.ozlabs.org/series/501540/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/2228490/comments/","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=j8Pb2hy+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12199-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"j8Pb2hy+\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.219.44","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3V2f0S0Bz1y2d\n\tfor ; Mon, 27 Apr 2026 00:49:13 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id C48CA300349E\n\tfor ; Sun, 26 Apr 2026 14:49:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 625DD365A1B;\n\tSun, 26 Apr 2026 14:49:00 +0000 (UTC)","from mail-qv1-f44.google.com (mail-qv1-f44.google.com\n [209.85.219.44])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 890331F1537\n\tfor ; Sun, 26 Apr 2026 14:48:58 +0000 (UTC)","by mail-qv1-f44.google.com with SMTP id\n 6a1803df08f44-8aca2726f61so114420496d6.0\n for ;\n Sun, 26 Apr 2026 07:48:58 -0700 (PDT)","from wsfd-netdev58.anl.eng.rdu2.dc.redhat.com ([66.187.232.140])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b02aebc655sm232579146d6.48.2026.04.26.07.48.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 07:48:56 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777214939; cv=none;\n b=uxaEdYQDbJdi0F7m2wOa0zjT14HYtMqRq3I8Ji7nIlPXbfhO0of+K8ehezuEQK7e05g3dsweyI/jkMMlG6wvYEHnRU6Qx8Ufm9HJeIll0rTMWF4vXJDXnsx+jVZtv7ISSYIPoRJ17QW/AksyWkKLjg9Hv2RfZjsgHY6Vx6GiUkc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777214939; c=relaxed/simple;\n\tbh=0/ZauZOQB/NP1QcAH+PDITEaXUC773OeN19DfxcW1yQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=RVmQAlhrEt7gPzqAOukC0gdSZ3grTKUoqgeZFcGLcXB2zS9s98lfREQxYR77FUi8JPFa/nloJgXyoN/+LWt6+47HHafkyVqlMPtzpY4hOHOZWnp5RKSNXS/fCA/Sx7QCXcz8ue+I999evZVPAugDSL3RlIdPaewyZf7nMWktvSI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=j8Pb2hy+; arc=none smtp.client-ip=209.85.219.44","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777214937; x=1777819737;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=EMSX8d1QgLZUoJnKt34AnkG63ZeJBVmP3ekDSJT4BDs=;\n b=j8Pb2hy+d7PpZUfwcrhGzURJ3yc5i1yFgqmIuBIPKXfnfuyojj+p3psQHT7x2/N4dL\n FIL+orvjFmJA1KfPcPmVIkCHgn9oayoX3ZoCMwHHucFNJKcw1MP5H4c/khHVwb148c2R\n ww7ElTN7ZK1VTAoPz91nnXWZIKUjrsEyhEaVe5k/GIK6rEAXT/2rFYDkY7VvwK0y1yKx\n JvtmIpXZ107zb7jKjdMKdGZdL3wmlmFb3YN2tts5mogsR3EnaLPWHhnkWerfXCABJjJ8\n iVzt/kuvHy7TINI0C+i7UmYk6WIE5EKk8hu2AUCJE97/16kzdat2tOAoDxx9noU9tISp\n R8qw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777214937; x=1777819737;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=EMSX8d1QgLZUoJnKt34AnkG63ZeJBVmP3ekDSJT4BDs=;\n b=BCxRG1ErUg3ybVZ1LX9lW8ShQNRQQMVLNB+zvW28KYTaAIzEAZwvz4d4ZEXBUJVvnN\n SR2ktgJgxTqy1GqihsHoRSye/GS6V5htnS3nbIlHDpjQJIK2q+17HNAabws0bv+W8aAU\n 2FjwvBOnsMnO7WA2koCipb0rBUX2wgiwjOn4WAVE7bGFr0GYK5YReS80xbOaFng6ouP4\n uS0/YzH39A0U9t+LsngS5QkFLy4zBRlFxxqZ/z1kqGCp2u9iJkzFKtWG55LZgiPVzK8+\n 4cYPYFUbI4f4mNDfHER3mYs9ubNkV/NUDRlWFDKmVTftaBjX3kqdKvYPf+jqJLjkaVy2\n 3/gg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+EhvjYhgmKrqG+YbOEWgh8NAsGprsGutyA2O0Gs0E0KGwIC5IJzOG0z3H577mvN2nOoJqS6JfWAlWF6e2NlI0=@vger.kernel.org","X-Gm-Message-State":"AOJu0YzABc4wHaHUrPTsbOsQcoX95y5UwRvwj9acGkzTtKyxHwtUKJdZ\n\t61x0vlZcf77uRsQPUIHtyV1WmDpfLR7w/K3tvA9CwIcApjkjCKCxvurf","X-Gm-Gg":"AeBDiesbZo/8zbCh7lH9iBsnHtn4SRt8AbPA96IkT2z4Uxs1rvDG+F6g5fDwa6RX6ok\n\tybyf85MNF05HoaemuSIeSdrj3nOjRX1CW/5QJVh11kv2VofYghhkMdlB2ZP5Dwr6dX1aroRb7km\n\tVxov3K/N6O+XmX8aFTun3eGgLdZ6gNVZnuZ/VcQpLXIYAZV9PoTHD1y1QA4Ans3uZMVlMZkdrSk\n\tGA+AnHQSw2yHRWyooZytNveQVcnEpqhsrkFt9n5GZui7ZyxWdBhebWrAJWpLUDd5asCZjUiVsux\n\txLljIT87fztEX4fpZ9elEJwH8/hv1qByou0Id4tQwIdErvhhh5GVcougXDkK77TVsp90l/9ZuaX\n\t8Xi1+WHAvbnkITlD1LVz3d8rMxE3Aje8KgXGo3DFHYVVkQBuDiWGAtXqW1zB4o4oV4Dh62LtFk9\n\tDxg1tCO+uDIMrLbgrrtWYw4MS7q3k6QjGgp5VD176WhTn8Qpp4UqDQjZkJOtmxD0HZah8lx0U4P\n\tJkuC0OAkPitp/0gPxPychS+BrcZmqfaK02xifW6BzoTai/bTEKvu+Mi/McbW315fa2c18BaGes=","X-Received":"by 2002:a05:6214:d0e:b0:8ac:aa89:6bbc with SMTP id\n 6a1803df08f44-8b0446f0cb3mr459818986d6.16.1777214937472;\n Sun, 26 Apr 2026 07:48:57 -0700 (PDT)","From":"Xin Long ","To":"network dev ,\n\tnetfilter-devel@vger.kernel.org,\n\tlinux-sctp@vger.kernel.org","Cc":"davem@davemloft.net,\n\tkuba@kernel.org,\n\tEric Dumazet ,\n\tPaolo Abeni ,\n\tSimon Horman ,\n\tPablo Neira Ayuso ,\n\tFlorian Westphal ,\n\tPhil Sutter ,\n\tMarcelo Ricardo Leitner ,\n\tYi Chen ","Subject":"[PATCH net v2 0/2] sctp: fix a vtag verification failure caused by\n stale INITs","Date":"Sun, 26 Apr 2026 10:46:39 -0400","Message-ID":"","X-Mailer":"git-send-email 2.47.1","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Similar to Scenario B in commit 8e56b063c865 ( netfilter: handle the\nconnecting collision properly in nf_conntrack_proto_sctp\"):\n\nScenario B: INIT_ACK is delayed until the peer completes its own handshake\n\n 192.168.1.2 > 192.168.1.1: sctp (1) [INIT] [init tag: 3922216408]\n 192.168.1.1 > 192.168.1.2: sctp (1) [INIT] [init tag: 144230885]\n 192.168.1.2 > 192.168.1.1: sctp (1) [INIT ACK] [init tag: 3922216408]\n 192.168.1.1 > 192.168.1.2: sctp (1) [COOKIE ECHO]\n 192.168.1.2 > 192.168.1.1: sctp (1) [COOKIE ACK]\n 192.168.1.1 > 192.168.1.2: sctp (1) [INIT ACK] [init tag: 3914796021] *\n\nThere is another case:\n\nScenario F: INIT is delayed until the peer completes its own handshake\n\n 192.168.1.2 > 192.168.1.1: sctp (1) [INIT] [init tag: 3922216408]\n (OVS upcall)\n 192.168.1.1 > 192.168.1.2: sctp (1) [INIT] [init tag: 144230885]\n 192.168.1.2 > 192.168.1.1: sctp (1) [INIT ACK] [init tag: 3922216408]\n 192.168.1.1 > 192.168.1.2: sctp (1) [COOKIE ECHO]\n 192.168.1.2 > 192.168.1.1: sctp (1) [COOKIE ACK]\n 192.168.1.2 > 192.168.1.1: sctp (1) [INIT] [init tag: 3922216408]\n (delayed)\n 192.168.1.1 > 192.168.1.2: sctp (1) [INIT ACK] [init tag: 3914796021] *\n\nIn this case, the delayed INIT (e.g. due to OVS upcall) is recorded by\nconntrack, which prevents vtag verification from dropping the unexpected\nINIT-ACK in nf_conntrack_sctp_packet():\n\n vtag = ct->proto.sctp.vtag[!dir];\n if (!ct->proto.sctp.init[!dir] && vtag && vtag != ih->init_tag)\n goto out_unlock;\n\nThis happens because ct->proto.sctp.init[!dir] is set by the delayed INIT,\neven though it is stale.\n\nFix this in two parts:\n\n- In netfilter: Do not record INITs whose init_tag matches the peer vtag,\n as they carry no new handshake state in the 1st patch.\n\n- In SCTP: Prevent endpoints from responding to such INITs with INIT-ACK,\n ensuring correctness even when middleboxes lack the netfilter fix in\n the 2nd patch.\n\nA follow-up selftest for this scenario will be posted in a separate patch\nby Yi Chen.\n\nXin Long (2):\n netfilter: skip recording stale or retransmitted INIT\n sctp: discard stale INIT after handshake completion\n\n net/netfilter/nf_conntrack_proto_sctp.c | 10 +++++++---\n net/sctp/sm_statefuns.c | 6 ++++++\n 2 files changed, 13 insertions(+), 3 deletions(-)"}