{"id":2222880,"url":"http://patchwork.ozlabs.org/api/1.1/covers/2222880/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20260414003001.97571-1-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260414003001.97571-1-philmd@linaro.org>","date":"2026-04-14T00:29:32","name":"[v3,00/27] monitor: Remove need of per-target handlers","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20260414003001.97571-1-philmd@linaro.org/mbox/","series":[{"id":499762,"url":"http://patchwork.ozlabs.org/api/1.1/series/499762/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499762","date":"2026-04-14T00:29:32","name":"monitor: Remove need of per-target handlers","version":3,"mbox":"http://patchwork.ozlabs.org/series/499762/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/2222880/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Zpb+pnWT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlZ05dx8z1yHH\n\tfor ; Tue, 14 Apr 2026 10:31:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCRfS-0001Ih-4a; Mon, 13 Apr 2026 20:30:14 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCRfO-0001G7-6m\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:30:10 -0400","from mail-wm1-x329.google.com ([2a00:1450:4864:20::329])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wCRfL-0002f7-0A\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:30:09 -0400","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-488a4bc360bso27337075e9.0\n for ; Mon, 13 Apr 2026 17:30:05 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ede1e826sm12835515e9.6.2026.04.13.17.30.02\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 13 Apr 2026 17:30:02 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776126603; x=1776731403; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=WssZ5uJWE2KTCsVGYiCPJWJhvSyVD2anQoKcMv+JU7Q=;\n b=Zpb+pnWToj4qWnve8oqoUPdLdMt/T8Y8XxSkV2Ztqeregz57Grkadnv29RAOMLhBWr\n X8vKELw9gJYhiB9MMvbEDT7UewHQZ6jZDRYCktQiI13dqPFpgmU+mUSefNUQUCj1wucg\n m+1Yl/tGh/g7Qh9JGTjXw1H0rDzTIOHYwv0f/xvx+qETafkjgDkZlklO1BQgprqS0rXu\n PkxU1Dfl8xcdAgaRhgfBt2qsUQFJdtfDy6wb5aRtQdSwaJHPbKar4qqtJAaF1qicQAFf\n 7oe8klcPVvdaXK/6ABURCi1G+O17BxsWBo5yWD02ZRB9s7RARYK4PdKoF8oLzntDiPon\n EsbA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776126603; x=1776731403;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=WssZ5uJWE2KTCsVGYiCPJWJhvSyVD2anQoKcMv+JU7Q=;\n b=onNSLb7KiaLpt7Aciwy5TN+PPzNGWbvQG8n/vLbgxJJTvjFhw6fdsPgVIfTiH6f1iA\n if9dE6yzixZPbf73AKQwlFDsLoabJAiw/K5ii3RRJzbfz35ySJofCcCqeyg+ruSPhy1Y\n oLaLUPPrmfI5bKjayBQcCDqduiZevezrOCvaztX3ORL12ZO+eVuXUgMNGWAqK6pJlOyn\n 0u0w/4jI6FPHbhueODZLfPGVIqoooqY13RdEmVHcPxdfqhgR0WKdq3ihoVfZ6bcnu+jl\n KOHxJZH7tUXt4szwJzxIV5em2WK6Y9NXSYr5mo+DAoMyM/2UBEXqD1SNwIx9QgNZWhXb\n h+/w==","X-Gm-Message-State":"AOJu0YzItALNpPpLxNyX2OfQCI4nYPaBQloqyGjgcM1kCO7NB78qmrpK\n hZjYzlz2/1cP99a/v7+qnGrSNCfRWehCjk3gqXRr82K1NgOngKLvYFI2oyJ5nsTVLfGQiATYtxq\n 71gN31ZU=","X-Gm-Gg":"AeBDieuOIhz/jZ2WLV6jIG4Ah5RGpnUWGhYZQOQnCgzTWiOXfKU71zlzZi8IX/MGxw1\n lmxvP2uIJ5txLDcc9MRwEbY8YIhWpoTM8cO2EnUBaT8rL8hlyFpVnKjtSOV5u4USRsD/DO+lN1l\n 1C0JJBB57DeXut4dTs95a/C9DZ8dqbqeer9Ignf1wfStUitawEA2Qcwy9NG/P9BqVs+ZdMN6irT\n 6i8K3f1SB6tQqkgf6qDItp7f4ILHZHSQ785C+j/xsp0vMrnU7q5gByH86gBxQUlLQ/VI14UtNax\n teLFlj8P5zGMGznrwqgpdKtvJl2ncIxCs5S2MSg4I9dkmmG0RRN30C3Ms32mFsUiAhDIXr136eC\n BRB9Y7y3A70TLARXC3D1eJ5+utPToQ2Lj5+ih1o3/Ck3TOPum26oATAP0cEsD6D9db7ITQewJux\n ZB9RW7bgWnkH8ksOpdnIzRG8EPx/06iVBe2IBIIj7cRI9rHnJq0fnxrYlWvlDxPZTxSRRcu9aV","X-Received":"by 2002:a05:600d:1c:b0:487:1108:48bc with SMTP id\n 5b1f17b1804b1-488d6836d87mr160121775e9.17.1776126603345;\n Mon, 13 Apr 2026 17:30:03 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Markus Armbruster ,\n Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Paolo Bonzini ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH v3 00/27] monitor: Remove need of per-target handlers","Date":"Tue, 14 Apr 2026 02:29:32 +0200","Message-ID":"<20260414003001.97571-1-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::329;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Missing review: 1-3, 16, 18\n\nSince v2:\n- Addressed rth review comments\n\nChanges needed for the single binary (and heterogeneous emulation).\n\nConvert target_monitor_defs() and target_monitor_defs()\nto SysemuCPUOps fields, adapting the 4 targets using these\n'legacy' code.\n\nInstead of filtering the commands per target / device at\nbuild time, add a new field to HMPCommand to filter them\nat runtime, allowing to compile the command array once.\n\nPhilippe Mathieu-Daudé (27):\n stubs: Rename monitor* -> qmp* files\n monitor/meson: Use SPICE with migration HMP commands\n monitor: Restrict monitor_set_cpu() method scope\n monitor: Make 'info via' a generic command\n monitor: Make Xen emulation commands generic ones\n system: Expose 'arch_init.h' as 'qemu/base-arch-defs.h'\n monitor: Introduce HMPCommand::arch_bitmask field\n hw/s390x: Reduce 'monitor/monitor.h' inclusions\n monitor: Do not check TARGET_S390X to build s390x commands\n monitor: Do not check TARGET_I386 to build target/i386/ commands\n monitor: Do not check TARGET_I386 to build 'info sgx' command\n monitor: Do not check TARGET_I386 to build 'info sev' command\n monitor: Do not check TARGET_I386/RISCV to build 'info mem' command\n monitor: Do not check multiple TARGET_* to build 'info tlb' command\n cpus: Introduce SysemuCPUOps::monitor_get_register() hook\n target/riscv: Register target_get_monitor_def in SysemuCPUOps\n monitor: Remove target_get_monitor_def()\n monitor: Have MonitorDef::get_value() always return int64_t type\n monitor: Reduce target-specific methods further\n monitor: Remove 'monitor/hmp-target.h' header\n monitor: Forward-declare the MonitorDef type\n cpus: Introduce SysemuCPUOps::monitor_defs hook\n target/i386: Replace target_monitor_defs -> SysemuCPUOps::monitor_defs\n target/m68k: Replace target_monitor_defs -> SysemuCPUOps::monitor_defs\n target/sparc: Replace target_monitor_defs ->\n SysemuCPUOps::monitor_defs\n monitor: Remove target_monitor_defs()\n monitor: Merge hmp-target.c code within hmp-cmds.c\n\n MAINTAINERS | 14 ++-\n include/hw/core/sysemu-cpu-ops.h | 14 +++\n include/hw/s390x/storage-attributes.h | 4 -\n include/hw/s390x/storage-keys.h | 3 -\n include/monitor/hmp-target.h | 46 -------\n include/monitor/hmp.h | 21 ++++\n include/monitor/monitor.h | 1 -\n .../qemu/base-arch-defs.h | 10 +-\n include/qemu/typedefs.h | 1 +\n monitor/monitor-internal.h | 13 +-\n target/riscv/internals.h | 3 +\n hw/i386/kvm/xen-stubs.c | 12 ++\n hw/i386/sgx-hmp-stub.c | 16 +++\n hw/i386/sgx-stub.c | 6 -\n hw/i386/sgx.c | 1 -\n hw/misc/mos6522-stub.c | 16 +++\n hw/pci/pci.c | 2 +-\n hw/s390x/s390-skeys.c | 2 +\n hw/s390x/s390-stattrib.c | 2 +\n monitor/hmp-cmds.c | 41 ++++++-\n monitor/hmp-target.c | 115 ------------------\n monitor/hmp.c | 45 ++++++-\n stubs/hmp-cmd-info_mem.c | 12 ++\n stubs/hmp-cmd-info_sev.c | 16 +++\n stubs/hmp-cmd-info_tlb.c | 12 ++\n stubs/hmp-cmds-hw-s390x.c | 15 +++\n stubs/hmp-cmds-target-i386.c | 13 ++\n stubs/{monitor-arm-gic.c => qmp-arm-gic.c} | 0\n ...or-cpu-s390x-kvm.c => qmp-cpu-s390x-kvm.c} | 0\n .../{monitor-cpu-s390x.c => qmp-cpu-s390x.c} | 0\n stubs/{monitor-cpu.c => qmp-cpu.c} | 0\n stubs/{monitor-i386-rtc.c => qmp-i386-rtc.c} | 0\n stubs/{monitor-i386-sev.c => qmp-i386-sev.c} | 0\n stubs/{monitor-i386-sgx.c => qmp-i386-sgx.c} | 0\n stubs/{monitor-i386-xen.c => qmp-i386-xen.c} | 0\n stubs/target-get-monitor-def.c | 29 -----\n stubs/target-monitor-defs.c | 7 --\n system/arch_init.c | 2 +-\n system/qdev-monitor.c | 2 +-\n system/vl.c | 2 +-\n target/i386/cpu-apic.c | 1 -\n target/i386/cpu.c | 29 +++++\n target/i386/monitor.c | 26 ----\n target/i386/sev-system-stub.c | 6 -\n target/i386/sev.c | 1 -\n target/m68k/cpu.c | 18 +++\n target/m68k/monitor.c | 22 ----\n target/ppc/monitor.c | 2 -\n target/riscv/cpu.c | 1 +\n target/riscv/monitor.c | 12 +-\n target/sh4/monitor.c | 1 -\n target/sparc/cpu.c | 19 +++\n target/sparc/monitor.c | 19 ---\n target/xtensa/monitor.c | 1 -\n hmp-commands-info.hx | 26 ++--\n hmp-commands.hx | 13 +-\n hw/i386/meson.build | 1 +\n hw/misc/meson.build | 1 +\n migration/meson.build | 2 +-\n monitor/meson.build | 5 +-\n stubs/meson.build | 23 ++--\n 61 files changed, 375 insertions(+), 352 deletions(-)\n delete mode 100644 include/monitor/hmp-target.h\n rename system/arch_init.h => include/qemu/base-arch-defs.h (92%)\n create mode 100644 hw/i386/sgx-hmp-stub.c\n create mode 100644 hw/misc/mos6522-stub.c\n delete mode 100644 monitor/hmp-target.c\n create mode 100644 stubs/hmp-cmd-info_mem.c\n create mode 100644 stubs/hmp-cmd-info_sev.c\n create mode 100644 stubs/hmp-cmd-info_tlb.c\n create mode 100644 stubs/hmp-cmds-hw-s390x.c\n create mode 100644 stubs/hmp-cmds-target-i386.c\n rename stubs/{monitor-arm-gic.c => qmp-arm-gic.c} (100%)\n rename stubs/{monitor-cpu-s390x-kvm.c => qmp-cpu-s390x-kvm.c} (100%)\n rename stubs/{monitor-cpu-s390x.c => qmp-cpu-s390x.c} (100%)\n rename stubs/{monitor-cpu.c => qmp-cpu.c} (100%)\n rename stubs/{monitor-i386-rtc.c => qmp-i386-rtc.c} (100%)\n rename stubs/{monitor-i386-sev.c => qmp-i386-sev.c} (100%)\n rename stubs/{monitor-i386-sgx.c => qmp-i386-sgx.c} (100%)\n rename stubs/{monitor-i386-xen.c => qmp-i386-xen.c} (100%)\n delete mode 100644 stubs/target-get-monitor-def.c\n delete mode 100644 stubs/target-monitor-defs.c"}