{"id":2220957,"url":"http://patchwork.ozlabs.org/api/1.1/covers/2220957/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20260408131216.2662245-1-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408131216.2662245-1-aleksandr.loktionov@intel.com>","date":"2026-04-08T13:12:08","name":"[iwl-next,v2,0/8] ixgbe: nits and improvements","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/1.1/people/75597/?format=json","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20260408131216.2662245-1-aleksandr.loktionov@intel.com/mbox/","series":[{"id":499140,"url":"http://patchwork.ozlabs.org/api/1.1/series/499140/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499140","date":"2026-04-08T13:12:08","name":"ixgbe: nits and improvements","version":2,"mbox":"http://patchwork.ozlabs.org/series/499140/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/2220957/comments/","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=COUxdM7u;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frNlD1sm9z1xy1\n\tfor ; Wed, 08 Apr 2026 23:12:24 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id E1CC540EE7;\n\tWed, 8 Apr 2026 13:12:22 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 2XVs-uLvg9qC; Wed, 8 Apr 2026 13:12:22 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 2F60340EC1;\n\tWed, 8 Apr 2026 13:12:22 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id BAF0E1F6\n for ; Wed, 8 Apr 2026 13:12:20 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id AD2D240EC1\n for ; Wed, 8 Apr 2026 13:12:20 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id eu_5C5rsm5ii for ;\n Wed, 8 Apr 2026 13:12:19 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 9A1B840E98\n for ; Wed, 8 Apr 2026 13:12:19 +0000 (UTC)","from orviesa007.jf.intel.com ([10.64.159.147])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2026 06:12:19 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa007.jf.intel.com with ESMTP; 08 Apr 2026 06:12:18 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2F60340EC1","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9A1B840E98"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775653942;\n\tbh=965ivX3ruq3mNfDwovhEX4tCZQ9C8OdGvYMdrkq3s9w=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=COUxdM7uTOQEtNmHoIV9fo621koxy6pPB0SHNSR0H1fZYuuhB+VIdLyxWJaDc0wfF\n\t ELG9r7jEl3tHyR6JZB/ZUWvWd+T57xypd7r9cYt+NBcwiSdt6ujKAH5NEMQx8R68/u\n\t PaapApcsgixsXo/E5DHMMrk8yqmx5u+kkkQFLen04BHD6FYllDCiiZTcQgf/1Knj/B\n\t bz6KVYk2sF0LmNTYwgmdi1gOdbCCZ8004aBsHl+SoOA/cKX7V5u90sfkoKWBQmbOyC\n\t Tv9qt8c1yOc8C6VZ+hihHP9R3b7eXR6o0I6uaQhywQpFbBhAE70GJ9C0OEuOaWL0e5\n\t WqqTyzt2oDTXQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.7;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 9A1B840E98","X-CSE-ConnectionGUID":["tFHHvAFnS9+a6CH6fOE1VQ==","x2+7OnqDQAqqhJSJD2OAIQ=="],"X-CSE-MsgGUID":["WOsbIXf0R6mkkP4gspvgwQ==","OzxT01VaRrql0uo/QazW1A=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11752\"; a=\"102087254\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"102087254\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"228715050\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org","Date":"Wed, 8 Apr 2026 15:12:08 +0200","Message-ID":"<20260408131216.2662245-1-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775653940; x=1807189940;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=ntpjB1EZtCslNyS93hZX36BdvkZc2KDqWWKQnlUrZQk=;\n b=Tl1htdcaGJBqoQnVOC0fynfZjakxZ0xzPub+UpAtEbgNLP+FvtML5/4y\n 4crNs4tvZrki2+8I4OYICGYjZSUjHxVEdL84UaBR/prdPuAOO/PrPTIPy\n P8Tx2SWlbBUbX6YcSeZsSZOszy7W5Hims01noxAya6ChqbdpUXpBuDqT6\n iM00snCAaOmZUmFfGVOnW0W1zUnPNr6QezyJhDKeEsfM5Dgwt/ZLWJ2hd\n 9zwI85nOuOP6pYxcBl+54ITmaswUkCtAn2XZ6kWHFqEhQJXc1C6a8KanM\n 3qgSi0ORNbRRBG5ZmXfh7jd5kSOBZRwBiX69qpcAXB0/VF6aaAUpwnFfR\n w==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Tl1htdca"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v2 0/8] ixgbe: nits and\n improvements","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Eight cleanups and improvements for the ixgbe driver.\n\nPatches 1-4 split the adaptive-ITR algorithm improvements into\nindependently reviewable pieces as requested by Simon Horman. Each\npatch is self-contained and can be reviewed and reverted independently:\n 1. Lower IXGBE_ITR_ADAPTIVE_MAX_USECS from 126 to 84 to prevent RX\n starvation at minimum bulk-mode rates.\n 2. Add ixgbe_container_is_rx() helper and refine the RX-specific\n latency algorithm (thresholds, no-packet handling, mode tracking).\n 3. Limit ITR decrease in latency mode to at most 2 us per update so\n ACK workloads do not overdrive moderation.\n 4. Add IXGBE_ITR_ADAPTIVE_MASK_USECS constant to replace the\n open-coded ~IXGBE_ITR_ADAPTIVE_LATENCY complement in ixgbe_set_itr.\n\nPatch 5 removes ixgbe_ping_all_vfs() from both ixgbe_watchdog_link_is_up()\nand ixgbe_watchdog_link_is_down(). The original submission only removed\nthe call from the link-up path; this version also removes it from the\nlink-down path, which carries the same race window against VF mailbox\ninitialization.\n\nPatch 6 replaces ktime_to_ns(ktime_get_real()) with ktime_get_real_ns().\n\nPatch 7 restructures ixgbe_fcoe_ddp_setup() so that dma_pool_alloc()\nis called outside the get_cpu()/put_cpu() preemption-disabled section,\nenabling GFP_KERNEL instead of GFP_ATOMIC. The prior submission left\nthe allocation inside the preempt-off block (GFP_KERNEL can sleep under\ndirect reclaim, which triggers a BUG() with preemption disabled).\n\nPatch 8 fixes six local variables declared as u32 that are used to\nstore signed kernel error codes. Reviewed by Simon Horman.\n\nChanges in v2:\n - 1-4/8: Split monolithic ITR cleanup into four independent patches\n as requested by Simon Horman.\n - 5/8: Extend fix to also remove ixgbe_ping_all_vfs() from\n ixgbe_watchdog_link_is_down() to cover the identical race.\n - 6/8: No code change; add [N/M] numbering.\n - 7/8: Move dma_pool_alloc() outside get_cpu()/put_cpu() so\n GFP_KERNEL is used safely without sleeping under preempt-off.\n - 8/8: Add Reviewed-by: Simon Horman; no code change.\n\n---\n\nAlexander Duyck (4):\n ixgbe: lower IXGBE_ITR_ADAPTIVE_MAX_USECS to prevent RX starvation\n ixgbe: add ixgbe_container_is_rx() helper and refine RX adaptive ITR\n ixgbe: limit ITR decrease in latency mode to prevent ACK overdrive\n ixgbe: add IXGBE_ITR_ADAPTIVE_MASK_USECS constant\n\nAleksandr Loktionov (2):\n ixgbe: remove ixgbe_ping_all_vfs() from link state change handlers\n ixgbe: use GFP_KERNEL in ixgbe_fcoe_ddp_setup()\n\nJacob Keller (1):\n ixgbe: use ktime_get_real_ns() in ixgbe_ptp_reset()\n\nAleksandr Loktionov (1):\n ixgbe: use int instead of u32 for error code variables\n\n drivers/net/ethernet/intel/ixgbe/ixgbe.h | 5 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 50 +++++++----\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 97 ++++++++++++------\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 6 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 12 +--\n 6 files changed, 113 insertions(+), 59 deletions(-)"}