{"id":977,"url":"http://patchwork.ozlabs.org/api/1.0/patches/977/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<200809222152.m8MLqO0X031981@imap1.linux-foundation.org>","date":"2008-09-22T21:52:24","name":"[15/21] forcdeth: increase max_interrupt_work","commit_ref":null,"pull_url":null,"state":"rfc","archived":true,"hash":"3d93c1eca9c750bd6480be455fc0e75d3007fa23","submitter":{"id":107,"url":"http://patchwork.ozlabs.org/api/1.0/people/107/?format=json","name":"Andrew Morton","email":"akpm@linux-foundation.org"},"delegate":{"id":36,"url":"http://patchwork.ozlabs.org/api/1.0/users/36/?format=json","username":"jgarzik","first_name":"Jeff","last_name":"Garzik","email":"jgarzik@pobox.com"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/200809222152.m8MLqO0X031981@imap1.linux-foundation.org/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/977/checks/","tags":{},"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id AB0DADDEF3\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 07:58:27 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754121AbYIVV6O (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 22 Sep 2008 17:58:14 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1754095AbYIVV6O\n\t(ORCPT <rfc822; netdev-outgoing>); Mon, 22 Sep 2008 17:58:14 -0400","from smtp1.linux-foundation.org ([140.211.169.13]:48660 \"EHLO\n\tsmtp1.linux-foundation.org\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1754036AbYIVV6L (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 22 Sep 2008 17:58:11 -0400","from imap1.linux-foundation.org (imap1.linux-foundation.org\n\t[140.211.169.55])\n\tby smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with\n\tESMTP id m8MLrDO5018507\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tMon, 22 Sep 2008 14:57:32 -0700","from localhost.localdomain (localhost [127.0.0.1])\n\tby imap1.linux-foundation.org\n\t(8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id\n\tm8MLqO0X031981; Mon, 22 Sep 2008 14:52:24 -0700"],"Message-Id":"<200809222152.m8MLqO0X031981@imap1.linux-foundation.org>","Subject":"[patch 15/21] forcdeth: increase max_interrupt_work","To":"jeff@garzik.org","Cc":"netdev@vger.kernel.org, akpm@linux-foundation.org,\n\tjoe.korty@ccur.com, aabdulla@nvidia.com","From":"akpm@linux-foundation.org","Date":"Mon, 22 Sep 2008 14:52:24 -0700","X-Spam-Status":"No, hits=-3.359 required=5 tests=AWL, BAYES_00,\n\tOSDL_HEADER_SUBJECT_BRACKETED","X-Spam-Checker-Version":"SpamAssassin 3.2.4-osdl_revision__1.47__","X-MIMEDefang-Filter":"lf$Revision: 1.188 $","X-Scanned-By":"MIMEDefang 2.63 on 140.211.169.13","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Joe Korty <joe.korty@ccur.com>\n\nThis eliminates the following often-generated warning from my 64 bit\nOpteron SMP test stand:\n\n\teth0: too many iterations (6) in nv_nic_irq\n\nAccording to the web, the problem is that the forcedeth driver has a\ntoo-low value for max_interrupt_work.  Grepping the kernel I see that\nforcedeth has the second lowest value of all ethernet drivers (ie, 6). \nMost are in the 20-40 range.  So this patch increases this a bit, from 6\nto 15 (at 15 forcedeth becomes the driver with third-lowest\nmax_interrupt_work value).\n\nMy test stand, which used to print out the above warnings repetitively\nwhenever it was under heavy net load, no longer does so.\n\nSigned-off-by: Joe Korty <joe.korty@ccur.com>\nCc: Ayaz Abdulla <aabdulla@nvidia.com>\nCc: Jeff Garzik <jeff@garzik.org>\nSigned-off-by: Andrew Morton <akpm@linux-foundation.org>\n---\n\n drivers/net/forcedeth.c |    2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff -puN drivers/net/forcedeth.c~forcdeth-increase-max_interrupt_work drivers/net/forcedeth.c\n--- a/drivers/net/forcedeth.c~forcdeth-increase-max_interrupt_work\n+++ a/drivers/net/forcedeth.c\n@@ -818,7 +818,7 @@ struct fe_priv {\n  * Maximum number of loops until we assume that a bit in the irq mask\n  * is stuck. Overridable with module param.\n  */\n-static int max_interrupt_work = 5;\n+static int max_interrupt_work = 15;\n \n /*\n  * Optimization can be either throuput mode or cpu mode\n","prefixes":["15/21"]}