{"id":973,"url":"http://patchwork.ozlabs.org/api/1.0/patches/973/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<200809222150.m8MLofR7031869@imap1.linux-foundation.org>","date":"2008-09-22T21:50:41","name":"[5/8] net/atm/lec.c: drop code after return","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"afa599328e6a54b2cd95dbe5f13bc18b58f3ce09","submitter":{"id":107,"url":"http://patchwork.ozlabs.org/api/1.0/people/107/?format=json","name":"Andrew Morton","email":"akpm@linux-foundation.org"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/200809222150.m8MLofR7031869@imap1.linux-foundation.org/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/973/checks/","tags":{},"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id ECF3BDDE9F\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 07:57:52 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754035AbYIVV5t (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 22 Sep 2008 17:57:49 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1753963AbYIVV5r\n\t(ORCPT <rfc822; netdev-outgoing>); Mon, 22 Sep 2008 17:57:47 -0400","from smtp1.linux-foundation.org ([140.211.169.13]:60607 \"EHLO\n\tsmtp1.linux-foundation.org\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753800AbYIVV5p (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 22 Sep 2008 17:57:45 -0400","from imap1.linux-foundation.org (imap1.linux-foundation.org\n\t[140.211.169.55])\n\tby smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with\n\tESMTP id m8MLrDOD018507\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tMon, 22 Sep 2008 14:57:34 -0700","from localhost.localdomain (localhost [127.0.0.1])\n\tby imap1.linux-foundation.org\n\t(8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id\n\tm8MLofR7031869; Mon, 22 Sep 2008 14:50:41 -0700"],"Message-Id":"<200809222150.m8MLofR7031869@imap1.linux-foundation.org>","Subject":"[patch 5/8] net/atm/lec.c: drop code after return","To":"davem@davemloft.net","Cc":"netdev@vger.kernel.org, akpm@linux-foundation.org, julia@diku.dk,\n\tchas@cmf.nrl.navy.mil, richard.genoud@gmail.com","From":"akpm@linux-foundation.org","Date":"Mon, 22 Sep 2008 14:50:41 -0700","X-Spam-Status":"No, hits=-3.359 required=5 tests=AWL, BAYES_00,\n\tOSDL_HEADER_SUBJECT_BRACKETED","X-Spam-Checker-Version":"SpamAssassin 3.2.4-osdl_revision__1.47__","X-MIMEDefang-Filter":"lf$Revision: 1.188 $","X-Scanned-By":"MIMEDefang 2.63 on 140.211.169.13","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Julia Lawall <julia@diku.dk>\n\nThe break after the return serves no purpose.\n\nSigned-off-by: Julia Lawall <julia@diku.dk>\nReviewed-by: Richard Genoud <richard.genoud@gmail.com>\nCc: Chas Williams <chas@cmf.nrl.navy.mil>\nSigned-off-by: Andrew Morton <akpm@linux-foundation.org>\n---\n\n net/atm/lec.c |    1 -\n 1 file changed, 1 deletion(-)","diff":"diff -puN net/atm/lec.c~net-atm-lecc-drop-code-after-return net/atm/lec.c\n--- a/net/atm/lec.c~net-atm-lecc-drop-code-after-return\n+++ a/net/atm/lec.c\n@@ -1931,7 +1931,6 @@ static struct atm_vcc *lec_arp_resolve(s\n \t\tswitch (priv->lane_version) {\n \t\tcase 1:\n \t\t\treturn priv->mcast_vcc;\n-\t\t\tbreak;\n \t\tcase 2:\t/* LANE2 wants arp for multicast addresses */\n \t\t\tif (!compare_ether_addr(mac_to_find, bus_mac))\n \t\t\t\treturn priv->mcast_vcc;\n","prefixes":["5/8"]}