{"id":971,"url":"http://patchwork.ozlabs.org/api/1.0/patches/971/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<200809222150.m8MLogbY031872@imap1.linux-foundation.org>","date":"2008-09-22T21:50:42","name":"[6/8] drivers/net/wan: Use DIV_ROUND_UP","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"499fbb4c674055eb204f8b7959f031a04d9bd103","submitter":{"id":107,"url":"http://patchwork.ozlabs.org/api/1.0/people/107/?format=json","name":"Andrew Morton","email":"akpm@linux-foundation.org"},"delegate":{"id":36,"url":"http://patchwork.ozlabs.org/api/1.0/users/36/?format=json","username":"jgarzik","first_name":"Jeff","last_name":"Garzik","email":"jgarzik@pobox.com"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/200809222150.m8MLogbY031872@imap1.linux-foundation.org/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/971/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id A0F1ADDE9F\n\tfor ;\n\tTue, 23 Sep 2008 07:57:51 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753972AbYIVV5q (ORCPT );\n\tMon, 22 Sep 2008 17:57:46 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1753963AbYIVV5p\n\t(ORCPT ); Mon, 22 Sep 2008 17:57:45 -0400","from smtp1.linux-foundation.org ([140.211.169.13]:34596 \"EHLO\n\tsmtp1.linux-foundation.org\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753929AbYIVV5n (ORCPT\n\t); Mon, 22 Sep 2008 17:57:43 -0400","from imap1.linux-foundation.org (imap1.linux-foundation.org\n\t[140.211.169.55])\n\tby smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with\n\tESMTP id m8MLrDO3018507\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tMon, 22 Sep 2008 14:57:32 -0700","from localhost.localdomain (localhost [127.0.0.1])\n\tby imap1.linux-foundation.org\n\t(8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id\n\tm8MLogbY031872; Mon, 22 Sep 2008 14:50:42 -0700"],"Message-Id":"<200809222150.m8MLogbY031872@imap1.linux-foundation.org>","Subject":"[patch 6/8] drivers/net/wan: Use DIV_ROUND_UP","To":"davem@davemloft.net","Cc":"netdev@vger.kernel.org, akpm@linux-foundation.org, julia@diku.dk,\n\tchas@cmf.nrl.navy.mil","From":"akpm@linux-foundation.org","Date":"Mon, 22 Sep 2008 14:50:42 -0700","X-Spam-Status":"No, hits=-3.359 required=5 tests=AWL, BAYES_00,\n\tOSDL_HEADER_SUBJECT_BRACKETED","X-Spam-Checker-Version":"SpamAssassin 3.2.4-osdl_revision__1.47__","X-MIMEDefang-Filter":"lf$Revision: 1.188 $","X-Scanned-By":"MIMEDefang 2.63 on 140.211.169.13","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Julia Lawall \n\nThe kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /\n(d)) but is perhaps more readable.\n\nAn extract of the semantic patch that makes this change is as follows:\n(http://www.emn.fr/x-info/coccinelle/)\n\n// \n@haskernel@\n@@\n\n#include \n\n@depends on haskernel@\nexpression n,d;\n@@\n\n(\n- (n + d - 1) / d\n+ DIV_ROUND_UP(n,d)\n|\n- (n + (d - 1)) / d\n+ DIV_ROUND_UP(n,d)\n)\n\n@depends on haskernel@\nexpression n,d;\n@@\n\n- DIV_ROUND_UP((n),d)\n+ DIV_ROUND_UP(n,d)\n\n@depends on haskernel@\nexpression n,d;\n@@\n\n- DIV_ROUND_UP(n,(d))\n+ DIV_ROUND_UP(n,d)\n// \n\nSigned-off-by: Julia Lawall \nCc: Chas Williams \nSigned-off-by: Andrew Morton \n---\n\n drivers/net/wan/sbni.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff -puN drivers/net/wan/sbni.c~drivers-net-wan-use-div_round_up drivers/net/wan/sbni.c\n--- a/drivers/net/wan/sbni.c~drivers-net-wan-use-div_round_up\n+++ a/drivers/net/wan/sbni.c\n@@ -856,7 +856,7 @@ prepare_to_send( struct sk_buff *skb, \n \t\tlen = SBNI_MIN_LEN;\n \n \tnl->tx_buf_p\t= skb;\n-\tnl->tx_frameno\t= (len + nl->maxframe - 1) / nl->maxframe;\n+\tnl->tx_frameno\t= DIV_ROUND_UP(len, nl->maxframe);\n \tnl->framelen\t= len < nl->maxframe ? len : nl->maxframe;\n \n \toutb( inb( dev->base_addr + CSR0 ) | TR_REQ, dev->base_addr + CSR0 );\n","prefixes":["6/8"]}