{"id":963,"url":"http://patchwork.ozlabs.org/api/1.0/patches/963/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<200809222152.m8MLqHXf031966@imap1.linux-foundation.org>","date":"2008-09-22T21:52:17","name":"[10/21] driver/net/skge.c: restart the interface when it's options or pauseparam is set","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"89707ed2dabdad3133d47926b2ecec3b0a5fe076","submitter":{"id":107,"url":"http://patchwork.ozlabs.org/api/1.0/people/107/?format=json","name":"Andrew Morton","email":"akpm@linux-foundation.org"},"delegate":{"id":36,"url":"http://patchwork.ozlabs.org/api/1.0/users/36/?format=json","username":"jgarzik","first_name":"Jeff","last_name":"Garzik","email":"jgarzik@pobox.com"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/200809222152.m8MLqHXf031966@imap1.linux-foundation.org/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/963/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 644BFDDF13\n\tfor ;\n\tTue, 23 Sep 2008 07:54:39 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753404AbYIVVyf (ORCPT );\n\tMon, 22 Sep 2008 17:54:35 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1753347AbYIVVye\n\t(ORCPT ); Mon, 22 Sep 2008 17:54:34 -0400","from smtp1.linux-foundation.org ([140.211.169.13]:48350 \"EHLO\n\tsmtp1.linux-foundation.org\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753283AbYIVVye (ORCPT\n\t); Mon, 22 Sep 2008 17:54:34 -0400","from imap1.linux-foundation.org (imap1.linux-foundation.org\n\t[140.211.169.55])\n\tby smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with\n\tESMTP id m8MLqIh6018360\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tMon, 22 Sep 2008 14:52:19 -0700","from localhost.localdomain (localhost [127.0.0.1])\n\tby imap1.linux-foundation.org\n\t(8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id\n\tm8MLqHXf031966; Mon, 22 Sep 2008 14:52:17 -0700"],"Message-Id":"<200809222152.m8MLqHXf031966@imap1.linux-foundation.org>","Subject":"[patch 10/21] driver/net/skge.c: restart the interface when it's\n\toptions or pauseparam is set","To":"jeff@garzik.org","Cc":"netdev@vger.kernel.org, akpm@linux-foundation.org,\n\tXiaoming.Zhang@resilience.com, shemminger@vyatta.com,\n\txiaoming.zhang@resilience.com","From":"akpm@linux-foundation.org","Date":"Mon, 22 Sep 2008 14:52:17 -0700","X-Spam-Status":"No, hits=-3.359 required=5 tests=AWL, BAYES_00,\n\tOSDL_HEADER_SUBJECT_BRACKETED","X-Spam-Checker-Version":"SpamAssassin 3.2.4-osdl_revision__1.47__","X-MIMEDefang-Filter":"lf$Revision: 1.188 $","X-Scanned-By":"MIMEDefang 2.63 on 140.211.169.13","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: \"Xiaoming.Zhang\" \n\nWe have an issue of the skge driver: The card won't work when it's options\nare changed. Here's the hardware info:\n\n# lspci -v\n05:04.0 Ethernet controller: Marvell Technology Group Ltd. 88E8001 Gigabit Ethernet Controller (rev 13)\n Subsystem: Marvell Technology Group Ltd. Marvell RDK-8001\n Flags: bus master, 66MHz, medium devsel, latency 32, IRQ 16\n Memory at d042c000 (32-bit, non-prefetchable) [size=16K]\n I/O ports at d000 [size=256]\n [virtual] Expansion ROM at 20400000 [disabled] [size=128K]\n Capabilities: [48] Power Management version 2\n Capabilities: [50] Vital Product Data\n\nThe happens in both Linux-2.6.26(skge version 1.23) and RHEL5.2(skge\nversion 1.6).\n\nFor example, at first it is set to \"speed 1000 duplex full auto-neg on\" and\nit works, then run\n\n ethtool -s autoneg off\nor ethtool -s speed 100 duplex full autoneg off\n\nThen it will stop working. After that if we restart the interface:\n\n\tifconifg down\n\tifconfig up\n\nIt will work again. And `ethtool -A' has the same issue.\n\nSo we think after setting the options, the interface should be restarted. \n\nSigned-off-by: Zhang Xiaoming \nCc: Stephen Hemminger \nCc: Jeff Garzik \nSigned-off-by: Andrew Morton \n---\n\n drivers/net/skge.c | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)","diff":"diff -puN drivers/net/skge.c~driver-net-skgec-restart-the-interface-when-its-options-or-pauseparam-is-set drivers/net/skge.c\n--- a/drivers/net/skge.c~driver-net-skgec-restart-the-interface-when-its-options-or-pauseparam-is-set\n+++ a/drivers/net/skge.c\n@@ -353,8 +353,10 @@ static int skge_set_settings(struct net_\n \tskge->autoneg = ecmd->autoneg;\n \tskge->advertising = ecmd->advertising;\n \n-\tif (netif_running(dev))\n-\t\tskge_phy_reset(skge);\n+\tif (netif_running(dev)) {\n+\t\tskge_down(dev);\n+\t\tskge_up(dev);\n+\t}\n \n \treturn (0);\n }\n@@ -595,8 +597,10 @@ static int skge_set_pauseparam(struct ne\n \t\t\tskge->flow_control = FLOW_MODE_NONE;\n \t}\n \n-\tif (netif_running(dev))\n-\t\tskge_phy_reset(skge);\n+\tif (netif_running(dev)) {\n+\t\tskge_down(dev);\n+\t\tskge_up(dev);\n+\t}\n \n \treturn 0;\n }\n","prefixes":["10/21"]}