{"id":853,"url":"http://patchwork.ozlabs.org/api/1.0/patches/853/?format=json","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.0/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20080922195718t-sato@mail.jp.nec.com>","date":"2008-09-22T10:57:18","name":"[6/10] gfs2: Fix error handling in write_super_lockfs/unlockfs","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"fb6db47786aaf3ca29c819b15578160e6652d542","submitter":{"id":391,"url":"http://patchwork.ozlabs.org/api/1.0/people/391/?format=json","name":"Takashi Sato","email":"t-sato@yk.jp.nec.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20080922195718t-sato@mail.jp.nec.com/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/853/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 9E133DDEF2\n\tfor ;\n\tMon, 22 Sep 2008 20:59:21 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753815AbYIVK6q (ORCPT );\n\tMon, 22 Sep 2008 06:58:46 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1753802AbYIVK6p\n\t(ORCPT );\n\tMon, 22 Sep 2008 06:58:45 -0400","from TYO201.gate.nec.co.jp ([202.32.8.193]:37791 \"EHLO\n\ttyo201.gate.nec.co.jp\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753519AbYIVK6n (ORCPT\n\t); Mon, 22 Sep 2008 06:58:43 -0400","from mailgate3.nec.co.jp ([10.7.69.195])\n\tby tyo201.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id m8MAvKql000703;\n\tMon, 22 Sep 2008 19:57:20 +0900 (JST)","(from root@localhost) by mailgate3.nec.co.jp\n\t(8.11.7/3.7W-MAILGATE-NEC)\n\tid m8MAvJA01985; Mon, 22 Sep 2008 19:57:19 +0900 (JST)","from shoin.jp.nec.com (shoin.jp.nec.com [10.26.220.3])\n\tby mailsv.nec.co.jp (8.13.8/8.13.4) with ESMTP id m8MAvJBN011229;\n\tMon, 22 Sep 2008 19:57:19 +0900 (JST)","from TNESB07336 ([10.64.168.65] [10.64.168.65]) by mail.jp.nec.com\n\twith ESMTP; Mon, 22 Sep 2008 19:57:19 +0900"],"To":"Andrew Morton ,\n\tChristoph Hellwig ,\n\t\"linux-fsdevel@vger.kernel.org\" ,\n\t\"dm-devel@redhat.com\" ,\n\t\"viro@ZenIV.linux.org.uk\" ,\n\t\"linux-ext4@vger.kernel.org\" ,\n\t\"xfs@oss.sgi.com\" , \"axboe@kernel.dk\" ,\n\t\"mtk.manpages@googlemail.com\" ","Cc":"\"linux-kernel@vger.kernel.org\" ","Subject":"[PATCH 6/10] gfs2: Fix error handling in write_super_lockfs/unlockfs","Message-Id":"<20080922195718t-sato@mail.jp.nec.com>","Mime-Version":"1.0","X-Mailer":"WeMail32[2.51] ID:1K0086","From":"Takashi Sato ","Date":"Mon, 22 Sep 2008 19:57:18 +0900","Content-Type":"text/plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"},"content":"I've changed write_super_lockfs/unlockfs so that they always return\n0 (success) to keep a current behavior.\n\nSigned-off-by: Takashi Sato \nSigned-off-by: Masayuki Hamaguchi \n---\n ops_super.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-ext4\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","diff":"diff -uprN -X linux-2.6.27-rc7-lockfs-ext4/Documentation/dontdiff linux-2.6.27-rc7-lockfs-ext4/fs/gfs2/ops_super.c linux\n-2.6.27-rc7-lockfs-gfs2/fs/gfs2/ops_super.c\n--- linux-2.6.27-rc7-lockfs-ext4/fs/gfs2/ops_super.c\t2008-09-22 07:29:55.000000000 +0900\n+++ linux-2.6.27-rc7-lockfs-gfs2/fs/gfs2/ops_super.c\t2008-09-22 10:52:16.000000000 +0900\n@@ -166,13 +166,13 @@ static int gfs2_sync_fs(struct super_blo\n *\n */\n \n-static void gfs2_write_super_lockfs(struct super_block *sb)\n+static int gfs2_write_super_lockfs(struct super_block *sb)\n {\n \tstruct gfs2_sbd *sdp = sb->s_fs_info;\n \tint error;\n \n \tif (test_bit(SDF_SHUTDOWN, &sdp->sd_flags))\n-\t\treturn;\n+\t\treturn 0;\n \n \tfor (;;) {\n \t\terror = gfs2_freeze_fs(sdp);\n@@ -192,6 +192,7 @@ static void gfs2_write_super_lockfs(stru\n \t\tfs_err(sdp, \"retrying...\\n\");\n \t\tmsleep(1000);\n \t}\n+\treturn 0;\n }\n \n /**\n@@ -200,9 +201,10 @@ static void gfs2_write_super_lockfs(stru\n *\n */\n \n-static void gfs2_unlockfs(struct super_block *sb)\n+static int gfs2_unlockfs(struct super_block *sb)\n {\n \tgfs2_unfreeze_fs(sb->s_fs_info);\n+\treturn 0;\n }\n \n /**\n","prefixes":["6/10"]}