{"id":841,"url":"http://patchwork.ozlabs.org/api/1.0/patches/841/?format=json","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.0/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20080922195526t-sato@mail.jp.nec.com>","date":"2008-09-22T10:55:26","name":"[1/10] VFS: Fix error handling of write_super_lockfs/unlockfs","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"cc000158a6b991c1e1d11e2c9f8d792c4fa236c9","submitter":{"id":391,"url":"http://patchwork.ozlabs.org/api/1.0/people/391/?format=json","name":"Takashi Sato","email":"t-sato@yk.jp.nec.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20080922195526t-sato@mail.jp.nec.com/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/841/checks/","tags":{},"headers":{"Return-Path":"<linux-ext4-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 6025DDDF80\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 22 Sep 2008 20:56:48 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752755AbYIVK4g (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 22 Sep 2008 06:56:36 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1752645AbYIVK4g\n\t(ORCPT <rfc822;linux-ext4-outgoing>);\n\tMon, 22 Sep 2008 06:56:36 -0400","from TYO201.gate.nec.co.jp ([202.32.8.193]:36798 \"EHLO\n\ttyo201.gate.nec.co.jp\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751841AbYIVK4e (ORCPT\n\t<rfc822; linux-ext4@vger.kernel.org>); Mon, 22 Sep 2008 06:56:34 -0400","from mailgate3.nec.co.jp ([10.7.69.162])\n\tby tyo201.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id m8MAtS7N028320;\n\tMon, 22 Sep 2008 19:55:28 +0900 (JST)","(from root@localhost) by mailgate3.nec.co.jp\n\t(8.11.7/3.7W-MAILGATE-NEC)\n\tid m8MAtSE12742; Mon, 22 Sep 2008 19:55:28 +0900 (JST)","from matabe.jp.nec.com (matabe.jp.nec.com [10.26.220.20])\n\tby mailsv4.nec.co.jp (8.13.8/8.13.4) with ESMTP id m8MAtRLY025009;\n\tMon, 22 Sep 2008 19:55:27 +0900 (JST)","from TNESB07336 ([10.64.168.65] [10.64.168.65]) by mail.jp.nec.com\n\twith ESMTP; Mon, 22 Sep 2008 19:55:26 +0900"],"To":"Andrew Morton <akpm@linux-foundation.org>,\n\tChristoph Hellwig <hch@infradead.org>,\n\t\"linux-fsdevel@vger.kernel.org\" <linux-fsdevel@vger.kernel.org>,\n\t\"dm-devel@redhat.com\" <dm-devel@redhat.com>,\n\t\"viro@ZenIV.linux.org.uk\" <viro@ZenIV.linux.org.uk>,\n\t\"linux-ext4@vger.kernel.org\" <linux-ext4@vger.kernel.org>,\n\t\"xfs@oss.sgi.com\" <xfs@oss.sgi.com>, \"axboe@kernel.dk\" <axboe@kernel.dk>,\n\t\"mtk.manpages@googlemail.com\" <mtk.manpages@googlemail.com>","Cc":"\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>","Subject":"[PATCH 1/10] VFS: Fix error handling of write_super_lockfs/unlockfs","Message-Id":"<20080922195526t-sato@mail.jp.nec.com>","Mime-Version":"1.0","X-Mailer":"WeMail32[2.51] ID:1K0086","From":"Takashi Sato <t-sato@yk.jp.nec.com>","Date":"Mon, 22 Sep 2008 19:55:26 +0900","Content-Type":"text/plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-ext4.vger.kernel.org>","X-Mailing-List":"linux-ext4@vger.kernel.org"},"content":"I've changed the type of write_super_lockfs and unlockfs from \"void\" to\n\"int\" so that they can return an error. \n\nSigned-off-by: Takashi Sato <t-sato@yk.jp.nec.com>\nSigned-off-by: Masayuki Hamaguchi <m-hamaguchi@ys.jp.nec.com>\n---\n Documentation/filesystems/Locking |    4 ++--\n Documentation/filesystems/vfs.txt |    4 ++--\n include/linux/fs.h                |    4 ++--\n 3 files changed, 6 insertions(+), 6 deletions(-)\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-ext4\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","diff":"diff -uprN -X linux-2.6.27-rc7.org/Documentation/dontdiff linux-2.6.27-rc7.org/Documentation/filesystems/Locking linux-2\n.6.27-rc7-lockfs/Documentation/filesystems/Locking\n--- linux-2.6.27-rc7.org/Documentation/filesystems/Locking\t2008-09-22 07:29:55.000000000 +0900\n+++ linux-2.6.27-rc7-lockfs/Documentation/filesystems/Locking\t2008-09-22 09:53:22.000000000 +0900\n@@ -97,8 +97,8 @@ prototypes:\n \tvoid (*put_super) (struct super_block *);\n \tvoid (*write_super) (struct super_block *);\n \tint (*sync_fs)(struct super_block *sb, int wait);\n-\tvoid (*write_super_lockfs) (struct super_block *);\n-\tvoid (*unlockfs) (struct super_block *);\n+\tint (*write_super_lockfs) (struct super_block *);\n+\tint (*unlockfs) (struct super_block *);\n \tint (*statfs) (struct dentry *, struct kstatfs *);\n \tint (*remount_fs) (struct super_block *, int *, char *);\n \tvoid (*clear_inode) (struct inode *);\ndiff -uprN -X linux-2.6.27-rc7.org/Documentation/dontdiff linux-2.6.27-rc7.org/Documentation/filesystems/vfs.txt linux-2\n.6.27-rc7-lockfs/Documentation/filesystems/vfs.txt\n--- linux-2.6.27-rc7.org/Documentation/filesystems/vfs.txt\t2008-09-22 07:29:55.000000000 +0900\n+++ linux-2.6.27-rc7-lockfs/Documentation/filesystems/vfs.txt\t2008-09-22 09:53:22.000000000 +0900\n@@ -210,8 +210,8 @@ struct super_operations {\n         void (*put_super) (struct super_block *);\n         void (*write_super) (struct super_block *);\n         int (*sync_fs)(struct super_block *sb, int wait);\n-        void (*write_super_lockfs) (struct super_block *);\n-        void (*unlockfs) (struct super_block *);\n+        int (*write_super_lockfs) (struct super_block *);\n+        int (*unlockfs) (struct super_block *);\n         int (*statfs) (struct dentry *, struct kstatfs *);\n         int (*remount_fs) (struct super_block *, int *, char *);\n         void (*clear_inode) (struct inode *);\ndiff -uprN -X linux-2.6.27-rc7.org/Documentation/dontdiff linux-2.6.27-rc7.org/include/linux/fs.h linux-2.6.27-rc7-lockf\ns/include/linux/fs.h\n--- linux-2.6.27-rc7.org/include/linux/fs.h\t2008-09-22 07:29:55.000000000 +0900\n+++ linux-2.6.27-rc7-lockfs/include/linux/fs.h\t2008-09-22 09:53:46.000000000 +0900\n@@ -1314,8 +1314,8 @@ struct super_operations {\n \tvoid (*put_super) (struct super_block *);\n \tvoid (*write_super) (struct super_block *);\n \tint (*sync_fs)(struct super_block *sb, int wait);\n-\tvoid (*write_super_lockfs) (struct super_block *);\n-\tvoid (*unlockfs) (struct super_block *);\n+\tint (*write_super_lockfs) (struct super_block *);\n+\tint (*unlockfs) (struct super_block *);\n \tint (*statfs) (struct dentry *, struct kstatfs *);\n \tint (*remount_fs) (struct super_block *, int *, char *);\n \tvoid (*clear_inode) (struct inode *);\n","prefixes":["1/10"]}