{"id":809827,"url":"http://patchwork.ozlabs.org/api/1.0/patches/809827/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1504555943-12893-14-git-send-email-pantelis.antoniou@konsulko.com>","date":"2017-09-04T20:12:22","name":"[U-Boot,v3,13/14] ut: fix fdt_getprop_u32() change","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"47abae4aa5561cbf8cac4317be9aa6d2d6f16457","submitter":{"id":64098,"url":"http://patchwork.ozlabs.org/api/1.0/people/64098/?format=json","name":"Pantelis Antoniou","email":"pantelis.antoniou@konsulko.com"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/1.0/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1504555943-12893-14-git-send-email-pantelis.antoniou@konsulko.com/mbox/","series":[{"id":1453,"url":"http://patchwork.ozlabs.org/api/1.0/series/1453/?format=json","date":"2017-09-04T20:12:09","name":"uboot overlays, FIT image & unittest","version":3,"mbox":"http://patchwork.ozlabs.org/series/1453/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809827/checks/","tags":{},"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"PGrgWpuk\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmLjr5wVHz9t2R\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  5 Sep 2017 06:17:20 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 849FBC21E52; Mon,  4 Sep 2017 20:15:56 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id C2CD0C21F29;\n\tMon,  4 Sep 2017 20:15:03 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 78A79C21F65; Mon,  4 Sep 2017 20:13:19 +0000 (UTC)","from mail-wm0-f47.google.com (mail-wm0-f47.google.com\n\t[74.125.82.47])\n\tby lists.denx.de (Postfix) with ESMTPS id B0715C21F49\n\tfor <u-boot@lists.denx.de>; Mon,  4 Sep 2017 20:13:15 +0000 (UTC)","by mail-wm0-f47.google.com with SMTP id v2so10140886wmf.0\n\tfor <u-boot@lists.denx.de>; Mon, 04 Sep 2017 13:13:15 -0700 (PDT)","from localhost.localdomain ([195.97.110.117])\n\tby smtp.gmail.com with ESMTPSA id\n\tu8sm3720435wrc.92.2017.09.04.13.13.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 04 Sep 2017 13:13:14 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=xMaf5W9z64A3BFJPJxWqTCqrzLsdYru8oIdZWrxaLvM=;\n\tb=PGrgWpukFyXh/RQazaD6ymLoNG0PkxBA4he50nJ4bh+HS67LAlus0cHGKPtgVwN0bN\n\tg6NrH7abOgWGuIQi2DwIZV1oI8lI72KFD7zEz+TMbs3ZBxneKn4V6eBEDJDuHc6TLCSV\n\ttVy5fcyUkCzf3+QwryvXDtfEBg0vlYgr0x3+Q=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=xMaf5W9z64A3BFJPJxWqTCqrzLsdYru8oIdZWrxaLvM=;\n\tb=AwRMZX1CjqbQZvluh7OJhljhqyJsYMKUayPVGjwSXH7JiD010ccAd1Kk2aNKxDcWyn\n\t7yQWlcX2LR+exJsaoU5Bk8G9b+y4FB/2JrXorrLeZ3WBMY7kMkyj31LPJ3ODrR81LyIu\n\tVh3677NNKx8CdRM6387Pqib06or2motC52v+aEk/GCQxC/8GVGRuuY7RfbSodZhHsNJd\n\trOKVl/jJycYHfR0pbUarL5VXlxTnngS5/1yiYcYyreu69b3toopLhC5fv/m07CTbQfA7\n\tPYIH3tuY3IiEhCyWblxqsS+aRR5DmTmLQIvSExtWul2BxCyI3PFRYSGlRz4wACCO0ZMY\n\ttlzQ==","X-Gm-Message-State":"AHPjjUjXWg/kNdKHyN/HLZCfSwlPVXeEdDh67MVYmWu9TBFRZ9dQyy+4\n\tvffEySdtQaZybCzr","X-Google-Smtp-Source":"ADKCNb5Bc4kGXFq8oHuZzvmU4PilENcvjczSTlf2odlHzzx2s6rJlMHiXpCD+DACdBjGADR1xJYVjQ==","X-Received":"by 10.28.63.139 with SMTP id m133mr831329wma.140.1504555995403; \n\tMon, 04 Sep 2017 13:13:15 -0700 (PDT)","From":"Pantelis Antoniou <pantelis.antoniou@konsulko.com>","To":"Tom Rini <trini@konsulko.com>","Date":"Mon,  4 Sep 2017 23:12:22 +0300","Message-Id":"<1504555943-12893-14-git-send-email-pantelis.antoniou@konsulko.com>","X-Mailer":"git-send-email 2.1.4","In-Reply-To":"<1504555943-12893-1-git-send-email-pantelis.antoniou@konsulko.com>","References":"<1504555943-12893-1-git-send-email-pantelis.antoniou@konsulko.com>","Cc":"Marek Vasut <marex@denx.de>,\n\tPantelis Antoniou <pantelis.antoniou@konsulko.com>,\n\tTero Kristo <t-kristo@ti.com>, u-boot@lists.denx.de,\n\tMaxime Ripard <maxime.ripard@free-electrons.com>,\n\tStefan Roese <sr@denx.de>, Alan Ott <alan@signal11.us>","Subject":"[U-Boot] [PATCH v3 13/14] ut: fix fdt_getprop_u32() change","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"},"content":"fdt_getprop_u32 is not exported and it's different than what the\nunit test uses. Rename u32 prop access methods to something that's\nunit test specific.\n\nSigned-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>\n---\n test/overlay/cmd_ut_overlay.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)","diff":"diff --git a/test/overlay/cmd_ut_overlay.c b/test/overlay/cmd_ut_overlay.c\nindex cbef720..7106f42 100644\n--- a/test/overlay/cmd_ut_overlay.c\n+++ b/test/overlay/cmd_ut_overlay.c\n@@ -21,7 +21,7 @@\n extern u32 __dtb_test_fdt_base_begin;\n extern u32 __dtb_test_fdt_overlay_begin;\n \n-static int fdt_getprop_u32_by_index(void *fdt, const char *path,\n+static int ut_fdt_getprop_u32_by_index(void *fdt, const char *path,\n \t\t\t\t    const char *name, int index,\n \t\t\t\t    u32 *out)\n {\n@@ -42,10 +42,10 @@ static int fdt_getprop_u32_by_index(void *fdt, const char *path,\n \treturn 0;\n }\n \n-static int fdt_getprop_u32(void *fdt, const char *path, const char *name,\n+static int ut_fdt_getprop_u32(void *fdt, const char *path, const char *name,\n \t\t\t   u32 *out)\n {\n-\treturn fdt_getprop_u32_by_index(fdt, path, name, 0, out);\n+\treturn ut_fdt_getprop_u32_by_index(fdt, path, name, 0, out);\n }\n \n static int fdt_getprop_str(void *fdt, const char *path, const char *name,\n@@ -68,7 +68,7 @@ static int fdt_overlay_change_int_property(struct unit_test_state *uts)\n \tvoid *fdt = uts->priv;\n \tu32 val = 0;\n \n-\tut_assertok(fdt_getprop_u32(fdt, \"/test-node\", \"test-int-property\",\n+\tut_assertok(ut_fdt_getprop_u32(fdt, \"/test-node\", \"test-int-property\",\n \t\t\t\t    &val));\n \tut_asserteq(43, val);\n \n@@ -158,11 +158,11 @@ static int fdt_overlay_local_phandle(struct unit_test_state *uts)\n \tlocal_phandle = fdt_get_phandle(fdt, off);\n \tut_assert(local_phandle);\n \n-\tut_assertok(fdt_getprop_u32_by_index(fdt, \"/\", \"test-several-phandle\",\n+\tut_assertok(ut_fdt_getprop_u32_by_index(fdt, \"/\", \"test-several-phandle\",\n \t\t\t\t\t     0, &val));\n \tut_asserteq(local_phandle, val);\n \n-\tut_assertok(fdt_getprop_u32_by_index(fdt, \"/\", \"test-several-phandle\",\n+\tut_assertok(ut_fdt_getprop_u32_by_index(fdt, \"/\", \"test-several-phandle\",\n \t\t\t\t\t     1, &val));\n \tut_asserteq(local_phandle, val);\n \n@@ -189,11 +189,11 @@ static int fdt_overlay_local_phandles(struct unit_test_state *uts)\n \ttest_phandle = fdt_get_phandle(fdt, off);\n \tut_assert(test_phandle);\n \n-\tut_assertok(fdt_getprop_u32_by_index(fdt, \"/\", \"test-phandle\", 0,\n+\tut_assertok(ut_fdt_getprop_u32_by_index(fdt, \"/\", \"test-phandle\", 0,\n \t\t\t\t\t     &val));\n \tut_asserteq(test_phandle, val);\n \n-\tut_assertok(fdt_getprop_u32_by_index(fdt, \"/\", \"test-phandle\", 1,\n+\tut_assertok(ut_fdt_getprop_u32_by_index(fdt, \"/\", \"test-phandle\", 1,\n \t\t\t\t\t     &val));\n \tut_asserteq(local_phandle, val);\n \n","prefixes":["U-Boot","v3","13/14"]}