{"id":809750,"url":"http://patchwork.ozlabs.org/api/1.0/patches/809750/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170904154316.4148-18-david@redhat.com>","date":"2017-09-04T15:43:14","name":"[v2,17/19] s390x: CPU hot unplug via device_del cannot work","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4c230e49cfc50766f6f94cfc04e05ed30e83bd06","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/1.0/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170904154316.4148-18-david@redhat.com/mbox/","series":[{"id":1412,"url":"http://patchwork.ozlabs.org/api/1.0/series/1412/?format=json","date":"2017-09-04T15:42:57","name":"s390x cleanups and CPU hotplug via device_add","version":2,"mbox":"http://patchwork.ozlabs.org/series/1412/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809750/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmF004SgYz9sNq\n\tfor ;\n\tTue, 5 Sep 2017 01:59:12 +1000 (AEST)","from localhost ([::1]:54557 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dotmI-0007ti-EH\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 11:59:10 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37908)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dotXq-0004qo-Jt\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:44:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dotXm-0001OX-4R\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:44:14 -0400","from mx1.redhat.com ([209.132.183.28]:64372)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dotXl-0001OB-VV\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:44:10 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0464170D9D;\n\tMon, 4 Sep 2017 15:44:09 +0000 (UTC)","from t460s.redhat.com (ovpn-116-139.ams2.redhat.com\n\t[10.36.116.139])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D090611CC32;\n\tMon, 4 Sep 2017 15:44:06 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0464170D9D","From":"David Hildenbrand ","To":"qemu-devel@nongnu.org","Date":"Mon, 4 Sep 2017 17:43:14 +0200","Message-Id":"<20170904154316.4148-18-david@redhat.com>","In-Reply-To":"<20170904154316.4148-1-david@redhat.com>","References":"<20170904154316.4148-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tMon, 04 Sep 2017 15:44:09 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via device_del\n\tcannot work","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Eduardo Habkost , david@redhat.com,\n\tcohuck@redhat.com, Richard Henderson , \n\tAlexander Graf , borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"device_del on a CPU will currently do nothing. Let's emmit an error\ntelling that this is will never work (there is no architecture support\non s390x). Error message copied from ppc.\n\n(qemu) device_del cpu1\ndevice_del cpu1\nCPU hot unplug not supported on this machine\n\nSigned-off-by: David Hildenbrand \n---\n hw/s390x/s390-virtio-ccw.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\nindex 22a8a1b45d..dd149567bb 100644\n--- a/hw/s390x/s390-virtio-ccw.c\n+++ b/hw/s390x/s390-virtio-ccw.c\n@@ -338,6 +338,15 @@ static void s390_machine_device_plug(HotplugHandler *hotplug_dev,\n }\n }\n \n+static void s390_machine_device_unplug_request(HotplugHandler *hotplug_dev,\n+ DeviceState *dev, Error **errp)\n+{\n+ if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {\n+ error_setg(errp, \"CPU hot unplug not supported on this machine\");\n+ return;\n+ }\n+}\n+\n static HotplugHandler *s390_get_hotplug_handler(MachineState *machine,\n DeviceState *dev)\n {\n@@ -387,6 +396,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)\n mc->max_cpus = 248;\n mc->get_hotplug_handler = s390_get_hotplug_handler;\n hc->plug = s390_machine_device_plug;\n+ hc->unplug_request = s390_machine_device_unplug_request;\n nc->nmi_monitor_handler = s390_nmi;\n }\n \n","prefixes":["v2","17/19"]}