{"id":809743,"url":"http://patchwork.ozlabs.org/api/1.0/patches/809743/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170904154316.4148-11-david@redhat.com>","date":"2017-09-04T15:43:07","name":"[v2,10/19] target/s390x: use program_interrupt() in per_check_exception()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d4abe86ea191fbd50d0262918cb4ea450673bdbb","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/1.0/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170904154316.4148-11-david@redhat.com/mbox/","series":[{"id":1412,"url":"http://patchwork.ozlabs.org/api/1.0/series/1412/?format=json","date":"2017-09-04T15:42:57","name":"s390x cleanups and CPU hotplug via device_add","version":2,"mbox":"http://patchwork.ozlabs.org/series/1412/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809743/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmDsx4JCRz9sNq\n\tfor ;\n\tTue, 5 Sep 2017 01:53:57 +1000 (AEST)","from localhost ([::1]:54536 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dothD-00042O-GI\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 11:53:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37687)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dotXU-0004a2-LF\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:43:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dotXQ-00014b-31\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:43:52 -0400","from mx1.redhat.com ([209.132.183.28]:51344)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dotXP-00013z-TJ\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:43:48 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id ED38378EC6;\n\tMon, 4 Sep 2017 15:43:46 +0000 (UTC)","from t460s.redhat.com (ovpn-116-139.ams2.redhat.com\n\t[10.36.116.139])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E262FBF672;\n\tMon, 4 Sep 2017 15:43:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com ED38378EC6","From":"David Hildenbrand ","To":"qemu-devel@nongnu.org","Date":"Mon, 4 Sep 2017 17:43:07 +0200","Message-Id":"<20170904154316.4148-11-david@redhat.com>","In-Reply-To":"<20170904154316.4148-1-david@redhat.com>","References":"<20170904154316.4148-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tMon, 04 Sep 2017 15:43:47 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v2 10/19] target/s390x: use program_interrupt()\n\tin per_check_exception()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Eduardo Habkost , david@redhat.com,\n\tcohuck@redhat.com, Richard Henderson , \n\tAlexander Graf , borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Clean it up by reusing program_interrupt(). Add a concern regarding\nilen.\n\nSigned-off-by: David Hildenbrand \n---\n target/s390x/misc_helper.c | 15 +++++++++------\n 1 file changed, 9 insertions(+), 6 deletions(-)","diff":"diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c\nindex 57c02ddf1b..5096286157 100644\n--- a/target/s390x/misc_helper.c\n+++ b/target/s390x/misc_helper.c\n@@ -446,14 +446,17 @@ void HELPER(chsc)(CPUS390XState *env, uint64_t inst)\n #ifndef CONFIG_USER_ONLY\n void HELPER(per_check_exception)(CPUS390XState *env)\n {\n- CPUState *cs = CPU(s390_env_get_cpu(env));\n+ uint32_t ilen;\n \n if (env->per_perc_atmid) {\n- env->int_pgm_code = PGM_PER;\n- env->int_pgm_ilen = get_ilen(cpu_ldub_code(env, env->per_address));\n-\n- cs->exception_index = EXCP_PGM;\n- cpu_loop_exit(cs);\n+ /*\n+ * FIXME: ILEN_AUTO is most probably the right thing to use. ilen\n+ * always has to match the instruction referenced in the PSW. E.g.\n+ * if a PER interrupt is triggered via EXECUTE, we have to use ilen\n+ * of EXECUTE, while per_address contains the target of EXECUTE.\n+ */\n+ ilen = get_ilen(cpu_ldub_code(env, env->per_address));\n+ program_interrupt(env, PGM_PER, ilen);\n }\n }\n \n","prefixes":["v2","10/19"]}