{"id":809521,"url":"http://patchwork.ozlabs.org/api/1.0/patches/809521/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1504505688-32455-3-git-send-email-zhangchen.fnst@cn.fujitsu.com>","date":"2017-09-04T06:14:47","name":"[V5,2/3] net/colo-compare.c: Adjust net queue pop order for performance","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"47d3db2b0a8f000fb0e8fed4cf25317cae4682b7","submitter":{"id":67759,"url":"http://patchwork.ozlabs.org/api/1.0/people/67759/?format=json","name":"Zhang Chen","email":"zhangchen.fnst@cn.fujitsu.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504505688-32455-3-git-send-email-zhangchen.fnst@cn.fujitsu.com/mbox/","series":[{"id":1310,"url":"http://patchwork.ozlabs.org/api/1.0/series/1310/?format=json","date":"2017-09-04T06:14:45","name":"Optimize COLO-compare performance","version":5,"mbox":"http://patchwork.ozlabs.org/series/1310/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809521/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm00k4gTLz9s7c\n\tfor ;\n\tMon, 4 Sep 2017 16:13:56 +1000 (AEST)","from localhost ([::1]:34986 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dokdt-0005Wi-0E\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 02:13:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37324)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dokdM-0005Vi-Ru\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 02:13:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dokdJ-0002jl-Qo\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 02:13:20 -0400","from mail.cn.fujitsu.com ([183.91.158.132]:18989\n\thelo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dokdJ-0002hR-G5\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 02:13:17 -0400","from localhost (HELO cn.fujitsu.com) ([10.167.33.5])\n\tby heian.cn.fujitsu.com with ESMTP; 04 Sep 2017 14:13:13 +0800","from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83])\n\tby cn.fujitsu.com (Postfix) with ESMTP id 8D1174725543;\n\tMon, 4 Sep 2017 14:13:08 +0800 (CST)","from localhost.localdomain (10.167.226.56) by\n\tG08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP\n\tServer (TLS) id 14.3.361.1; Mon, 4 Sep 2017 14:13:13 +0800"],"X-IronPort-AV":"E=Sophos;i=\"5.41,473,1498492800\"; d=\"scan'208\";a=\"25177677\"","From":"Zhang Chen ","To":"qemu devel , Jason Wang ","Date":"Mon, 4 Sep 2017 14:14:47 +0800","Message-ID":"<1504505688-32455-3-git-send-email-zhangchen.fnst@cn.fujitsu.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1504505688-32455-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>","References":"<1504505688-32455-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-Originating-IP":"[10.167.226.56]","X-yoursite-MailScanner-ID":"8D1174725543.A9013","X-yoursite-MailScanner":"Found to be clean","X-yoursite-MailScanner-From":"zhangchen.fnst@cn.fujitsu.com","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"183.91.158.132","Subject":"[Qemu-devel] [PATCH V5 2/3] net/colo-compare.c: Adjust net queue\n\tpop order for performance","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Li Zhijian ,\n\tZhang Chen ,\n\tZhang Chen ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"The packet_enqueue() use g_queue_push_tail() to\nenqueue net packet, so it is more efficent way use\ng_queue_pop_head() to get packet for compare.\nThat will improve the success rate of comparison.\nIn my test the performance of ftp put 1000M file\nwill increase 10%\n\nSigned-off-by: Zhang Chen \n---\n net/colo-compare.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/net/colo-compare.c b/net/colo-compare.c\nindex 18a9ebf..8dd76e4 100644\n--- a/net/colo-compare.c\n+++ b/net/colo-compare.c\n@@ -484,7 +484,7 @@ static void colo_compare_connection(void *opaque, void *user_data)\n \n while (!g_queue_is_empty(&conn->primary_list) &&\n !g_queue_is_empty(&conn->secondary_list)) {\n- pkt = g_queue_pop_tail(&conn->primary_list);\n+ pkt = g_queue_pop_head(&conn->primary_list);\n switch (conn->ip_proto) {\n case IPPROTO_TCP:\n result = g_queue_find_custom(&conn->secondary_list,\n@@ -522,7 +522,7 @@ static void colo_compare_connection(void *opaque, void *user_data)\n * until next comparison.\n */\n trace_colo_compare_main(\"packet different\");\n- g_queue_push_tail(&conn->primary_list, pkt);\n+ g_queue_push_head(&conn->primary_list, pkt);\n /* TODO: colo_notify_checkpoint();*/\n break;\n }\n","prefixes":["V5","2/3"]}