{"id":809221,"url":"http://patchwork.ozlabs.org/api/1.0/patches/809221/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1504416646-9527-4-git-send-email-subashab@codeaurora.org>","date":"2017-09-03T05:30:43","name":"[net-next,3/6] net: qualcomm: rmnet: Move the device creation log","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"b53d0db1960d018214779241fdc8eb64f6a9f850","submitter":{"id":65547,"url":"http://patchwork.ozlabs.org/api/1.0/people/65547/?format=json","name":"Subash Abhinov Kasiviswanathan","email":"subashab@codeaurora.org"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1504416646-9527-4-git-send-email-subashab@codeaurora.org/mbox/","series":[{"id":1198,"url":"http://patchwork.ozlabs.org/api/1.0/series/1198/?format=json","date":"2017-09-03T05:30:40","name":"net: qualcomm: rmnet: Fix comments on initial patchset","version":1,"mbox":"http://patchwork.ozlabs.org/series/1198/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809221/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"Spf0CXtW\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"Spf0CXtW\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=subashab@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlM6t6zzcz9sPk\n\tfor ;\n\tSun, 3 Sep 2017 15:32:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751466AbdICFb5 (ORCPT );\n\tSun, 3 Sep 2017 01:31:57 -0400","from smtp.codeaurora.org ([198.145.29.96]:42702 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751159AbdICFby (ORCPT\n\t); Sun, 3 Sep 2017 01:31:54 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid E7C82609FF; Sun, 3 Sep 2017 05:31:53 +0000 (UTC)","from subashab-lnx.qualcomm.com (unknown [129.46.15.92])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: subashab@codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id 1B5FD60996;\n\tSun, 3 Sep 2017 05:31:53 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504416713;\n\tbh=Ltn8hB/h4d21h1k6w2+C+C4jI5kEnE/4cMpilQDnk4U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Spf0CXtWDYqAVwDXmlZAJbvRXFgqyoReEwYU8l4Ljgj86PtZUK+zAhAh7ubkd4sx5\n\txoW+5UBpN/exAySohTZIGBFpz5k2+ZFQDf5UzdgieKaBvsCbmaMHeYD4UT1N6Y3KFT\n\tLNliMyDcduIz0JeD2N39iJjH/DJYaveDBkyoBkHk=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504416713;\n\tbh=Ltn8hB/h4d21h1k6w2+C+C4jI5kEnE/4cMpilQDnk4U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Spf0CXtWDYqAVwDXmlZAJbvRXFgqyoReEwYU8l4Ljgj86PtZUK+zAhAh7ubkd4sx5\n\txoW+5UBpN/exAySohTZIGBFpz5k2+ZFQDf5UzdgieKaBvsCbmaMHeYD4UT1N6Y3KFT\n\tLNliMyDcduIz0JeD2N39iJjH/DJYaveDBkyoBkHk="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1B5FD60996","From":"Subash Abhinov Kasiviswanathan ","To":"netdev@vger.kernel.org, davem@davemloft.net","Cc":"Subash Abhinov Kasiviswanathan ","Subject":"[PATCH net-next 3/6] net: qualcomm: rmnet: Move the device creation\n\tlog","Date":"Sat, 2 Sep 2017 23:30:43 -0600","Message-Id":"<1504416646-9527-4-git-send-email-subashab@codeaurora.org>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1504416646-9527-1-git-send-email-subashab@codeaurora.org>","References":"<1504416646-9527-1-git-send-email-subashab@codeaurora.org>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"The current log is not very useful as it does not log the device\nname since it it is prior to registration -\n\n(unnamed net_device) (uninitialized): Setting up device\n\nModify to log after the device registration -\n\nrmnet1: rmnet dev created\n\nSigned-off-by: Subash Abhinov Kasiviswanathan \n---\n drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c\nindex 0e0001b..7c73052 100644\n--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c\n+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c\n@@ -73,8 +73,6 @@ static int rmnet_vnd_change_mtu(struct net_device *rmnet_dev, int new_mtu)\n */\n void rmnet_vnd_setup(struct net_device *rmnet_dev)\n {\n-\tnetdev_dbg(rmnet_dev, \"Setting up device %s\\n\", rmnet_dev->name);\n-\n \trmnet_dev->netdev_ops = &rmnet_vnd_ops;\n \trmnet_dev->mtu = RMNET_DFLT_PACKET_SIZE;\n \trmnet_dev->needed_headroom = RMNET_NEEDED_HEADROOM;\n@@ -105,6 +103,7 @@ int rmnet_vnd_newlink(u8 id, struct net_device *rmnet_dev,\n \t\tr->rmnet_devices[id] = rmnet_dev;\n \t\tr->nr_rmnet_devs++;\n \t\trmnet_dev->rtnl_link_ops = &rmnet_link_ops;\n+\t\tnetdev_dbg(rmnet_dev, \"rmnet dev created\\n\");\n \t}\n \n \treturn rc;\n","prefixes":["net-next","3/6"]}