{"id":809220,"url":"http://patchwork.ozlabs.org/api/1.0/patches/809220/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1504416646-9527-3-git-send-email-subashab@codeaurora.org>","date":"2017-09-03T05:30:42","name":"[net-next,2/6] net: qualcomm: rmnet: Remove the unused endpoint -1","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"60338bdcadc743ce0459993f4932ebdb62c8c6b2","submitter":{"id":65547,"url":"http://patchwork.ozlabs.org/api/1.0/people/65547/?format=json","name":"Subash Abhinov Kasiviswanathan","email":"subashab@codeaurora.org"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1504416646-9527-3-git-send-email-subashab@codeaurora.org/mbox/","series":[{"id":1198,"url":"http://patchwork.ozlabs.org/api/1.0/series/1198/?format=json","date":"2017-09-03T05:30:40","name":"net: qualcomm: rmnet: Fix comments on initial patchset","version":1,"mbox":"http://patchwork.ozlabs.org/series/1198/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809220/checks/","tags":{},"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"AxXYSEHw\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"AxXYSEHw\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=subashab@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlM6t2Y3Vz9sDB\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun,  3 Sep 2017 15:32:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751445AbdICFby (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 3 Sep 2017 01:31:54 -0400","from smtp.codeaurora.org ([198.145.29.96]:42644 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751196AbdICFbw (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sun, 3 Sep 2017 01:31:52 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 51FDF608C5; Sun,  3 Sep 2017 05:31:52 +0000 (UTC)","from subashab-lnx.qualcomm.com (unknown [129.46.15.92])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: subashab@codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id 882616087D;\n\tSun,  3 Sep 2017 05:31:51 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504416712;\n\tbh=M/unKTeGRppblYRRcdwDbQNwvbfuzxVFE3kY8msic4k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AxXYSEHwtHDooG47t8MemsCoKw8Z4wFchcTo7KtI0QUNF4coMjDB4DctGcS4+fnbV\n\tU0M4ZzteBf/yBWHGrfAnC1wFu6yldi855+tOv791b60FqOsASaE3uRPEc3qQOL/Dwk\n\tHvSNCTxCFJLmNPMSvCg0ZTk65G37ZyL6R29kwlbQ=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504416712;\n\tbh=M/unKTeGRppblYRRcdwDbQNwvbfuzxVFE3kY8msic4k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AxXYSEHwtHDooG47t8MemsCoKw8Z4wFchcTo7KtI0QUNF4coMjDB4DctGcS4+fnbV\n\tU0M4ZzteBf/yBWHGrfAnC1wFu6yldi855+tOv791b60FqOsASaE3uRPEc3qQOL/Dwk\n\tHvSNCTxCFJLmNPMSvCg0ZTk65G37ZyL6R29kwlbQ="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org 882616087D","From":"Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>","To":"netdev@vger.kernel.org, davem@davemloft.net","Cc":"Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>,\n\tDan Williams <dcbw@redhat.com>","Subject":"[PATCH net-next 2/6] net: qualcomm: rmnet: Remove the unused\n\tendpoint -1","Date":"Sat,  2 Sep 2017 23:30:42 -0600","Message-Id":"<1504416646-9527-3-git-send-email-subashab@codeaurora.org>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1504416646-9527-1-git-send-email-subashab@codeaurora.org>","References":"<1504416646-9527-1-git-send-email-subashab@codeaurora.org>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"This was used only in the original patch series where the IOCTLs were\npresent and is no longer in use.\n\nFixes: ceed73a2cf4a (\"drivers: net: ethernet: qualcomm: rmnet: Initial implementation\")\nSigned-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>\nCc: Dan Williams <dcbw@redhat.com>\n---\n drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 14 +++-----------\n 1 file changed, 3 insertions(+), 11 deletions(-)","diff":"diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c\nindex e836d26..3ca98ec 100644\n--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c\n+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c\n@@ -42,7 +42,6 @@\n  */\n \n /* Local Definitions and Declarations */\n-#define RMNET_LOCAL_LOGICAL_ENDPOINT -1\n \n struct rmnet_walk_data {\n \tstruct net_device *real_dev;\n@@ -89,10 +88,7 @@ static int rmnet_is_real_dev_registered(const struct net_device *real_dev)\n \t\tif (!r)\n \t\t\treturn NULL;\n \n-\t\tif (config_id == RMNET_LOCAL_LOGICAL_ENDPOINT)\n-\t\t\tep = &r->local_ep;\n-\t\telse\n-\t\t\tep = &r->muxed_ep[config_id];\n+\t\tep = &r->muxed_ep[config_id];\n \t}\n \n \treturn ep;\n@@ -182,10 +178,7 @@ static int __rmnet_set_endpoint_config(struct net_device *dev, int config_id,\n \t\treturn -EINVAL;\n \n \tmemcpy(dev_ep, ep, sizeof(struct rmnet_endpoint));\n-\tif (config_id == RMNET_LOCAL_LOGICAL_ENDPOINT)\n-\t\tdev_ep->mux_id = 0;\n-\telse\n-\t\tdev_ep->mux_id = config_id;\n+\tdev_ep->mux_id = config_id;\n \n \treturn 0;\n }\n@@ -199,8 +192,7 @@ static int rmnet_set_endpoint_config(struct net_device *dev,\n \tnetdev_dbg(dev, \"id %d mode %d dev %s\\n\",\n \t\t   config_id, rmnet_mode, egress_dev->name);\n \n-\tif (config_id < RMNET_LOCAL_LOGICAL_ENDPOINT ||\n-\t    config_id >= RMNET_MAX_LOGICAL_EP)\n+\tif (config_id >= RMNET_MAX_LOGICAL_EP)\n \t\treturn -EINVAL;\n \n \t/* This config is cleared on every set, so its ok to not\n","prefixes":["net-next","2/6"]}