{"id":809167,"url":"http://patchwork.ozlabs.org/api/1.0/patches/809167/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170902214929.2890-14-jiri@resnulli.us>","date":"2017-09-02T21:49:21","name":"[net-next,v2,13/21] mlxsw: spectrum_router: Extract mlxsw_sp_rt6_is_gateway()","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"14099b53e76ab9a2ffffbbe9f22b96aa51d012a7","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/1.0/people/15321/?format=json","name":"Jiri Pirko","email":"jiri@resnulli.us"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170902214929.2890-14-jiri@resnulli.us/mbox/","series":[{"id":1180,"url":"http://patchwork.ozlabs.org/api/1.0/series/1180/?format=json","date":"2017-09-02T21:49:08","name":"mlxsw: Offloading GRE tunnels","version":2,"mbox":"http://patchwork.ozlabs.org/series/1180/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809167/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"JTwuA6aB\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl8tb3573z9s8J\n\tfor ;\n\tSun, 3 Sep 2017 07:50:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752944AbdIBVup (ORCPT );\n\tSat, 2 Sep 2017 17:50:45 -0400","from mail-wm0-f67.google.com ([74.125.82.67]:33973 \"EHLO\n\tmail-wm0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752835AbdIBVtx (ORCPT\n\t); Sat, 2 Sep 2017 17:49:53 -0400","by mail-wm0-f67.google.com with SMTP id l19so3163779wmi.1\n\tfor ; Sat, 02 Sep 2017 14:49:53 -0700 (PDT)","from localhost (jirka.pirko.cz. [84.16.102.26])\n\tby smtp.gmail.com with ESMTPSA id\n\tx81sm10125875wmd.5.2017.09.02.14.49.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 02 Sep 2017 14:49:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=ogidlot9KtbXqTpVSndwU+DxaC21s0gY3l/qzVOyys8=;\n\tb=JTwuA6aB6XvIt95tzp1oqWMi2xjnnyHbZFys+ql0VnM+HWDS/5d8+le3dWoA9f5xSY\n\tLCDRQ1Z0VuMBw7FZOZW8j0DXFdPG+fATofTJCSm2I2gvEu4cifc/XQ5JhYCD92ngtscS\n\tpye0rZuwthdnTwVo295yz1SkL+Fd99e74qfxLNPk/Lqk0p2ouJOeArpPUWKe7Z2+y7xd\n\tYDhVcuMoW1PyQlmbieEK9FmRO+n6ye7HfzEHswzbM44YfmpnQOXGeWlobJ6WnKC+Ecxa\n\tGKlEWAt/sdw/GgRGOVH67j52xlDjj//Rw2gIJCaPfcfUSUMYwRH/rYhabA7z7rKgjNZK\n\tLbug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=ogidlot9KtbXqTpVSndwU+DxaC21s0gY3l/qzVOyys8=;\n\tb=Bg9hzg92ymzzDStAj4BTPAx6hZ12T9Al7UsTnYVR4LpE4l/doniGv69kFCHQfjaui7\n\tRbqyPVQ60zMDUtSvoZMg0k+NUllyehGN9VAeSga4tJBS98ea8i6FoA5zyJXE7baF05Qo\n\txd4qpeXcN/NGASCYs6s4q8fHj7c/7TcF+baztUSragkNhjdpOnSjuqb6Yz3EvuSXSXM8\n\tQBHJG8uKcwwtl6ctLHqH9jbqyl3Rc3+3ag8CD8eD+5mS1LH4P4CvmfcvQvjqyS+498zf\n\tzqTvR+x1xXdd6jkK6p/tOkiS1uHA2mECZG8ptbWF0Xnwpibgfd+ZWSNA4Fz3TZZjAikS\n\tP/kg==","X-Gm-Message-State":"AHPjjUjbeoMSKjaIf8AhWGwPAcnytyMEMCqOCjo+zqYL48ypm27LfBjP\n\tnst6utAZjE0VsZ6buZU=","X-Google-Smtp-Source":"ADKCNb7YK+0/OJlloc2Rkw50CMlpB6wkA0UF4DuBRsF+06PYXLkk0sAXsaOWqArWWYd90APrs5pzjQ==","X-Received":"by 10.28.210.9 with SMTP id j9mr1199927wmg.134.1504388992084;\n\tSat, 02 Sep 2017 14:49:52 -0700 (PDT)","From":"Jiri Pirko ","To":"netdev@vger.kernel.org","Cc":"davem@davemloft.net, petrm@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com","Subject":"[patch net-next v2 13/21] mlxsw: spectrum_router: Extract\n\tmlxsw_sp_rt6_is_gateway()","Date":"Sat, 2 Sep 2017 23:49:21 +0200","Message-Id":"<20170902214929.2890-14-jiri@resnulli.us>","X-Mailer":"git-send-email 2.9.3","In-Reply-To":"<20170902214929.2890-1-jiri@resnulli.us>","References":"<20170902214929.2890-1-jiri@resnulli.us>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Petr Machata \n\nIPv6 counterpart of the previous patch: introduce a function to\ndetermine whether a given route is a gateway route.\n\nThe new function takes a mlxsw_sp argument which follow-up patches will\nuse. Thus mlxsw_sp_fib6_entry_type_set() got that argument as well.\n\nSigned-off-by: Petr Machata \nReviewed-by: Ido Schimmel \nSigned-off-by: Jiri Pirko \n---\n drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 15 +++++++++++----\n 1 file changed, 11 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\nindex 04e1887..563e803 100644\n--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\n+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\n@@ -3526,6 +3526,12 @@ static void mlxsw_sp_nexthop6_fini(struct mlxsw_sp *mlxsw_sp,\n \tmlxsw_sp_nexthop_rif_fini(nh);\n }\n \n+static bool mlxsw_sp_rt6_is_gateway(const struct mlxsw_sp *mlxsw_sp,\n+\t\t\t\t const struct rt6_info *rt)\n+{\n+\treturn rt->rt6i_flags & RTF_GATEWAY;\n+}\n+\n static struct mlxsw_sp_nexthop_group *\n mlxsw_sp_nexthop6_group_create(struct mlxsw_sp *mlxsw_sp,\n \t\t\t struct mlxsw_sp_fib6_entry *fib6_entry)\n@@ -3548,7 +3554,7 @@ mlxsw_sp_nexthop6_group_create(struct mlxsw_sp *mlxsw_sp,\n #endif\n \tmlxsw_sp_rt6 = list_first_entry(&fib6_entry->rt6_list,\n \t\t\t\t\tstruct mlxsw_sp_rt6, list);\n-\tnh_grp->gateway = !!(mlxsw_sp_rt6->rt->rt6i_flags & RTF_GATEWAY);\n+\tnh_grp->gateway = mlxsw_sp_rt6_is_gateway(mlxsw_sp, mlxsw_sp_rt6->rt);\n \tnh_grp->count = fib6_entry->nrt6;\n \tfor (i = 0; i < nh_grp->count; i++) {\n \t\tstruct rt6_info *rt = mlxsw_sp_rt6->rt;\n@@ -3705,7 +3711,8 @@ mlxsw_sp_fib6_entry_nexthop_del(struct mlxsw_sp *mlxsw_sp,\n \tmlxsw_sp_rt6_destroy(mlxsw_sp_rt6);\n }\n \n-static void mlxsw_sp_fib6_entry_type_set(struct mlxsw_sp_fib_entry *fib_entry,\n+static void mlxsw_sp_fib6_entry_type_set(struct mlxsw_sp *mlxsw_sp,\n+\t\t\t\t\t struct mlxsw_sp_fib_entry *fib_entry,\n \t\t\t\t\t const struct rt6_info *rt)\n {\n \t/* Packets hitting RTF_REJECT routes need to be discarded by the\n@@ -3718,7 +3725,7 @@ static void mlxsw_sp_fib6_entry_type_set(struct mlxsw_sp_fib_entry *fib_entry,\n \t\tfib_entry->type = MLXSW_SP_FIB_ENTRY_TYPE_TRAP;\n \telse if (rt->rt6i_flags & RTF_REJECT)\n \t\tfib_entry->type = MLXSW_SP_FIB_ENTRY_TYPE_LOCAL;\n-\telse if (rt->rt6i_flags & RTF_GATEWAY)\n+\telse if (mlxsw_sp_rt6_is_gateway(mlxsw_sp, rt))\n \t\tfib_entry->type = MLXSW_SP_FIB_ENTRY_TYPE_REMOTE;\n \telse\n \t\tfib_entry->type = MLXSW_SP_FIB_ENTRY_TYPE_LOCAL;\n@@ -3758,7 +3765,7 @@ mlxsw_sp_fib6_entry_create(struct mlxsw_sp *mlxsw_sp,\n \t\tgoto err_rt6_create;\n \t}\n \n-\tmlxsw_sp_fib6_entry_type_set(fib_entry, mlxsw_sp_rt6->rt);\n+\tmlxsw_sp_fib6_entry_type_set(mlxsw_sp, fib_entry, mlxsw_sp_rt6->rt);\n \n \tINIT_LIST_HEAD(&fib6_entry->rt6_list);\n \tlist_add_tail(&mlxsw_sp_rt6->list, &fib6_entry->rt6_list);\n","prefixes":["net-next","v2","13/21"]}