{"id":809144,"url":"http://patchwork.ozlabs.org/api/1.0/patches/809144/?format=json","project":{"id":27,"url":"http://patchwork.ozlabs.org/api/1.0/projects/27/?format=json","name":"Buildroot development","link_name":"buildroot","list_id":"buildroot.buildroot.org","list_email":"buildroot@buildroot.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170902205423.21288-5-romain.naour@gmail.com>","date":"2017-09-02T20:54:16","name":"[v2,04/11] package/jsoncpp: fix build with glibc >= 2.26","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":false,"hash":"84f8c85d616dd91577df43ce8318e91658e02a95","submitter":{"id":67942,"url":"http://patchwork.ozlabs.org/api/1.0/people/67942/?format=json","name":"Romain Naour","email":"romain.naour@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/buildroot/patch/20170902205423.21288-5-romain.naour@gmail.com/mbox/","series":[{"id":1178,"url":"http://patchwork.ozlabs.org/api/1.0/series/1178/?format=json","date":"2017-09-02T20:54:12","name":"glibc: bump to 2.26","version":2,"mbox":"http://patchwork.ozlabs.org/series/1178/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809144/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"udJwmGxE\"; dkim-atps=neutral"],"Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xl7dz4k7qz9sRY\n\tfor ;\n\tSun, 3 Sep 2017 06:54:47 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0AC49834E8;\n\tSat, 2 Sep 2017 20:54:42 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OJH7lD9Rc_li; Sat, 2 Sep 2017 20:54:39 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 52F358207A;\n\tSat, 2 Sep 2017 20:54:38 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 58A051BFF90\n\tfor ;\n\tSat, 2 Sep 2017 20:54:34 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5499A87062\n\tfor ;\n\tSat, 2 Sep 2017 20:54:34 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LbeT4yAKaidK for ;\n\tSat, 2 Sep 2017 20:54:33 +0000 (UTC)","from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 9FCD286E55\n\tfor ; Sat, 2 Sep 2017 20:54:33 +0000 (UTC)","by mail-wm0-f65.google.com with SMTP id x189so3089971wmg.4\n\tfor ; Sat, 02 Sep 2017 13:54:33 -0700 (PDT)","from localhost.localdomain\n\t([2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf])\n\tby smtp.gmail.com with ESMTPSA id\n\t52sm2295647wru.59.2017.09.02.13.54.31\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 02 Sep 2017 13:54:31 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=AdmXNyrKl7tavXVMlX4F+flKanx99lI+OmSuGa0lhw4=;\n\tb=udJwmGxEgRvY+jEDq2N45gNSlaj5WcVvyVx4r7s1wPbAYc88TLZ3eZY1EMMOd2H/XX\n\twglTlVXWYhkM3R/ub6NDGtr56KPrZFgWAY7qoAiTbQtoqUBDpgrz9oTR+jqZ82Qx3JAo\n\tcLn7jOWgj82NKjHN7HQ5b1OCcRDwvV9uUGCDFXmXyIUjMw272ua23lgEor+eR45TqwS8\n\ty0pTpVIknqVkKxmwxPlUHVEHsFJfR5lyy8AuAhdLUGxbJN0A5dp3ouKCTwllrygmKFLz\n\tWOnOFhVQcKuMp/wSwlPTlgyUjwG8EHPoK/mp0UYfFNwARftsmNtJZqa7ooZl3cBSrRBK\n\tMdJQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=AdmXNyrKl7tavXVMlX4F+flKanx99lI+OmSuGa0lhw4=;\n\tb=gq5ufPgyhtgnpGUUCWL1WvPNIKYAEV5acj1j+kqZVLcmMW9glCVOrFMqlDborzNA4p\n\thA+VlxQ6iGR8nEg7rT1AhKDqV/RRM45dQQbXo2DFCXbdHMeVL2r72akIXQ9PxWAIfTOu\n\tgCs1tJ486yy4bnOR/2X0qBcO/qtDi3p8OB7jZutQ5e/IsQAKeO83DGw7Cd60uJtkO7wk\n\tKkzQ65m9iQlgxx9NcwskGC4/tsx5+mQMWzbwiNrAniP21PFdo0Ppd/2YDCXazFCLqoji\n\tSUHmHE+y7RM4LWQCeVlbWFAZsQi66Bm8LHxQUQOyVJyjwG65rIv1RqBIkS02jpHIxUPP\n\tZL5w==","X-Gm-Message-State":"AHPjjUgjTPLk3jpnMq3aF1imcEevBKWQJxDj+MLSfthz0ZvgKlUf9NPn\n\tFIHvHDlxZWR0lx9VmQs=","X-Google-Smtp-Source":"ADKCNb5cCOBTGTlCd1B7/J7ncdeQe2TDqSJGXZMUjMq/dzqzjbJ5iXkfzVhYwPZbuW01pWAkw3mriQ==","X-Received":"by 10.28.54.68 with SMTP id d65mr1121120wma.37.1504385671986;\n\tSat, 02 Sep 2017 13:54:31 -0700 (PDT)","From":"Romain Naour ","To":"buildroot@buildroot.org","Date":"Sat, 2 Sep 2017 22:54:16 +0200","Message-Id":"<20170902205423.21288-5-romain.naour@gmail.com>","X-Mailer":"git-send-email 2.9.5","In-Reply-To":"<20170902205423.21288-1-romain.naour@gmail.com>","References":"<20170902205423.21288-1-romain.naour@gmail.com>","Cc":"Romain Naour ","Subject":"[Buildroot] [PATCH v2 04/11] package/jsoncpp: fix build with glibc\n\t>= 2.26","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "},"content":"Issue found while testing glibc 2.26 bump.\n\nFixes:\nsrc/lib_json/json_writer.cpp:45:23: error: 'isfinite' is not a member of 'std'\n #define isfinite std::isfinite\n ^\n\nSigned-off-by: Romain Naour \n---\nv2: fix build with musl (ThomasP)\n---\n ...001-json_writer-fix-build-with-glibc-2.26.patch | 34 ++++++++++++++++++++++\n 1 file changed, 34 insertions(+)\n create mode 100644 package/jsoncpp/0001-json_writer-fix-build-with-glibc-2.26.patch","diff":"diff --git a/package/jsoncpp/0001-json_writer-fix-build-with-glibc-2.26.patch b/package/jsoncpp/0001-json_writer-fix-build-with-glibc-2.26.patch\nnew file mode 100644\nindex 0000000..fe7df85\n--- /dev/null\n+++ b/package/jsoncpp/0001-json_writer-fix-build-with-glibc-2.26.patch\n@@ -0,0 +1,34 @@\n+From 2cb87c456f95510d55dd40f783435ecd1177c453 Mon Sep 17 00:00:00 2001\n+From: Romain Naour \n+Date: Sat, 26 Aug 2017 19:39:03 +0200\n+Subject: [PATCH] json_writer: fix build with glibc >= 2.26\n+\n+src/lib_json/json_writer.cpp:45:23: error: 'isfinite' is not a member of 'std'\n+ #define isfinite std::isfinite\n+ ^\n+\n+Signed-off-by: Romain Naour \n+---\n+ src/lib_json/json_writer.cpp | 3 +++\n+ 1 file changed, 3 insertions(+)\n+\n+diff --git a/src/lib_json/json_writer.cpp b/src/lib_json/json_writer.cpp\n+index 02f1cb1..a3189cb 100644\n+--- a/src/lib_json/json_writer.cpp\n++++ b/src/lib_json/json_writer.cpp\n+@@ -42,9 +42,12 @@\n+ #else\n+ #include \n+ #if !(defined(__QNXNTO__)) // QNX already defines isfinite\n++// std::isfinite is not defined on glibc >= 2.26\n++#if !(defined(__GLIBC__) && (__GLIBC__ > 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 26)))\n+ #define isfinite std::isfinite\n+ #endif\n+ #endif\n++#endif\n+ \n+ #if defined(_MSC_VER)\n+ #if !defined(WINCE) && defined(__STDC_SECURE_LIB__) && _MSC_VER >= 1500 // VC++ 9.0 and above\n+-- \n+2.9.5\n+\n","prefixes":["v2","04/11"]}