{"id":809020,"url":"http://patchwork.ozlabs.org/api/1.0/patches/809020/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170901213007.10325-4-haiyangz@exchange.microsoft.com>","date":"2017-09-01T21:30:06","name":"[net-next,3/4] hv_netvsc: Simplify the limit check in netvsc_set_channels()","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"529c72c6b6b34628f5eee3b79e4cdd1978ea8ccc","submitter":{"id":69452,"url":"http://patchwork.ozlabs.org/api/1.0/people/69452/?format=json","name":"Haiyang Zhang","email":"haiyangz@exchange.microsoft.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170901213007.10325-4-haiyangz@exchange.microsoft.com/mbox/","series":[{"id":1122,"url":"http://patchwork.ozlabs.org/api/1.0/series/1122/?format=json","date":"2017-09-01T21:30:04","name":"cleanups and fixes of channel settings","version":1,"mbox":"http://patchwork.ozlabs.org/series/1122/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809020/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkXWr68pZz9sPt\n\tfor ;\n\tSat, 2 Sep 2017 07:32:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752707AbdIAVbX (ORCPT );\n\tFri, 1 Sep 2017 17:31:23 -0400","from a2nlsmtp01-02.prod.iad2.secureserver.net\n\t([198.71.225.36]:44668\n\t\"EHLO a2nlsmtp01-02.prod.iad2.secureserver.net\"\n\trhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752663AbdIAVbV (ORCPT\n\t); Fri, 1 Sep 2017 17:31:21 -0400","from linuxonhyperv.com ([107.180.71.197])\n\tby : HOSTING RELAY : with SMTP\n\tid ntW7d0U8lDbVLntW7dK02I; Fri, 01 Sep 2017 14:30:19 -0700","from haiyangz by linuxonhyperv.com with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dntW7-0002hY-Qd; Fri, 01 Sep 2017 14:30:19 -0700"],"x-originating-ip":"107.180.71.197","From":"Haiyang Zhang ","To":"davem@davemloft.net, netdev@vger.kernel.org","Cc":"haiyangz@microsoft.com, kys@microsoft.com, olaf@aepfle.de,\n\tvkuznets@redhat.com, linux-kernel@vger.kernel.org","Subject":"[PATCH net-next,\n\t3/4] hv_netvsc: Simplify the limit check in netvsc_set_channels()","Date":"Fri, 1 Sep 2017 14:30:06 -0700","Message-Id":"<20170901213007.10325-4-haiyangz@exchange.microsoft.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170901213007.10325-1-haiyangz@exchange.microsoft.com>","References":"<20170901213007.10325-1-haiyangz@exchange.microsoft.com>","Reply-To":"haiyangz@microsoft.com","X-CMAE-Envelope":"MS4wfH8t323ibhjgZz2OxtdXsU/ZgzRJ0wNIlYm3uigV0gUoJfUTjpvcfFEX8zxYnc76YSRaSwNjWZBej9QW7IILzItIJLzmiXZYEKiXAafQtSgtXeliCGPV\n\tchCY+Wi+cFsWBlYvxBQMOZdF3W3tdejlWtLLNS3Pcj1AP8wAb7IHUe5BPjADzURvPakX+nwszh3gmoIkvDcaVMOFV994qh4B9pY/ZjB82IDxy1nRYqAb9Eb+\n\t7kifPlBZZ23WDoh2yUM2J3eVpc8c+KDlTGrpl5fkK7+Nbzi/tkKPTfb/1jP11KZ2gvrAXzG/08M03GgL2XpUBF4XswXWb32n+oNvkQ4fSy3Iy1UD3H3QTXdF\n\tf1M1XU9biLRUh4b96lzBLXL+KsgSrQ==","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Haiyang Zhang \n\nBecause of the following code, net->num_tx_queues equals to\nVRSS_CHANNEL_MAX, and max_chn is less than or equals to VRSS_CHANNEL_MAX.\n\nnetvsc_drv.c:\nalloc_etherdev_mq(sizeof(struct net_device_context),\n VRSS_CHANNEL_MAX);\nrndis_filter.c:\nnet_device->max_chn = min_t(u32, VRSS_CHANNEL_MAX, num_possible_rss_qs);\n\nSo this patch removes the unnecessary limit check before comparing\nwith \"max_chn\".\n\nSigned-off-by: Haiyang Zhang \n---\n drivers/net/hyperv/netvsc_drv.c | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c\nindex b8e23e257f00..718d126108f6 100644\n--- a/drivers/net/hyperv/netvsc_drv.c\n+++ b/drivers/net/hyperv/netvsc_drv.c\n@@ -830,9 +830,6 @@ static int netvsc_set_channels(struct net_device *net,\n \t channels->rx_count || channels->tx_count || channels->other_count)\n \t\treturn -EINVAL;\n \n-\tif (count > net->num_tx_queues || count > VRSS_CHANNEL_MAX)\n-\t\treturn -EINVAL;\n-\n \tif (!nvdev || nvdev->destroy)\n \t\treturn -ENODEV;\n \n","prefixes":["net-next","3/4"]}