{"id":809019,"url":"http://patchwork.ozlabs.org/api/1.0/patches/809019/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170901213007.10325-3-haiyangz@exchange.microsoft.com>","date":"2017-09-01T21:30:05","name":"[net-next,2/4] hv_netvsc: Simplify num_chn checking in rndis_filter_device_add()","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"a4385ba896e9711c17a74aec0b12e6ad978d1eab","submitter":{"id":69452,"url":"http://patchwork.ozlabs.org/api/1.0/people/69452/?format=json","name":"Haiyang Zhang","email":"haiyangz@exchange.microsoft.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170901213007.10325-3-haiyangz@exchange.microsoft.com/mbox/","series":[{"id":1122,"url":"http://patchwork.ozlabs.org/api/1.0/series/1122/?format=json","date":"2017-09-01T21:30:04","name":"cleanups and fixes of channel settings","version":1,"mbox":"http://patchwork.ozlabs.org/series/1122/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809019/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkXWd2CDcz9sQl\n\tfor ;\n\tSat, 2 Sep 2017 07:32:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752719AbdIAVbY (ORCPT );\n\tFri, 1 Sep 2017 17:31:24 -0400","from a2nlsmtp01-04.prod.iad2.secureserver.net\n\t([198.71.225.38]:51780\n\t\"EHLO a2nlsmtp01-04.prod.iad2.secureserver.net\"\n\trhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752423AbdIAVbU (ORCPT\n\t); Fri, 1 Sep 2017 17:31:20 -0400","from linuxonhyperv.com ([107.180.71.197])\n\tby : HOSTING RELAY : with SMTP\n\tid ntW6dbufIYn9KntW6d1zwZ; Fri, 01 Sep 2017 14:30:18 -0700","from haiyangz by linuxonhyperv.com with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dntW6-0002hS-8J; Fri, 01 Sep 2017 14:30:18 -0700"],"x-originating-ip":"107.180.71.197","From":"Haiyang Zhang ","To":"davem@davemloft.net, netdev@vger.kernel.org","Cc":"haiyangz@microsoft.com, kys@microsoft.com, olaf@aepfle.de,\n\tvkuznets@redhat.com, linux-kernel@vger.kernel.org","Subject":"[PATCH net-next, 2/4] hv_netvsc: Simplify num_chn checking in\n\trndis_filter_device_add()","Date":"Fri, 1 Sep 2017 14:30:05 -0700","Message-Id":"<20170901213007.10325-3-haiyangz@exchange.microsoft.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170901213007.10325-1-haiyangz@exchange.microsoft.com>","References":"<20170901213007.10325-1-haiyangz@exchange.microsoft.com>","Reply-To":"haiyangz@microsoft.com","X-CMAE-Envelope":"MS4wfFsqBTE4BVzatd04QQKER4bLMNRs/uUEH5gAFnlu9y0rYduzxPL4hLNhneEQdkTcJWnZ19YAVFo3TcHxOdsqUFW23Y9527zzPYdvwWzYVZrmyf/e1Wx9\n\t15Eo04sSQEKn7RohEIaIwkSieRmAIm2hK5kH4ItoCQBRMjT4KT0viYcCeCqQMm5TK8dfB6EWAjD8TkDZOgAlIjNTT6YPNHHY+KWVCOgp9yIg/EWgeGwc/Qpp\n\tGDYnoKcTHaD7ERNZ5edHEa45NV2CupRfN+TsiHqVPedrfLrzE61nIx3zjGTt8ZJsyeQQ6jlRMuZYJ/2R1wqnZ/nzyiF34QWWM96c2LoKvy3r+taBZ9yIzKDK\n\thmccHyXu6qrAywRhdJ7ZoKzFYiHCrg==","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Haiyang Zhang \n\nThe minus one and assignment to a local variable is not necessary.\nThis patch simplifies it.\n\nSigned-off-by: Haiyang Zhang \n---\n drivers/net/hyperv/rndis_filter.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c\nindex 496fefa7c7c4..69c40b8fccc3 100644\n--- a/drivers/net/hyperv/rndis_filter.c\n+++ b/drivers/net/hyperv/rndis_filter.c\n@@ -1067,7 +1067,7 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev,\n \tstruct ndis_recv_scale_cap rsscap;\n \tu32 rsscap_size = sizeof(struct ndis_recv_scale_cap);\n \tunsigned int gso_max_size = GSO_MAX_SIZE;\n-\tu32 mtu, size, num_rss_qs;\n+\tu32 mtu, size;\n \tconst struct cpumask *node_cpu_mask;\n \tu32 num_possible_rss_qs;\n \tint i, ret;\n@@ -1215,8 +1215,8 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev,\n \t\t\t\t\t\t\tnet_device->num_chn);\n \n \tatomic_set(&net_device->open_chn, 1);\n-\tnum_rss_qs = net_device->num_chn - 1;\n-\tif (num_rss_qs == 0)\n+\n+\tif (net_device->num_chn == 1)\n \t\treturn net_device;\n \n \tfor (i = 1; i < net_device->num_chn; i++) {\n","prefixes":["net-next","2/4"]}