{"id":809017,"url":"http://patchwork.ozlabs.org/api/1.0/patches/809017/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170901213007.10325-2-haiyangz@exchange.microsoft.com>","date":"2017-09-01T21:30:04","name":"[net-next,1/4] hv_netvsc: Clean up an unused parameter in rndis_filter_set_rss_param()","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"9cdd4f7659084d1148e612633cf68fbebfe76c74","submitter":{"id":69452,"url":"http://patchwork.ozlabs.org/api/1.0/people/69452/?format=json","name":"Haiyang Zhang","email":"haiyangz@exchange.microsoft.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170901213007.10325-2-haiyangz@exchange.microsoft.com/mbox/","series":[{"id":1122,"url":"http://patchwork.ozlabs.org/api/1.0/series/1122/?format=json","date":"2017-09-01T21:30:04","name":"cleanups and fixes of channel settings","version":1,"mbox":"http://patchwork.ozlabs.org/series/1122/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809017/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkXW72qsVz9sPt\n\tfor ;\n\tSat, 2 Sep 2017 07:31:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752731AbdIAVbY (ORCPT );\n\tFri, 1 Sep 2017 17:31:24 -0400","from a2nlsmtp01-02.prod.iad2.secureserver.net\n\t([198.71.225.36]:44668\n\t\"EHLO a2nlsmtp01-02.prod.iad2.secureserver.net\"\n\trhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752392AbdIAVbU (ORCPT\n\t); Fri, 1 Sep 2017 17:31:20 -0400","from linuxonhyperv.com ([107.180.71.197])\n\tby : HOSTING RELAY : with SMTP\n\tid ntW4d0U53DbVLntW4dJzyo; Fri, 01 Sep 2017 14:30:16 -0700","from haiyangz by linuxonhyperv.com with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dntW4-0002hM-Au; Fri, 01 Sep 2017 14:30:16 -0700"],"x-originating-ip":"107.180.71.197","From":"Haiyang Zhang ","To":"davem@davemloft.net, netdev@vger.kernel.org","Cc":"haiyangz@microsoft.com, kys@microsoft.com, olaf@aepfle.de,\n\tvkuznets@redhat.com, linux-kernel@vger.kernel.org","Subject":"[PATCH net-next, 1/4] hv_netvsc: Clean up an unused parameter in\n\trndis_filter_set_rss_param()","Date":"Fri, 1 Sep 2017 14:30:04 -0700","Message-Id":"<20170901213007.10325-2-haiyangz@exchange.microsoft.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170901213007.10325-1-haiyangz@exchange.microsoft.com>","References":"<20170901213007.10325-1-haiyangz@exchange.microsoft.com>","Reply-To":"haiyangz@microsoft.com","X-CMAE-Envelope":"MS4wfM3i7UlixhDTLRyx89H1wy+rBgdBsnQyyPLeU61ij2zqmNZEELVdEMINNhmv/JkBJu2U/oUm8/t78/hBShB7Kx89FZZk8/0RsjPjbhPcbEmeFW/ez2ca\n\tmndBasRqbk6owK9lTdNOMBekI0eipUjZWb+QEsql5BPR5vbmEDlrFB4T15P2w70ezEHhdao8Vp1jLxzb4PAUN3H9WJQFwTuTcBLXR1LYFZhLW1OEN+bdHp4w\n\tPNo+Ng6pJeMWZE6pZUo3kVq2rg7C9X5I4ZQ0y/oig9jL/Z0fI+XAQ4pqsKhXULj0jm6+Wm/Rdyty8pa1z88dti7RFg1h8q8T8WaYsOpcAxr5d57xvY+IbLyP\n\tbjYz/VD13IdCY+qfmQcnpU9dNgFhNQ==","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Haiyang Zhang \n\nThis patch removes the parameter, num_queue in\nrndis_filter_set_rss_param(), which is no longer in use.\n\nSigned-off-by: Haiyang Zhang \n---\n drivers/net/hyperv/hyperv_net.h | 2 +-\n drivers/net/hyperv/netvsc_drv.c | 2 +-\n drivers/net/hyperv/rndis_filter.c | 5 ++---\n 3 files changed, 4 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h\nindex ff1c0c8d5e0d..ec546da86683 100644\n--- a/drivers/net/hyperv/hyperv_net.h\n+++ b/drivers/net/hyperv/hyperv_net.h\n@@ -213,7 +213,7 @@ void rndis_filter_update(struct netvsc_device *nvdev);\n void rndis_filter_device_remove(struct hv_device *dev,\n \t\t\t\tstruct netvsc_device *nvdev);\n int rndis_filter_set_rss_param(struct rndis_device *rdev,\n-\t\t\t const u8 *key, int num_queue);\n+\t\t\t const u8 *key);\n int rndis_filter_receive(struct net_device *ndev,\n \t\t\t struct netvsc_device *net_dev,\n \t\t\t struct hv_device *dev,\ndiff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c\nindex 97ed4bdc439f..b8e23e257f00 100644\n--- a/drivers/net/hyperv/netvsc_drv.c\n+++ b/drivers/net/hyperv/netvsc_drv.c\n@@ -1424,7 +1424,7 @@ static int netvsc_set_rxfh(struct net_device *dev, const u32 *indir,\n \t\tkey = rndis_dev->rss_key;\n \t}\n \n-\treturn rndis_filter_set_rss_param(rndis_dev, key, ndev->num_chn);\n+\treturn rndis_filter_set_rss_param(rndis_dev, key);\n }\n \n /* Hyper-V RNDIS protocol does not have ring in the HW sense.\ndiff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c\nindex 36e9ee82ec6f..496fefa7c7c4 100644\n--- a/drivers/net/hyperv/rndis_filter.c\n+++ b/drivers/net/hyperv/rndis_filter.c\n@@ -717,7 +717,7 @@ rndis_filter_set_offload_params(struct net_device *ndev,\n }\n \n int rndis_filter_set_rss_param(struct rndis_device *rdev,\n-\t\t\t const u8 *rss_key, int num_queue)\n+\t\t\t const u8 *rss_key)\n {\n \tstruct net_device *ndev = rdev->ndev;\n \tstruct rndis_request *request;\n@@ -1258,8 +1258,7 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev,\n \t\t atomic_read(&net_device->open_chn) == net_device->num_chn);\n \n \t/* ignore failues from setting rss parameters, still have channels */\n-\trndis_filter_set_rss_param(rndis_device, netvsc_hash_key,\n-\t\t\t\t net_device->num_chn);\n+\trndis_filter_set_rss_param(rndis_device, netvsc_hash_key);\n out:\n \tif (ret) {\n \t\tnet_device->max_chn = 1;\n","prefixes":["net-next","1/4"]}