{"id":808923,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808923/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180340.30009-6-eblake@redhat.com>","date":"2017-09-01T18:03:16","name":"[v6,05/29] numa-test: Use hmp()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"66622321966953644e431d55ea707da358260c26","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/1.0/people/6591/?format=json","name":"Eric Blake","email":"eblake@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901180340.30009-6-eblake@redhat.com/mbox/","series":[{"id":1089,"url":"http://patchwork.ozlabs.org/api/1.0/series/1089/?format=json","date":"2017-09-01T18:03:12","name":"Preliminary libqtest cleanups","version":6,"mbox":"http://patchwork.ozlabs.org/series/1089/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808923/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkS5j1LSZz9s7g\n\tfor ;\n\tSat, 2 Sep 2017 04:12:57 +1000 (AEST)","from localhost ([::1]:53127 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnqR5-00073L-6R\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 14:12:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55645)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnqIK-0006zK-Cf\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:03:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnqIJ-0001V2-DJ\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:03:52 -0400","from mx1.redhat.com ([209.132.183.28]:52748)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnqIJ-0001Tx-88\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:03:51 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 512DC81E0C\n\tfor ; Fri, 1 Sep 2017 18:03:50 +0000 (UTC)","from red.redhat.com (ovpn-121-149.rdu2.redhat.com [10.10.121.149])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 691805450A;\n\tFri, 1 Sep 2017 18:03:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 512DC81E0C","From":"Eric Blake ","To":"qemu-devel@nongnu.org","Date":"Fri, 1 Sep 2017 13:03:16 -0500","Message-Id":"<20170901180340.30009-6-eblake@redhat.com>","In-Reply-To":"<20170901180340.30009-1-eblake@redhat.com>","References":"<20170901180340.30009-1-eblake@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 01 Sep 2017 18:03:50 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v6 05/29] numa-test: Use hmp()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Don't open-code something that has a convenient helper available.\n\nSigned-off-by: Eric Blake \nReviewed-by: Markus Armbruster \nReviewed-by: Philippe Mathieu-Daudé \n---\n tests/numa-test.c | 21 +++------------------\n 1 file changed, 3 insertions(+), 18 deletions(-)","diff":"diff --git a/tests/numa-test.c b/tests/numa-test.c\nindex 3f636840b1..e1b6152244 100644\n--- a/tests/numa-test.c\n+++ b/tests/numa-test.c\n@@ -17,21 +17,6 @@ static char *make_cli(const char *generic_cli, const char *test_cli)\n return g_strdup_printf(\"%s %s\", generic_cli ? generic_cli : \"\", test_cli);\n }\n\n-static char *hmp_info_numa(void)\n-{\n- QDict *resp;\n- char *s;\n-\n- resp = qmp(\"{ 'execute': 'human-monitor-command', 'arguments': \"\n- \"{ 'command-line': 'info numa '} }\");\n- g_assert(resp);\n- g_assert(qdict_haskey(resp, \"return\"));\n- s = g_strdup(qdict_get_str(resp, \"return\"));\n- g_assert(s);\n- QDECREF(resp);\n- return s;\n-}\n-\n static void test_mon_explicit(const void *data)\n {\n char *s;\n@@ -42,7 +27,7 @@ static void test_mon_explicit(const void *data)\n \"-numa node,nodeid=1,cpus=4-7 \");\n qtest_start(cli);\n\n- s = hmp_info_numa();\n+ s = hmp(\"info numa\");\n g_assert(strstr(s, \"node 0 cpus: 0 1 2 3\"));\n g_assert(strstr(s, \"node 1 cpus: 4 5 6 7\"));\n g_free(s);\n@@ -59,7 +44,7 @@ static void test_mon_default(const void *data)\n cli = make_cli(data, \"-smp 8 -numa node -numa node\");\n qtest_start(cli);\n\n- s = hmp_info_numa();\n+ s = hmp(\"info numa\");\n g_assert(strstr(s, \"node 0 cpus: 0 2 4 6\"));\n g_assert(strstr(s, \"node 1 cpus: 1 3 5 7\"));\n g_free(s);\n@@ -78,7 +63,7 @@ static void test_mon_partial(const void *data)\n \"-numa node,nodeid=1,cpus=4-5 \");\n qtest_start(cli);\n\n- s = hmp_info_numa();\n+ s = hmp(\"info numa\");\n g_assert(strstr(s, \"node 0 cpus: 0 1 2 3 6 7\"));\n g_assert(strstr(s, \"node 1 cpus: 4 5\"));\n g_free(s);\n","prefixes":["v6","05/29"]}