{"id":808917,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808917/?format=json","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.0/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180029.9527-49-hjl.tools@gmail.com>","date":"2017-09-01T18:00:19","name":"[48/58] Hide internal __tcgetattr function [BZ #18822]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9d1996c846f4ff2c2505cfd4a0c9614ac9782dc7","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/1.0/people/4387/?format=json","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-49-hjl.tools@gmail.com/mbox/","series":[{"id":1088,"url":"http://patchwork.ozlabs.org/api/1.0/series/1088/?format=json","date":"2017-09-01T18:00:21","name":"Hide internal functions in libc.so","version":1,"mbox":"http://patchwork.ozlabs.org/series/1088/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808917/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84102-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"iWG33rvM\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkS2n39S8z9s7g\n\tfor ;\n\tSat, 2 Sep 2017 04:10:25 +1000 (AEST)","(qmail 91830 invoked by alias); 1 Sep 2017 18:01:29 -0000","(qmail 91739 invoked by uid 89); 1 Sep 2017 18:01:28 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=b7SmCk3dkOYu5gZZkA6fL2qIhetARtv\n\tyX++7InPhEPab69XpawzCFBeYKAiUKDgw/E9PrxHlwaxezNBnZ4yBxIxQ7InxlsC\n\tR6hB4Prrh3yzBqeKuffHig4wfGvRlsi9VbVWyPK+fv1FoKoCOTjlqGKZStvDyJ7k\n\trdzo8ysL2RaQ=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=8N+GM7x40o41HlKkbMxG7s+vPhA=; b=iWG33\n\trvMVfnJYE5i8tLYm81g2vybFx0Ilt0ZVjzyAmFWHSNfnecGLsz47UPCuhpRJ+z2d\n\tkeul/UBEm6VyazdFybW6LWndC8XATlfVw397/bN/eqIdtvHoE09pQUzG3v99bU5j\n\tUH8G8l8OysrVEFatkTRDCNdJfJrwqJGl5XeAdA=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3,\n\tSPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=H*m:gmail","X-HELO":"mga02.intel.com","X-ExtLoop1":"1","From":"\"H.J. Lu\" ","To":"libc-alpha@sourceware.org","Subject":"[PATCH 48/58] Hide internal __tcgetattr function [BZ #18822]","Date":"Fri, 1 Sep 2017 11:00:19 -0700","Message-Id":"<20170901180029.9527-49-hjl.tools@gmail.com>","In-Reply-To":"<20170901180029.9527-1-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>"},"content":"Hide internal __tcgetattr function to allow direct access within libc.so\nand libc.a without using GOT nor PLT.\n\n\t[BZ #18822]\n\t* include/termios.h (__tcgetattr): Add libc_hidden_proto.\n\t* sysdeps/unix/bsd/tcgetattr.c (__tcgetattr): Add\n\tlibc_hidden_def.\n\t* sysdeps/unix/sysv/linux/tcgetattr.c (__tcgetattr): Likewise.\n\t* termios/tcgetattr.c (__tcgetattr): Likewise.\n---\n include/termios.h | 1 +\n sysdeps/unix/bsd/tcgetattr.c | 1 +\n sysdeps/unix/sysv/linux/tcgetattr.c | 1 +\n termios/tcgetattr.c | 1 +\n 4 files changed, 4 insertions(+)","diff":"diff --git a/include/termios.h b/include/termios.h\nindex 1a36e226b8..e2c35ebbae 100644\n--- a/include/termios.h\n+++ b/include/termios.h\n@@ -9,6 +9,7 @@ extern int __tcsetattr (int __fd, int __optional_actions,\n \n extern int __libc_tcdrain (int __fd);\n \n+libc_hidden_proto (__tcgetattr)\n libc_hidden_proto (tcsetattr)\n libc_hidden_proto (cfsetispeed)\n libc_hidden_proto (cfsetospeed)\ndiff --git a/sysdeps/unix/bsd/tcgetattr.c b/sysdeps/unix/bsd/tcgetattr.c\nindex 1779bb9342..654f1e6407 100644\n--- a/sysdeps/unix/bsd/tcgetattr.c\n+++ b/sysdeps/unix/bsd/tcgetattr.c\n@@ -35,4 +35,5 @@ __tcgetattr (int fd, struct termios *termios_p)\n return __ioctl (fd, TIOCGETA, termios_p);\n }\n \n+libc_hidden_def (__tcgetattr)\n weak_alias (__tcgetattr, tcgetattr)\ndiff --git a/sysdeps/unix/sysv/linux/tcgetattr.c b/sysdeps/unix/sysv/linux/tcgetattr.c\nindex b1d73d042a..99a59b6cd9 100644\n--- a/sysdeps/unix/sysv/linux/tcgetattr.c\n+++ b/sysdeps/unix/sysv/linux/tcgetattr.c\n@@ -76,4 +76,5 @@ __tcgetattr (int fd, struct termios *termios_p)\n return retval;\n }\n \n+libc_hidden_def (__tcgetattr)\n weak_alias (__tcgetattr, tcgetattr)\ndiff --git a/termios/tcgetattr.c b/termios/tcgetattr.c\nindex a5c076b1b0..12a56dd30f 100644\n--- a/termios/tcgetattr.c\n+++ b/termios/tcgetattr.c\n@@ -39,4 +39,5 @@ __tcgetattr (int fd, struct termios *termios_p)\n }\n stub_warning (tcgetattr)\n \n+libc_hidden_def (__tcgetattr)\n weak_alias (__tcgetattr, tcgetattr)\n","prefixes":["48/58"]}