{"id":808908,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808908/?format=json","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.0/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180029.9527-43-hjl.tools@gmail.com>","date":"2017-09-01T18:00:13","name":"[42/58] Hide internal __ifreq function [BZ #18822]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"867b47feb9c346d6038646eb47f59051d970bccf","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/1.0/people/4387/?format=json","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-43-hjl.tools@gmail.com/mbox/","series":[{"id":1088,"url":"http://patchwork.ozlabs.org/api/1.0/series/1088/?format=json","date":"2017-09-01T18:00:21","name":"Hide internal functions in libc.so","version":1,"mbox":"http://patchwork.ozlabs.org/series/1088/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808908/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84099-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"ean/meie\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkS1W6p9fz9s8J\n\tfor ;\n\tSat, 2 Sep 2017 04:09:19 +1000 (AEST)","(qmail 91016 invoked by alias); 1 Sep 2017 18:01:24 -0000","(qmail 90280 invoked by uid 89); 1 Sep 2017 18:01:18 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=IfH89md/SjBRxavuF6KcQcEGiJFe3xb\n\tAfmiKHWzVg7MCdrxPrlBBq81cPiEEqjfnGN4J0BxkpUROn+WungB3QrCF8/RsqGz\n\t3uxND6UbLs2wTQvngeFlFW8A5uDbNPlXcDX6elQaQpprkCiwvTZ2i4VcCXJzsUW0\n\t7FVkwpCcLwIY=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=hRxbQURsP0J3y11N2j/t8S2qG+k=; b=ean/m\n\teiePAXD+HJ5xdkSvToxQKGrfyCaXxenK/yAWk1/E31vEeamVn2DVICAQ/8EkI6qq\n\tnT98alnOktg1oOD4faEzwtk+yFQkT9jR5eTNzdVDWPqQKvGKQ2fmCCMPN/2Y/waw\n\ttIyUZQ65L7pu4PXnwxtwpSBJ5jGop448pMqT/Q=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3,\n\tSPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=H*m:gmail","X-HELO":"mga02.intel.com","X-ExtLoop1":"1","From":"\"H.J. Lu\" ","To":"libc-alpha@sourceware.org","Subject":"[PATCH 42/58] Hide internal __ifreq function [BZ #18822]","Date":"Fri, 1 Sep 2017 11:00:13 -0700","Message-Id":"<20170901180029.9527-43-hjl.tools@gmail.com>","In-Reply-To":"<20170901180029.9527-1-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>"},"content":"Hide internal __ifreq function to allow direct access within libc.so and\nlibc.a without using GOT nor PLT.\n\n\t[BZ #18822]\n\t* include/ifreq.h: New file.\n\t* sysdeps/generic/ifreq.h (__if_nextreq): Removed.\n\t(__ifreq): Likewise.\n\t* sysdeps/mach/hurd/ifreq.h (__if_nextreq): Removed.\n\t(__ifreq): Likewise.\n---\n include/ifreq.h | 14 ++++++++++++++\n sysdeps/generic/ifreq.h | 12 ------------\n sysdeps/mach/hurd/ifreq.h | 12 ------------\n 3 files changed, 14 insertions(+), 24 deletions(-)\n create mode 100644 include/ifreq.h","diff":"diff --git a/include/ifreq.h b/include/ifreq.h\nnew file mode 100644\nindex 0000000000..94e984c73c\n--- /dev/null\n+++ b/include/ifreq.h\n@@ -0,0 +1,14 @@\n+#include_next \n+\n+static inline struct ifreq *\n+__if_nextreq (struct ifreq *ifr)\n+{\n+#ifdef _HAVE_SA_LEN\n+ if (ifr->ifr_addr.sa_len > sizeof ifr->ifr_addr)\n+ return (struct ifreq *) ((char *) &ifr->ifr_addr + ifr->ifr_addr.sa_len);\n+#endif\n+ return ifr + 1;\n+}\n+\n+extern void __ifreq (struct ifreq **ifreqs, int *num_ifs, int sockfd)\n+ attribute_hidden;\ndiff --git a/sysdeps/generic/ifreq.h b/sysdeps/generic/ifreq.h\nindex 6ebd7c83f3..b39739debb 100644\n--- a/sysdeps/generic/ifreq.h\n+++ b/sysdeps/generic/ifreq.h\n@@ -23,18 +23,6 @@\n #include \n #include \n \n-static inline struct ifreq *\n-__if_nextreq (struct ifreq *ifr)\n-{\n-#ifdef _HAVE_SA_LEN\n- if (ifr->ifr_addr.sa_len > sizeof ifr->ifr_addr)\n- return (struct ifreq *) ((char *) &ifr->ifr_addr + ifr->ifr_addr.sa_len);\n-#endif\n- return ifr + 1;\n-}\n-\n-extern void __ifreq (struct ifreq **ifreqs, int *num_ifs, int sockfd);\n-\n \n static inline void\n __if_freereq (struct ifreq *ifreqs, int num_ifs)\ndiff --git a/sysdeps/mach/hurd/ifreq.h b/sysdeps/mach/hurd/ifreq.h\nindex eceeb7a2c3..3dd17f773d 100644\n--- a/sysdeps/mach/hurd/ifreq.h\n+++ b/sysdeps/mach/hurd/ifreq.h\n@@ -24,18 +24,6 @@\n #include \n #include \n \n-static inline struct ifreq *\n-__if_nextreq (struct ifreq *ifr)\n-{\n-#ifdef _HAVE_SA_LEN\n- if (ifr->ifr_addr.sa_len > sizeof ifr->ifr_addr)\n- return (struct ifreq *) ((char *) &ifr->ifr_addr + ifr->ifr_addr.sa_len);\n-#endif\n- return ifr + 1;\n-}\n-\n-extern void __ifreq (struct ifreq **ifreqs, int *num_ifs, int sockfd);\n-\n \n static inline void\n __if_freereq (struct ifreq *ifreqs, int num_ifs)\n","prefixes":["42/58"]}