{"id":808907,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808907/?format=json","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.0/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180029.9527-42-hjl.tools@gmail.com>","date":"2017-09-01T18:00:12","name":"[41/58] Hide internal idna functions [BZ #18822]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"df4efbbe33f56a0ba57f839310a4ca81cc6d792e","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/1.0/people/4387/?format=json","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-42-hjl.tools@gmail.com/mbox/","series":[{"id":1088,"url":"http://patchwork.ozlabs.org/api/1.0/series/1088/?format=json","date":"2017-09-01T18:00:21","name":"Hide internal functions in libc.so","version":1,"mbox":"http://patchwork.ozlabs.org/series/1088/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808907/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84094-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"s+I52Z11\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkS1M00cbz9s8J\n\tfor ;\n\tSat, 2 Sep 2017 04:09:10 +1000 (AEST)","(qmail 90770 invoked by alias); 1 Sep 2017 18:01:23 -0000","(qmail 90210 invoked by uid 89); 1 Sep 2017 18:01:17 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=qAtihYzzO+FkdzqMIzcKgxd6j85uwow\n\tfQMwOgg1/COnDu7D4+Uw919Swl8QEoxGSNfD+7mG3nsgX9iDZ4pYoQL1f+D/WK6t\n\t3fLDdP0nvD2A04rbFw9F8IMV9JnW7Tv+gukJpn2vz17xqWZRO2AT1MahdEIvmaVB\n\tgjwjMAJw4r0w=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=OMf5d6T5Tji/rrkjvsVNvCQ5EZU=; b=s+I52\n\tZ11/2V13AelNn62sP4fxb/DmnzcJozGucTxL0LWYTvfrBtpt3C6raL/DB1q/eqsD\n\tqKuOeaSGYAfuB9HxgImiXedUWHNzAa0ypvmfp3Avz/nmShncprLE72Jp+q6TWh+D\n\tAErFRw9+LcI/Dz/jO9nnDQVWyiDr+ALthtG9+M=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3,\n\tSPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=advised,\n\tH*m:gmail","X-HELO":"mga02.intel.com","X-ExtLoop1":"1","From":"\"H.J. Lu\" ","To":"libc-alpha@sourceware.org","Subject":"[PATCH 41/58] Hide internal idna functions [BZ #18822]","Date":"Fri, 1 Sep 2017 11:00:12 -0700","Message-Id":"<20170901180029.9527-42-hjl.tools@gmail.com>","In-Reply-To":"<20170901180029.9527-1-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>"},"content":"Hide internal idna functions to allow direct access within libc.so and\nlibc.a without using GOT nor PLT.\n\n\t[BZ #18822]\n\t* include/idna.h: New file.\n\t* inet/getnameinfo.c: Include instead of\n\t.\n\t(__idna_to_unicode_lzlz): Removed.\n\t* sysdeps/posix/getaddrinfo.c: Include instead of\n\t.\n\t(__idna_to_ascii_lz): Removed.\n\t(__idna_to_unicode_lzlz): Likewise.\n---\n include/idna.h | 8 ++++++++\n inet/getnameinfo.c | 4 +---\n sysdeps/posix/getaddrinfo.c | 5 +----\n 3 files changed, 10 insertions(+), 7 deletions(-)\n create mode 100644 include/idna.h","diff":"diff --git a/include/idna.h b/include/idna.h\nnew file mode 100644\nindex 0000000000..dcb271d575\n--- /dev/null\n+++ b/include/idna.h\n@@ -0,0 +1,8 @@\n+#ifndef _IDNA_H\n+#include \n+\n+extern __typeof (idna_to_ascii_lz) __idna_to_ascii_lz attribute_hidden;\n+extern __typeof (idna_to_unicode_lzlz ) __idna_to_unicode_lzlz\n+ attribute_hidden;\n+\n+#endif\ndiff --git a/inet/getnameinfo.c b/inet/getnameinfo.c\nindex b41e555f3c..292e087362 100644\n--- a/inet/getnameinfo.c\n+++ b/inet/getnameinfo.c\n@@ -73,9 +73,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n #include \n \n #ifdef HAVE_LIBIDN\n-# include \n-extern int __idna_to_unicode_lzlz (const char *input, char **output,\n-\t\t\t\t int flags);\n+# include \n #endif\n \n #ifndef min\ndiff --git a/sysdeps/posix/getaddrinfo.c b/sysdeps/posix/getaddrinfo.c\nindex ce099bdf9c..c58d54dff5 100644\n--- a/sysdeps/posix/getaddrinfo.c\n+++ b/sysdeps/posix/getaddrinfo.c\n@@ -86,10 +86,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n #include \n \n #ifdef HAVE_LIBIDN\n-extern int __idna_to_ascii_lz (const char *input, char **output, int flags);\n-extern int __idna_to_unicode_lzlz (const char *input, char **output,\n-\t\t\t\t int flags);\n-# include \n+# include \n #endif\n \n struct gaih_service\n","prefixes":["41/58"]}