{"id":808896,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808896/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180340.30009-9-eblake@redhat.com>","date":"2017-09-01T18:03:19","name":"[v6,08/29] libqtest: Let socket_send() compute length","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a9cc5a26355cf6fd11c28f2751ef1d380d601725","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/1.0/people/6591/?format=json","name":"Eric Blake","email":"eblake@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901180340.30009-9-eblake@redhat.com/mbox/","series":[{"id":1089,"url":"http://patchwork.ozlabs.org/api/1.0/series/1089/?format=json","date":"2017-09-01T18:03:12","name":"Preliminary libqtest cleanups","version":6,"mbox":"http://patchwork.ozlabs.org/series/1089/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808896/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRzd5D5Sz9t2x\n\tfor ;\n\tSat, 2 Sep 2017 04:07:41 +1000 (AEST)","from localhost ([::1]:53097 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnqLz-0001l7-5w\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 14:07:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55791)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnqIV-00078p-4k\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:04:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnqIP-0001Z7-Eo\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:04:02 -0400","from mx1.redhat.com ([209.132.183.28]:53634)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnqIP-0001YT-9y\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:03:57 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5EFF3883DE\n\tfor ; Fri, 1 Sep 2017 18:03:56 +0000 (UTC)","from red.redhat.com (ovpn-121-149.rdu2.redhat.com [10.10.121.149])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 93229627DE;\n\tFri, 1 Sep 2017 18:03:55 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5EFF3883DE","From":"Eric Blake ","To":"qemu-devel@nongnu.org","Date":"Fri, 1 Sep 2017 13:03:19 -0500","Message-Id":"<20170901180340.30009-9-eblake@redhat.com>","In-Reply-To":"<20170901180340.30009-1-eblake@redhat.com>","References":"<20170901180340.30009-1-eblake@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tFri, 01 Sep 2017 18:03:56 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v6 08/29] libqtest: Let socket_send() compute\n\tlength","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Rather than make multiple callers call strlen(), it's easier if\nsocket_send() itself can compute a length via strlen() if none\nwas provided (caller passes -1). Callers that can get at the\nlength more efficiently are left that way.\n\nSigned-off-by: Eric Blake \n---\n tests/libqtest.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/tests/libqtest.c b/tests/libqtest.c\nindex 3f956f09fc..a6ce21d7f9 100644\n--- a/tests/libqtest.c\n+++ b/tests/libqtest.c\n@@ -251,10 +251,13 @@ void qtest_quit(QTestState *s)\n g_free(s);\n }\n\n-static void socket_send(int fd, const char *buf, size_t size)\n+static void socket_send(int fd, const char *buf, ssize_t size)\n {\n size_t offset;\n\n+ if (size < 0) {\n+ size = strlen(buf);\n+ }\n offset = 0;\n while (offset < size) {\n ssize_t len;\n@@ -274,9 +277,8 @@ static void socket_send(int fd, const char *buf, size_t size)\n static void socket_sendf(int fd, const char *fmt, va_list ap)\n {\n gchar *str = g_strdup_vprintf(fmt, ap);\n- size_t size = strlen(str);\n\n- socket_send(fd, str, size);\n+ socket_send(fd, str, -1);\n g_free(str);\n }\n\n@@ -858,7 +860,7 @@ void qtest_bufwrite(QTestState *s, uint64_t addr, const void *data, size_t size)\n\n bdata = g_base64_encode(data, size);\n qtest_sendf(s, \"b64write 0x%\" PRIx64 \" 0x%zx \", addr, size);\n- socket_send(s->fd, bdata, strlen(bdata));\n+ socket_send(s->fd, bdata, -1);\n socket_send(s->fd, \"\\n\", 1);\n qtest_rsp(s, 0);\n g_free(bdata);\n","prefixes":["v6","08/29"]}