{"id":808895,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808895/?format=json","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.0/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180029.9527-33-hjl.tools@gmail.com>","date":"2017-09-01T18:00:03","name":"[32/58] Hide internal signal functions [BZ #18822]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4a5af6a8e46057712a593c4b6f335cbde7d58bae","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/1.0/people/4387/?format=json","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-33-hjl.tools@gmail.com/mbox/","series":[{"id":1088,"url":"http://patchwork.ozlabs.org/api/1.0/series/1088/?format=json","date":"2017-09-01T18:00:21","name":"Hide internal functions in libc.so","version":1,"mbox":"http://patchwork.ozlabs.org/series/1088/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808895/checks/","tags":{},"headers":{"Return-Path":"<libc-alpha-return-84084-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84084-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"IIC3oROS\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRzZ4bjJz9s3w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat,  2 Sep 2017 04:07:38 +1000 (AEST)","(qmail 88681 invoked by alias); 1 Sep 2017 18:01:09 -0000","(qmail 88615 invoked by uid 89); 1 Sep 2017 18:01:08 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=dk2ADrUO65ixzECYuVZtLK/EHicZXyb\n\tTC5sRlnVHjBI3aueF5cd+YJqfpQ/LiVekvWH6UQppA/1415g02mYT2dSmWcWyRcq\n\tcJyacYKpLkMEoJ56sE/XZV9oVqIEigKRQNZraBBo4f/eVjFYvK1H+oV6vJKcZaqm\n\twKVWaRvMGyxE=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=/ulASf8RolV1TjXzN0CbrMzwHrk=; b=IIC3o\n\tROSJi1Xe7iqgWG7+rKXzV9IXH+wAFD+UcSFumhbQ+yPE/bLOt+6MEDFER0ZBScSr\n\tu8OzfIGzV1eyIYwaElSuGamUiGfwnEehZWlmXtgI1DvJ61WhbrYvzk+WcjpKa+pf\n\tzVI/xsUkzHhWJY9JlkP5Aes4sweErM0J55Kztw=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=","X-HELO":"mga02.intel.com","X-ExtLoop1":"1","From":"\"H.J. Lu\" <hjl.tools@gmail.com>","To":"libc-alpha@sourceware.org","Subject":"[PATCH 32/58] Hide internal signal functions [BZ #18822]","Date":"Fri,  1 Sep 2017 11:00:03 -0700","Message-Id":"<20170901180029.9527-33-hjl.tools@gmail.com>","In-Reply-To":"<20170901180029.9527-1-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>"},"content":"Hide internal signal functions to allow direct access within libc.so and\nlibc.a without using GOT nor PLT.\n\n__GI___kill and __GI___sigaltstack are defined when syscalls.list is\nused to generate them.  Otherwise libc_hidden_def is needed explicitly.\n\n\t[BZ #18822]\n\t* include/signal.h (__kill): Add libc_hidden_proto.\n\t(__sigblock): Likewise.\n\t(__sigprocmask): Likewise.\n\t(__sigaltstack): Likewise.\n\t* signal/kill.c (__kill): Add libc_hidden_def.\n\t* signal/sigblock.c (__sigblock): Likewise.\n\t* signal/sigprocmask.c (__sigprocmask): Likewise.\n\t* sysdeps/mach/hurd/kill.c (__kill): Likewise.\n\t* sysdeps/mach/hurd/sigaltstack.c (__sigaltstack): Likewise.\n\t* sysdeps/mach/hurd/sigprocmask.c (__sigprocmask): Likewise.\n\t* sysdeps/posix/sigblock.c (__sigblock): Likewise.\n\t* sysdeps/unix/sysv/linux/alpha/sigprocmask.c (__sigprocmask):\n\tLikewise.\n\t* sysdeps/unix/sysv/linux/ia64/sigprocmask.c (__sigprocmask):\n\tLikewise.\n\t* sysdeps/unix/sysv/linux/s390/s390-64/sigprocmask.c\n\t(__sigprocmask): Likewise.\n\t* sysdeps/unix/sysv/linux/sigprocmask.c (__sigprocmask):\n\tLikewise.\n\t* /sysdeps/unix/sysv/linux/sparc/sparc64/sigprocmask.c\n\t(__sigprocmask): Likewise.\n\t* sysdeps/unix/sysv/linux/x86_64/sigprocmask.c (__sigprocmask):\n\tLikewise.\n---\n include/signal.h                                    | 4 ++++\n signal/kill.c                                       | 1 +\n signal/sigblock.c                                   | 1 +\n signal/sigprocmask.c                                | 1 +\n sysdeps/mach/hurd/kill.c                            | 1 +\n sysdeps/mach/hurd/sigaltstack.c                     | 1 +\n sysdeps/mach/hurd/sigprocmask.c                     | 1 +\n sysdeps/posix/sigblock.c                            | 1 +\n sysdeps/unix/sysv/linux/alpha/sigprocmask.c         | 1 +\n sysdeps/unix/sysv/linux/ia64/sigprocmask.c          | 1 +\n sysdeps/unix/sysv/linux/s390/s390-64/sigprocmask.c  | 1 +\n sysdeps/unix/sysv/linux/sigprocmask.c               | 1 +\n sysdeps/unix/sysv/linux/sparc/sparc64/sigprocmask.c | 1 +\n sysdeps/unix/sysv/linux/x86_64/sigprocmask.c        | 1 +\n 14 files changed, 17 insertions(+)","diff":"diff --git a/include/signal.h b/include/signal.h\nindex 61ad422dcb..7cbe64b8ad 100644\n--- a/include/signal.h\n+++ b/include/signal.h\n@@ -17,13 +17,16 @@ libc_hidden_proto (_sys_siglist)\n /* Now define the internal interfaces.  */\n extern __sighandler_t __bsd_signal (int __sig, __sighandler_t __handler);\n extern int __kill (__pid_t __pid, int __sig);\n+libc_hidden_proto (__kill)\n extern int __sigaction (int __sig, const struct sigaction *__restrict __act,\n \t\t\tstruct sigaction *__restrict __oact);\n libc_hidden_proto (__sigaction)\n extern int __sigblock (int __mask);\n+libc_hidden_proto (__sigblock)\n extern int __sigsetmask (int __mask);\n extern int __sigprocmask (int __how,\n \t\t\t  const sigset_t *__set, sigset_t *__oset);\n+libc_hidden_proto (__sigprocmask)\n extern int __sigsuspend (const sigset_t *__set);\n libc_hidden_proto (__sigsuspend)\n extern int __sigwait (const sigset_t *__set, int *__sig);\n@@ -40,6 +43,7 @@ extern int __sigreturn (struct sigcontext *__scp);\n #endif\n extern int __sigaltstack (const stack_t *__ss,\n \t\t\t  stack_t *__oss);\n+libc_hidden_proto (__sigaltstack)\n extern int __libc_sigaction (int sig, const struct sigaction *act,\n \t\t\t     struct sigaction *oact);\n libc_hidden_proto (__libc_sigaction)\ndiff --git a/signal/kill.c b/signal/kill.c\nindex c7591b10c1..66f85d127c 100644\n--- a/signal/kill.c\n+++ b/signal/kill.c\n@@ -30,4 +30,5 @@ __kill (int pid, int sig)\n }\n stub_warning (kill)\n \n+libc_hidden_def (__kill)\n weak_alias (__kill, kill)\ndiff --git a/signal/sigblock.c b/signal/sigblock.c\nindex a8be9dbde9..fca370a52d 100644\n--- a/signal/sigblock.c\n+++ b/signal/sigblock.c\n@@ -27,4 +27,5 @@ __sigblock (int mask)\n }\n stub_warning (sigblock)\n \n+libc_hidden_def (__sigblock)\n weak_alias (__sigblock, sigblock)\ndiff --git a/signal/sigprocmask.c b/signal/sigprocmask.c\nindex afcf5a116e..ca9bb556b8 100644\n--- a/signal/sigprocmask.c\n+++ b/signal/sigprocmask.c\n@@ -44,4 +44,5 @@ __sigprocmask (int how, const sigset_t *set, sigset_t *oset)\n    and we don't want warnings for every use of abort on\n    a system without safe signals.  */\n \n+libc_hidden_def (__sigprocmask)\n weak_alias (__sigprocmask, sigprocmask)\ndiff --git a/sysdeps/mach/hurd/kill.c b/sysdeps/mach/hurd/kill.c\nindex 2d556dd2ff..5360bb52c5 100644\n--- a/sysdeps/mach/hurd/kill.c\n+++ b/sysdeps/mach/hurd/kill.c\n@@ -146,4 +146,5 @@ __kill (pid_t pid, int sig)\n   return delivered ? 0 : __hurd_fail (err ?: ESRCH);\n }\n \n+libc_hidden_def (__kill)\n weak_alias (__kill, kill)\ndiff --git a/sysdeps/mach/hurd/sigaltstack.c b/sysdeps/mach/hurd/sigaltstack.c\nindex 4fba69e766..3fde510e23 100644\n--- a/sysdeps/mach/hurd/sigaltstack.c\n+++ b/sysdeps/mach/hurd/sigaltstack.c\n@@ -57,4 +57,5 @@ __sigaltstack (const stack_t *argss, stack_t *oss)\n \n   return 0;\n }\n+libc_hidden_def (__sigaltstack)\n weak_alias (__sigaltstack, sigaltstack)\ndiff --git a/sysdeps/mach/hurd/sigprocmask.c b/sysdeps/mach/hurd/sigprocmask.c\nindex a4ebe580ff..70b9a10a7b 100644\n--- a/sysdeps/mach/hurd/sigprocmask.c\n+++ b/sysdeps/mach/hurd/sigprocmask.c\n@@ -80,4 +80,5 @@ __sigprocmask (int how, const sigset_t *set, sigset_t *oset)\n   return 0;\n }\n \n+libc_hidden_def (__sigprocmask)\n weak_alias (__sigprocmask, sigprocmask)\ndiff --git a/sysdeps/posix/sigblock.c b/sysdeps/posix/sigblock.c\nindex 1f8686458b..ab59f2968f 100644\n--- a/sysdeps/posix/sigblock.c\n+++ b/sysdeps/posix/sigblock.c\n@@ -35,4 +35,5 @@ __sigblock (int mask)\n   return sigset_get_old_mask (&oset);\n }\n \n+libc_hidden_def (__sigblock)\n weak_alias (__sigblock, sigblock)\ndiff --git a/sysdeps/unix/sysv/linux/alpha/sigprocmask.c b/sysdeps/unix/sysv/linux/alpha/sigprocmask.c\nindex 39a07de475..ebec70cff0 100644\n--- a/sysdeps/unix/sysv/linux/alpha/sigprocmask.c\n+++ b/sysdeps/unix/sysv/linux/alpha/sigprocmask.c\n@@ -54,4 +54,5 @@ __sigprocmask (int how, const sigset_t *set, sigset_t *oset)\n   return 0;\n }\n \n+libc_hidden_def (__sigprocmask)\n weak_alias (__sigprocmask, sigprocmask);\ndiff --git a/sysdeps/unix/sysv/linux/ia64/sigprocmask.c b/sysdeps/unix/sysv/linux/ia64/sigprocmask.c\nindex 7e62438b03..920c5fd052 100644\n--- a/sysdeps/unix/sysv/linux/ia64/sigprocmask.c\n+++ b/sysdeps/unix/sysv/linux/ia64/sigprocmask.c\n@@ -36,4 +36,5 @@ __sigprocmask (int how, const sigset_t *set, sigset_t *oset)\n      real size of the user-level sigset_t.  */\n   return INLINE_SYSCALL (rt_sigprocmask, 4, how, set, oset, _NSIG / 8);\n }\n+libc_hidden_def (__sigprocmask)\n weak_alias (__sigprocmask, sigprocmask)\ndiff --git a/sysdeps/unix/sysv/linux/s390/s390-64/sigprocmask.c b/sysdeps/unix/sysv/linux/s390/s390-64/sigprocmask.c\nindex 4cbbc8e133..a8010e7f14 100644\n--- a/sysdeps/unix/sysv/linux/s390/s390-64/sigprocmask.c\n+++ b/sysdeps/unix/sysv/linux/s390/s390-64/sigprocmask.c\n@@ -34,4 +34,5 @@ __sigprocmask (int how, const sigset_t *set, sigset_t *oset)\n      real size of the user-level sigset_t.  */\n   return INLINE_SYSCALL (rt_sigprocmask, 4, how, set, oset, _NSIG / 8);\n }\n+libc_hidden_def (__sigprocmask)\n weak_alias (__sigprocmask, sigprocmask)\ndiff --git a/sysdeps/unix/sysv/linux/sigprocmask.c b/sysdeps/unix/sysv/linux/sigprocmask.c\nindex e39e5f6872..d0b8e049b2 100644\n--- a/sysdeps/unix/sysv/linux/sigprocmask.c\n+++ b/sysdeps/unix/sysv/linux/sigprocmask.c\n@@ -53,4 +53,5 @@ __sigprocmask (int how, const sigset_t *set, sigset_t *oset)\n \n   return INLINE_SYSCALL (rt_sigprocmask, 4, how, set, oset, _NSIG / 8);\n }\n+libc_hidden_def (__sigprocmask)\n weak_alias (__sigprocmask, sigprocmask)\ndiff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/sigprocmask.c b/sysdeps/unix/sysv/linux/sparc/sparc64/sigprocmask.c\nindex c2205d0044..ef7d7feb49 100644\n--- a/sysdeps/unix/sysv/linux/sparc/sparc64/sigprocmask.c\n+++ b/sysdeps/unix/sysv/linux/sparc/sparc64/sigprocmask.c\n@@ -30,4 +30,5 @@ __sigprocmask (int how, const sigset_t *set, sigset_t *oset)\n      real size of the user-level sigset_t.  */\n   return INLINE_SYSCALL (rt_sigprocmask, 4, how, set, oset, _NSIG / 8);\n }\n+libc_hidden_def (__sigprocmask)\n weak_alias (__sigprocmask, sigprocmask)\ndiff --git a/sysdeps/unix/sysv/linux/x86_64/sigprocmask.c b/sysdeps/unix/sysv/linux/x86_64/sigprocmask.c\nindex a87ad106ea..1610ddf47f 100644\n--- a/sysdeps/unix/sysv/linux/x86_64/sigprocmask.c\n+++ b/sysdeps/unix/sysv/linux/x86_64/sigprocmask.c\n@@ -35,4 +35,5 @@ __sigprocmask (int how, const sigset_t *set, sigset_t *oset)\n      real size of the user-level sigset_t.  */\n   return INLINE_SYSCALL (rt_sigprocmask, 4, how, set, oset, _NSIG / 8);\n }\n+libc_hidden_def (__sigprocmask)\n weak_alias (__sigprocmask, sigprocmask)\n","prefixes":["32/58"]}