{"id":808882,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808882/?format=json","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.0/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180029.9527-17-hjl.tools@gmail.com>","date":"2017-09-01T17:59:47","name":"[16/58] Mark internal getXXXbyYYY functions with attribute_hidden [BZ #18822]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d3f958c4db67d137c9b0a61caeffd9c2679389c2","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/1.0/people/4387/?format=json","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-17-hjl.tools@gmail.com/mbox/","series":[{"id":1088,"url":"http://patchwork.ozlabs.org/api/1.0/series/1088/?format=json","date":"2017-09-01T18:00:21","name":"Hide internal functions in libc.so","version":1,"mbox":"http://patchwork.ozlabs.org/series/1088/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808882/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84074-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"Nk5HoW4f\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRxr4Vzfz9s3w\n\tfor ;\n\tSat, 2 Sep 2017 04:06:07 +1000 (AEST)","(qmail 87339 invoked by alias); 1 Sep 2017 18:01:00 -0000","(qmail 87314 invoked by uid 89); 1 Sep 2017 18:01:00 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=OVVkeYJlxDFZ66kj9BH+ixTP5YtT/Vs\n\t/C6i0J8vljn8kO9BGFIQnOD8tuBXeDj84l20piFsIb4Qjps/7mBR1J8uo9p/30eN\n\tEItduJZqP3ccDLauhzrHf+DbOa+yiasb90KH0s6s8YITtDt8UGdaOnPZVYRjX5VB\n\tmlNt8kuTdEF0=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=/R/ziqcWNw+7wGgjMEJUe5glQIs=; b=Nk5Ho\n\tW4fxNYg0ap8kqleLXm4t3l00fAYSHsdjxqWd6Cn7nYTDTTfeFlq+T15nD3AkCQcv\n\tJdKH4IJz+pKGKGyYjym+JnxPbdpi0Floc9HpC7G6VR8MDHp7BE8LOrJqYhXwq/qv\n\tolnZ8ShMGjHu1xuXGMFVgSir9hR7VaVcTApn1Q=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=","X-HELO":"mga02.intel.com","X-ExtLoop1":"1","From":"\"H.J. Lu\" ","To":"libc-alpha@sourceware.org","Subject":"[PATCH 16/58] Mark internal getXXXbyYYY functions with\n\tattribute_hidden [BZ #18822]","Date":"Fri, 1 Sep 2017 10:59:47 -0700","Message-Id":"<20170901180029.9527-17-hjl.tools@gmail.com>","In-Reply-To":"<20170901180029.9527-1-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>"},"content":"Mark internal getXXXbyYYY functions with attribute_hidden to allow direct\naccess within libc.so and libc.a without using GOT nor PLT.\n\n\t[BZ #18822]\n\t* include/aliases.h (__getaliasbyname_r): Add attribute_hidden.\n\t* include/netdb.h (__gethostbyaddr_r): Likewise.\n\t(__gethostbyname_r): Likewise.\n\t(__gethostbyname2_r): Likewise.\n\t(__getnetbyaddr_r): Likewise.\n\t(__getnetbyname_r): Likewise.\n\t(__getservbyname_r): Likewise.\n\t(__getservbyport_r): Likewise.\n\t(__getprotobyname_r): Likewise.\n\t(__getprotobynumber_r): Likewise.\n\t(__getnetgrent_r): Likewise.\n\t* include/rpc/netdb.h (__getrpcbyname_r): Likewise.\n\t(__getrpcbynumber_r): Likewise.\n\t* nss/getXXbyYY.c (INTERNAL (REENTRANT_NAME)): Likewise.\n---\n include/aliases.h | 3 ++-\n include/netdb.h | 30 ++++++++++++++++++++----------\n include/rpc/netdb.h | 4 ++--\n nss/getXXbyYY.c | 3 ++-\n 4 files changed, 26 insertions(+), 14 deletions(-)","diff":"diff --git a/include/aliases.h b/include/aliases.h\nindex ece69ebe43..11b81d4d24 100644\n--- a/include/aliases.h\n+++ b/include/aliases.h\n@@ -14,7 +14,8 @@ extern int __old_getaliasent_r (struct aliasent *__restrict __result_buf,\n extern int __getaliasbyname_r (const char *__restrict __name,\n \t\t\t struct aliasent *__restrict __result_buf,\n \t\t\t char *__restrict __buffer, size_t __buflen,\n-\t\t\t struct aliasent **__restrict __result);\n+\t\t\t struct aliasent **__restrict __result)\n+ attribute_hidden;\n extern int __old_getaliasbyname_r (const char *__restrict __name,\n \t\t\t\t struct aliasent *__restrict __result_buf,\n \t\t\t\t char *__restrict __buffer, size_t __buflen,\ndiff --git a/include/netdb.h b/include/netdb.h\nindex d425a64506..e230b1f4fc 100644\n--- a/include/netdb.h\n+++ b/include/netdb.h\n@@ -43,7 +43,8 @@ extern int __gethostbyaddr_r (const void *__restrict __addr,\n \t\t\t struct hostent *__restrict __result_buf,\n \t\t\t char *__restrict __buf, size_t __buflen,\n \t\t\t struct hostent **__restrict __result,\n-\t\t\t int *__restrict __h_errnop);\n+\t\t\t int *__restrict __h_errnop)\n+ attribute_hidden;\n extern int __old_gethostbyaddr_r (const void *__restrict __addr,\n \t\t\t\t socklen_t __len, int __type,\n \t\t\t\t struct hostent *__restrict __result_buf,\n@@ -63,7 +64,8 @@ extern int __gethostbyname_r (const char *__restrict __name,\n \t\t\t struct hostent *__restrict __result_buf,\n \t\t\t char *__restrict __buf, size_t __buflen,\n \t\t\t struct hostent **__restrict __result,\n-\t\t\t int *__restrict __h_errnop);\n+\t\t\t int *__restrict __h_errnop)\n+ attribute_hidden;\n extern int __old_gethostbyname_r (const char *__restrict __name,\n \t\t\t\t struct hostent *__restrict __result_buf,\n \t\t\t\t char *__restrict __buf, size_t __buflen,\n@@ -74,7 +76,8 @@ extern int __gethostbyname2_r (const char *__restrict __name, int __af,\n \t\t\t struct hostent *__restrict __result_buf,\n \t\t\t char *__restrict __buf, size_t __buflen,\n \t\t\t struct hostent **__restrict __result,\n-\t\t\t int *__restrict __h_errnop);\n+\t\t\t int *__restrict __h_errnop)\n+ attribute_hidden;\n extern int __old_gethostbyname2_r (const char *__restrict __name, int __af,\n \t\t\t\t struct hostent *__restrict __result_buf,\n \t\t\t\t char *__restrict __buf, size_t __buflen,\n@@ -101,7 +104,8 @@ extern int __getnetbyaddr_r (uint32_t __net, int __type,\n \t\t\t struct netent *__restrict __result_buf,\n \t\t\t char *__restrict __buf, size_t __buflen,\n \t\t\t struct netent **__restrict __result,\n-\t\t\t int *__restrict __h_errnop);\n+\t\t\t int *__restrict __h_errnop)\n+ attribute_hidden;\n extern int __old_getnetbyaddr_r (uint32_t __net, int __type,\n \t\t\t\t struct netent *__restrict __result_buf,\n \t\t\t\t char *__restrict __buf, size_t __buflen,\n@@ -112,7 +116,8 @@ extern int __getnetbyname_r (const char *__restrict __name,\n \t\t\t struct netent *__restrict __result_buf,\n \t\t\t char *__restrict __buf, size_t __buflen,\n \t\t\t struct netent **__restrict __result,\n-\t\t\t int *__restrict __h_errnop);\n+\t\t\t int *__restrict __h_errnop)\n+ attribute_hidden;\n extern int __old_getnetbyname_r (const char *__restrict __name,\n \t\t\t\t struct netent *__restrict __result_buf,\n \t\t\t\t char *__restrict __buf, size_t __buflen,\n@@ -131,7 +136,8 @@ extern int __getservbyname_r (const char *__restrict __name,\n \t\t\t const char *__restrict __proto,\n \t\t\t struct servent *__restrict __result_buf,\n \t\t\t char *__restrict __buf, size_t __buflen,\n-\t\t\t struct servent **__restrict __result);\n+\t\t\t struct servent **__restrict __result)\n+ attribute_hidden;\n extern int __old_getservbyname_r (const char *__restrict __name,\n \t\t\t\t const char *__restrict __proto,\n \t\t\t\t struct servent *__restrict __result_buf,\n@@ -142,7 +148,8 @@ extern int __getservbyport_r (int __port,\n \t\t\t const char *__restrict __proto,\n \t\t\t struct servent *__restrict __result_buf,\n \t\t\t char *__restrict __buf, size_t __buflen,\n-\t\t\t struct servent **__restrict __result);\n+\t\t\t struct servent **__restrict __result)\n+ attribute_hidden;\n extern int __old_getservbyport_r (int __port,\n \t\t\t\t const char *__restrict __proto,\n \t\t\t\t struct servent *__restrict __result_buf,\n@@ -160,7 +167,8 @@ extern int __old_getprotoent_r (struct protoent *__restrict __result_buf,\n extern int __getprotobyname_r (const char *__restrict __name,\n \t\t\t struct protoent *__restrict __result_buf,\n \t\t\t char *__restrict __buf, size_t __buflen,\n-\t\t\t struct protoent **__restrict __result);\n+\t\t\t struct protoent **__restrict __result)\n+ attribute_hidden;\n extern int __old_getprotobyname_r (const char *__restrict __name,\n \t\t\t\t struct protoent *__restrict __result_buf,\n \t\t\t\t char *__restrict __buf, size_t __buflen,\n@@ -169,7 +177,8 @@ extern int __old_getprotobyname_r (const char *__restrict __name,\n extern int __getprotobynumber_r (int __proto,\n \t\t\t\t struct protoent *__restrict __res_buf,\n \t\t\t\t char *__restrict __buf, size_t __buflen,\n-\t\t\t\t struct protoent **__restrict __result);\n+\t\t\t\t struct protoent **__restrict __result)\n+ attribute_hidden;\n extern int __old_getprotobynumber_r (int __proto,\n \t\t\t\t struct protoent *__restrict __res_buf,\n \t\t\t\t char *__restrict __buf, size_t __buflen,\n@@ -178,7 +187,8 @@ extern int __old_getprotobynumber_r (int __proto,\n extern int __getnetgrent_r (char **__restrict __hostp,\n \t\t\t char **__restrict __userp,\n \t\t\t char **__restrict __domainp,\n-\t\t\t char *__restrict __buffer, size_t __buflen);\n+\t\t\t char *__restrict __buffer, size_t __buflen)\n+ attribute_hidden;\n \n extern int ruserpass (const char *host, const char **aname,\n \t\t const char **apass);\ndiff --git a/include/rpc/netdb.h b/include/rpc/netdb.h\nindex 9b84668be7..eb75f3f58c 100644\n--- a/include/rpc/netdb.h\n+++ b/include/rpc/netdb.h\n@@ -5,7 +5,7 @@\n \n extern int __getrpcbyname_r (const char *__name, struct rpcent *__result_buf,\n \t\t\t char *__buffer, size_t __buflen,\n-\t\t\t struct rpcent **__result);\n+\t\t\t struct rpcent **__result) attribute_hidden;\n extern int __old_getrpcbyname_r (const char *__name,\n \t\t\t\t struct rpcent *__result_buf,\n \t\t\t\t char *__buffer, size_t __buflen,\n@@ -13,7 +13,7 @@ extern int __old_getrpcbyname_r (const char *__name,\n \n extern int __getrpcbynumber_r (int __number, struct rpcent *__result_buf,\n \t\t\t char *__buffer, size_t __buflen,\n-\t\t\t struct rpcent **__result);\n+\t\t\t struct rpcent **__result) attribute_hidden;\n extern int __old_getrpcbynumber_r (int __number, struct rpcent *__result_buf,\n \t\t\t\t char *__buffer, size_t __buflen,\n \t\t\t\t struct rpcent **__result);\ndiff --git a/nss/getXXbyYY.c b/nss/getXXbyYY.c\nindex a439b816f7..f420b34fb8 100644\n--- a/nss/getXXbyYY.c\n+++ b/nss/getXXbyYY.c\n@@ -79,7 +79,8 @@\n /* Prototype for reentrant version we use here. */\n extern int INTERNAL (REENTRANT_NAME) (ADD_PARAMS, LOOKUP_TYPE *resbuf,\n \t\t\t\t char *buffer, size_t buflen,\n-\t\t\t\t LOOKUP_TYPE **result H_ERRNO_PARM);\n+\t\t\t\t LOOKUP_TYPE **result H_ERRNO_PARM)\n+ attribute_hidden;\n \n /* We need to protect the dynamic buffer handling. */\n __libc_lock_define_initialized (static, lock);\n","prefixes":["16/58"]}