{"id":808879,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808879/?format=json","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.0/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180029.9527-22-hjl.tools@gmail.com>","date":"2017-09-01T17:59:52","name":"[21/58] Hide __readv and __writev [BZ #18822]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a1dfcfc83833b70ca9b6012f4e59011c3639a0d2","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/1.0/people/4387/?format=json","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-22-hjl.tools@gmail.com/mbox/","series":[{"id":1088,"url":"http://patchwork.ozlabs.org/api/1.0/series/1088/?format=json","date":"2017-09-01T18:00:21","name":"Hide internal functions in libc.so","version":1,"mbox":"http://patchwork.ozlabs.org/series/1088/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808879/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84072-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"D8Y2Dae0\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRxR3Dg9z9t2x\n\tfor ;\n\tSat, 2 Sep 2017 04:05:47 +1000 (AEST)","(qmail 87085 invoked by alias); 1 Sep 2017 18:01:00 -0000","(qmail 87051 invoked by uid 89); 1 Sep 2017 18:00:59 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=ZMSgAPrDpaHjugjHzLhkZwiqH1gmodi\n\tCVAVKnHMjCVUIxOEh0vq7UmAEFGITLs30d86cKKzzJxbncdqRd0U8iZVZAlgX0bi\n\tvoOymZNIEEX/X+aBNToMwFDVv/HxTtj2Nq+hI0VDrMJ3DpNRT71hlVkJdaNOzdPa\n\tqOVcdNMRNEXM=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=rEuF2zAl6czE/zPGbAL2Pog0BDQ=; b=D8Y2D\n\tae0urOa0cyrwOgNBA3X3L1MAaCdrWD0YUC8/h8VXxbGhcMKCZCiChaFT+ikoKou6\n\tp0jYrrGqqOlN+pvTkBD10OHLOkPKrSvgrmccmgFizX4mu8xkRDQiCOYB26EJBkQj\n\toQ6ZpKvSv+Rvd66yukrgsCDUatKc91aiF+grmI=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3,\n\tSPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=H*m:gmail","X-HELO":"mga02.intel.com","X-ExtLoop1":"1","From":"\"H.J. Lu\" ","To":"libc-alpha@sourceware.org","Subject":"[PATCH 21/58] Hide __readv and __writev [BZ #18822]","Date":"Fri, 1 Sep 2017 10:59:52 -0700","Message-Id":"<20170901180029.9527-22-hjl.tools@gmail.com>","In-Reply-To":"<20170901180029.9527-1-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>"},"content":"Hide internal __readv and __writev functions to allow direct access\nwithin libc.so and libc.a without using GOT nor PLT.\n\n\t[BZ #18822]\n\t* include/sys/uio.h (__readv): Add libc_hidden_proto.\n\t(__writev): Likewise.\n\t* misc/readv.c (__readv): Add libc_hidden_def.\n\t* misc/writev.c (__writev): Likewise.\n\t* sysdeps/posix/readv.c (__readv): Likewise.\n\t* sysdeps/posix/writev.c (__writev): Likewise.\n\t* sysdeps/unix/sysv/linux/readv.c: Include .\n\t(__readv): Likewise.\n\t* sysdeps/unix/sysv/linux/writev.c: Include .\n\t(__writev): Likewise.\n---\n include/sys/uio.h | 2 ++\n misc/readv.c | 1 +\n misc/writev.c | 1 +\n sysdeps/posix/readv.c | 1 +\n sysdeps/posix/writev.c | 1 +\n sysdeps/unix/sysv/linux/readv.c | 2 ++\n sysdeps/unix/sysv/linux/writev.c | 2 ++\n 7 files changed, 10 insertions(+)","diff":"diff --git a/include/sys/uio.h b/include/sys/uio.h\nindex 20860bfd82..204c4b906d 100644\n--- a/include/sys/uio.h\n+++ b/include/sys/uio.h\n@@ -5,8 +5,10 @@\n /* Now define the internal interfaces. */\n extern ssize_t __readv (int __fd, const struct iovec *__iovec,\n \t\t\tint __count);\n+libc_hidden_proto (__readv)\n extern ssize_t __writev (int __fd, const struct iovec *__iovec,\n \t\t\t int __count);\n+libc_hidden_proto (__writev)\n \n /* Used for p{read,write}{v64}v2 implementation. */\n libc_hidden_proto (preadv)\ndiff --git a/misc/readv.c b/misc/readv.c\nindex 064f88523c..9ad94d370a 100644\n--- a/misc/readv.c\n+++ b/misc/readv.c\n@@ -30,6 +30,7 @@ __readv (int fd, const struct iovec *vector, int count)\n __set_errno (ENOSYS);\n return -1;\n }\n+libc_hidden_def (__readv)\n weak_alias (__readv, readv)\n \n stub_warning (readv)\ndiff --git a/misc/writev.c b/misc/writev.c\nindex c8d222e04f..8bd2eddf1a 100644\n--- a/misc/writev.c\n+++ b/misc/writev.c\n@@ -30,6 +30,7 @@ __writev (int fd, const struct iovec *vector, int count)\n __set_errno (ENOSYS);\n return -1;\n }\n+libc_hidden_def (__writev)\n weak_alias (__writev, writev)\n \n stub_warning (writev)\ndiff --git a/sysdeps/posix/readv.c b/sysdeps/posix/readv.c\nindex 5b0c124e89..2875c76daf 100644\n--- a/sysdeps/posix/readv.c\n+++ b/sysdeps/posix/readv.c\n@@ -88,4 +88,5 @@ __readv (int fd, const struct iovec *vector, int count)\n \n return bytes_read;\n }\n+libc_hidden_def (__readv)\n weak_alias (__readv, readv)\ndiff --git a/sysdeps/posix/writev.c b/sysdeps/posix/writev.c\nindex 7ce1deb80f..89d463033a 100644\n--- a/sysdeps/posix/writev.c\n+++ b/sysdeps/posix/writev.c\n@@ -88,4 +88,5 @@ __writev (int fd, const struct iovec *vector, int count)\n \n return bytes_written;\n }\n+libc_hidden_def (__writev)\n weak_alias (__writev, writev)\ndiff --git a/sysdeps/unix/sysv/linux/readv.c b/sysdeps/unix/sysv/linux/readv.c\nindex 142a0a92a7..e4713008f1 100644\n--- a/sysdeps/unix/sysv/linux/readv.c\n+++ b/sysdeps/unix/sysv/linux/readv.c\n@@ -17,6 +17,7 @@\n . */\n \n #include \n+#include \n #include \n \n ssize_t\n@@ -24,4 +25,5 @@ __readv (int fd, const struct iovec *iov, int iovcnt)\n {\n return SYSCALL_CANCEL (readv, fd, iov, iovcnt);\n }\n+libc_hidden_def (__readv)\n weak_alias (__readv, readv)\ndiff --git a/sysdeps/unix/sysv/linux/writev.c b/sysdeps/unix/sysv/linux/writev.c\nindex 1b56cbb709..2495fd938a 100644\n--- a/sysdeps/unix/sysv/linux/writev.c\n+++ b/sysdeps/unix/sysv/linux/writev.c\n@@ -17,6 +17,7 @@\n . */\n \n #include \n+#include \n #include \n \n ssize_t\n@@ -24,4 +25,5 @@ __writev (int fd, const struct iovec *iov, int iovcnt)\n {\n return SYSCALL_CANCEL (writev, fd, iov, iovcnt);\n }\n+libc_hidden_def (__writev)\n weak_alias (__writev, writev)\n","prefixes":["21/58"]}