{"id":808875,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808875/?format=json","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.0/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180029.9527-14-hjl.tools@gmail.com>","date":"2017-09-01T17:59:44","name":"[13/58] Mark internal statfs functions with attribute_hidden [BZ #18822]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"121f5094282bcbf8138fde7852cab62deb2536cc","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/1.0/people/4387/?format=json","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-14-hjl.tools@gmail.com/mbox/","series":[{"id":1088,"url":"http://patchwork.ozlabs.org/api/1.0/series/1088/?format=json","date":"2017-09-01T18:00:21","name":"Hide internal functions in libc.so","version":1,"mbox":"http://patchwork.ozlabs.org/series/1088/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808875/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84068-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"P97dIAn4\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRwc6rGdz9s3w\n\tfor ;\n\tSat, 2 Sep 2017 04:05:04 +1000 (AEST)","(qmail 86298 invoked by alias); 1 Sep 2017 18:00:55 -0000","(qmail 86196 invoked by uid 89); 1 Sep 2017 18:00:55 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=nkwg8vH9NzCia9jVhMHNs3UEo7qsxiA\n\t6RwU9odaLEGl7CWoGBPIg4iietS1X2Q1MorGAdZHwK4Czc7Is+lO/bz+M0CXJuYN\n\t+dv41Mx4Oc2GHRu6GMpQWw90jBlBT4xpeqrQkB5+mqDvTQ+zgUbUDQkSHMjd8PkE\n\tSohOX/tt0quw=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=fVKBTEen0d3L23Ua5tw+2gek6Bk=; b=P97dI\n\tAn4ui/3s1dCXZtvcvjEMGohBTmy6E/+S8xERJF0ZPWZJodHq4+Xmphjjo9r7oFYA\n\t8vGU7PncjjHBHPRhCOiSh5Pp6fR5YCy/PMkosMLGQLp4s0fXFF1ckugLML0d7Xkn\n\tI/hLcHPeA9zA9/xSjgpSSAWAZu0C+ROEFM36GQ=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3,\n\tSPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=H*m:gmail","X-HELO":"mga02.intel.com","X-ExtLoop1":"1","From":"\"H.J. Lu\" ","To":"libc-alpha@sourceware.org","Subject":"[PATCH 13/58] Mark internal statfs functions with attribute_hidden\n\t[BZ #18822]","Date":"Fri, 1 Sep 2017 10:59:44 -0700","Message-Id":"<20170901180029.9527-14-hjl.tools@gmail.com>","In-Reply-To":"<20170901180029.9527-1-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>"},"content":"Mark internal statfs functions with attribute_hidden to allow direct\naccess within libc.so and libc.a without using GOT nor PLT.\n\n\t[BZ #18822]\n\t* include/sys/statfs.h (__fstatfs): Add attribute_hidden.\n\t(__statfs64): Likewise.\n\t(__fstatfs64): Likewise.\n\t* include/sys/statvfs.h (__statvfs64): Likewise.\n\t(__fstatvfs64): Likewise.\n\t* sysdeps/unix/sysv/linux/pathconf.h (__statfs_link_max): Likewise.\n\t(__statfs_filesize_max): Likewise.\n\t(__statfs_symlinks): Likewise.\n\t(__statfs_chown_restricted): Likewise.\n---\n include/sys/statfs.h | 9 ++++++---\n include/sys/statvfs.h | 6 ++++--\n sysdeps/unix/sysv/linux/pathconf.h | 12 ++++++++----\n 3 files changed, 18 insertions(+), 9 deletions(-)","diff":"diff --git a/include/sys/statfs.h b/include/sys/statfs.h\nindex 3fac4a3490..8a9f5a7b3b 100644\n--- a/include/sys/statfs.h\n+++ b/include/sys/statfs.h\n@@ -6,9 +6,12 @@\n /* Now define the internal interfaces. */\n extern int __statfs (const char *__file, struct statfs *__buf);\n libc_hidden_proto (__statfs)\n-extern int __fstatfs (int __fildes, struct statfs *__buf);\n-extern int __statfs64 (const char *__file, struct statfs64 *__buf);\n-extern int __fstatfs64 (int __fildes, struct statfs64 *__buf);\n+extern int __fstatfs (int __fildes, struct statfs *__buf)\n+ attribute_hidden;\n+extern int __statfs64 (const char *__file, struct statfs64 *__buf)\n+ attribute_hidden;\n+extern int __fstatfs64 (int __fildes, struct statfs64 *__buf)\n+ attribute_hidden;\n \n # endif /* !_ISOMAC */\n #endif\ndiff --git a/include/sys/statvfs.h b/include/sys/statvfs.h\nindex fa3045386d..4cd1977c35 100644\n--- a/include/sys/statvfs.h\n+++ b/include/sys/statvfs.h\n@@ -3,8 +3,10 @@\n \n #ifndef _ISOMAC\n /* Now define the internal interfaces. */\n-extern int __statvfs64 (const char *__file, struct statvfs64 *__buf);\n-extern int __fstatvfs64 (int __fildes, struct statvfs64 *__buf);\n+extern int __statvfs64 (const char *__file, struct statvfs64 *__buf)\n+ attribute_hidden;\n+extern int __fstatvfs64 (int __fildes, struct statvfs64 *__buf)\n+ attribute_hidden;\n \n libc_hidden_proto (statvfs)\n libc_hidden_proto (fstatvfs)\ndiff --git a/sysdeps/unix/sysv/linux/pathconf.h b/sysdeps/unix/sysv/linux/pathconf.h\nindex 5de2915f40..b9de04f268 100644\n--- a/sysdeps/unix/sysv/linux/pathconf.h\n+++ b/sysdeps/unix/sysv/linux/pathconf.h\n@@ -24,17 +24,21 @@\n /* Used like: return __statfs_link_max (__statfs (name, &buf), &buf,\n \t\t\t\t\tname, -1); */\n extern long int __statfs_link_max (int result, const struct statfs *fsbuf,\n-\t\t\t\t const char *file, int fd);\n+\t\t\t\t const char *file, int fd)\n+ attribute_hidden;\n \n \n /* Used like: return __statfs_filesize_max (__statfs (name, &buf), &buf); */\n-extern long int __statfs_filesize_max (int result, const struct statfs *fsbuf);\n+extern long int __statfs_filesize_max (int result, const struct statfs *fsbuf)\n+ attribute_hidden;\n \n \n /* Used like: return __statfs_link_max (__statfs (name, &buf), &buf); */\n-extern long int __statfs_symlinks (int result, const struct statfs *fsbuf);\n+extern long int __statfs_symlinks (int result, const struct statfs *fsbuf)\n+ attribute_hidden;\n \n \n /* Used like: return __statfs_chown_restricted (__statfs (name, &buf), &buf);*/\n extern long int __statfs_chown_restricted (int result,\n-\t\t\t\t\t const struct statfs *fsbuf);\n+\t\t\t\t\t const struct statfs *fsbuf)\n+ attribute_hidden;\n","prefixes":["13/58"]}