{"id":808874,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808874/?format=json","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.0/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180029.9527-13-hjl.tools@gmail.com>","date":"2017-09-01T17:59:43","name":"[12/58] Mark internal time functions with attribute_hidden [BZ #18822]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fc8c5d78f9b06bd74e4ae731705463957c27c9b6","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/1.0/people/4387/?format=json","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-13-hjl.tools@gmail.com/mbox/","series":[{"id":1088,"url":"http://patchwork.ozlabs.org/api/1.0/series/1088/?format=json","date":"2017-09-01T18:00:21","name":"Hide internal functions in libc.so","version":1,"mbox":"http://patchwork.ozlabs.org/series/1088/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808874/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84067-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"sC1OzSzB\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRwS49Ptz9s3w\n\tfor ;\n\tSat, 2 Sep 2017 04:04:56 +1000 (AEST)","(qmail 86268 invoked by alias); 1 Sep 2017 18:00:55 -0000","(qmail 86180 invoked by uid 89); 1 Sep 2017 18:00:55 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=gkxrms/S8mq7Adv0fOv+irPcGRbfh4F\n\tub3Ip6pwcMIjkzrm1jdqW1XXtCRhTKXa2mcd5sQ+KcK8TiyLKG85JZptiQlQQk61\n\tvCs/Bp0nB9ncZDTpck5WneyKihIGKVDxV4M15kUP56SuFJyF41LJz3Kh0aU2dDJ8\n\tRNZhzZs7l1xQ=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=elAPILc1puGj4P8876B+AvYo5Ok=; b=sC1Oz\n\tSzBRNijLgytOHfkz15xgNZeBVGvXd7XxPy7x0hVZ+5bt7hLp6vYd6tPax02j8jMx\n\t5vgD2QIw8F9ISbi4gAovJBzzrLnt46YWU391w/5VnP/0sKWd2b2MtTHvEMrOi6t5\n\tAjiaD3WOgIOZdrDSES2lB8F3Eumi5OXmpNRaUQ=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3,\n\tSPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=H*m:gmail","X-HELO":"mga02.intel.com","X-ExtLoop1":"1","From":"\"H.J. Lu\" ","To":"libc-alpha@sourceware.org","Subject":"[PATCH 12/58] Mark internal time functions with attribute_hidden\n\t[BZ #18822]","Date":"Fri, 1 Sep 2017 10:59:43 -0700","Message-Id":"<20170901180029.9527-13-hjl.tools@gmail.com>","In-Reply-To":"<20170901180029.9527-1-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>"},"content":"Mark internal time functions with attribute_hidden to allow direct\naccess within libc.so and libc.a without using GOT nor PLT.\n\n\t[BZ #18822]\n\t* include/time.h (__tzstring): Add attribute_hidden.\n\t(__tzfile_read): Likewise.\n\t(__tzfile_compute): Likewise.\n\t(__tzfile_default): Likewise.\n\t(__tzset_parse_tz): Likewise.\n\t(__offtime): Likewise.\n\t(__asctime_r): Likewise.\n\t(__tzset): Likewise.\n\t(__tz_convert): Likewise.\n\t(__getdate_r): Likewise.\n\t(__getclktck): Likewise.\n---\n include/time.h | 26 +++++++++++++++-----------\n 1 file changed, 15 insertions(+), 11 deletions(-)","diff":"diff --git a/include/time.h b/include/time.h\nindex e8c07bbfea..aab26d7768 100644\n--- a/include/time.h\n+++ b/include/time.h\n@@ -33,18 +33,19 @@ extern const unsigned short int __mon_yday[2][13] attribute_hidden;\n extern struct tm _tmbuf attribute_hidden;\n \n /* Defined in tzset.c. */\n-extern char *__tzstring (const char *string);\n+extern char *__tzstring (const char *string) attribute_hidden;\n \n extern int __use_tzfile attribute_hidden;\n \n extern void __tzfile_read (const char *file, size_t extra,\n-\t\t\t char **extrap);\n+\t\t\t char **extrap) attribute_hidden;\n extern void __tzfile_compute (time_t timer, int use_localtime,\n \t\t\t long int *leap_correct, int *leap_hit,\n-\t\t\t struct tm *tp);\n+\t\t\t struct tm *tp) attribute_hidden;\n extern void __tzfile_default (const char *std, const char *dst,\n-\t\t\t long int stdoff, long int dstoff);\n-extern void __tzset_parse_tz (const char *tz);\n+\t\t\t long int stdoff, long int dstoff)\n+ attribute_hidden;\n+extern void __tzset_parse_tz (const char *tz) attribute_hidden;\n extern void __tz_compute (time_t timer, struct tm *tm, int use_localtime)\n __THROW attribute_hidden;\n \n@@ -68,22 +69,25 @@ libc_hidden_proto (__gmtime_r)\n Return nonzero if successful. */\n extern int __offtime (const time_t *__timer,\n \t\t long int __offset,\n-\t\t struct tm *__tp);\n+\t\t struct tm *__tp) attribute_hidden;\n \n-extern char *__asctime_r (const struct tm *__tp, char *__buf);\n-extern void __tzset (void);\n+extern char *__asctime_r (const struct tm *__tp, char *__buf)\n+ attribute_hidden;\n+extern void __tzset (void) attribute_hidden;\n \n /* Prototype for the internal function to get information based on TZ. */\n-extern struct tm *__tz_convert (const time_t *timer, int use_localtime, struct tm *tp);\n+extern struct tm *__tz_convert (const time_t *timer, int use_localtime,\n+\t\t\t\tstruct tm *tp) attribute_hidden;\n \n extern int __nanosleep (const struct timespec *__requested_time,\n \t\t\tstruct timespec *__remaining);\n hidden_proto (__nanosleep)\n-extern int __getdate_r (const char *__string, struct tm *__resbufp);\n+extern int __getdate_r (const char *__string, struct tm *__resbufp)\n+ attribute_hidden;\n \n \n /* Determine CLK_TCK value. */\n-extern int __getclktck (void);\n+extern int __getclktck (void) attribute_hidden;\n \n \n /* strptime support. */\n","prefixes":["12/58"]}