{"id":808861,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808861/?format=json","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.0/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180029.9527-5-hjl.tools@gmail.com>","date":"2017-09-01T17:59:35","name":"[04/58] Mark ____wcsto*_l_internal functions with attribute_hidden [BZ #18822]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4a105e585c67539b13cc9d897e2c458f862df878","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/1.0/people/4387/?format=json","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-5-hjl.tools@gmail.com/mbox/","series":[{"id":1088,"url":"http://patchwork.ozlabs.org/api/1.0/series/1088/?format=json","date":"2017-09-01T18:00:21","name":"Hide internal functions in libc.so","version":1,"mbox":"http://patchwork.ozlabs.org/series/1088/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808861/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84058-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"DXQ/yyvk\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRtn58N5z9s7M\n\tfor ;\n\tSat, 2 Sep 2017 04:03:29 +1000 (AEST)","(qmail 85061 invoked by alias); 1 Sep 2017 18:00:50 -0000","(qmail 84890 invoked by uid 89); 1 Sep 2017 18:00:50 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=JplYSZ7BJB7s+2kbASpPKwY0GRBBxX6\n\t1mHGMObuG/MUKDi99itwNEh+RjHmqvkZoK3MtIgoAJMPxd+LlnS/2e4A+BSuZpZV\n\tJtZaEFpi+HkaiJf7IcJ7/GVFWLGiEsSEDDJOR94Bl8Q8mXQHNGsRDBhKTNE4dW8Q\n\toxVj2I17D1gs=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=4rmISyKwNvbCCbI58wWt0o1nR1I=; b=DXQ/y\n\tyvkyngMwuJLhHhvCLFo3OINhH0BTYwiOEA4WyrHdjrMjpRHGbMGnwqdxm6pI7ROB\n\tMDRzJKDxxFnw5pwpmEFankpLz3h2yK4FgiRHRv0wgP/AaNclt/zc8BM4n5+cPhEe\n\t6BUMv/uZJ3lFUmJ51MWBcDGqXnkdaQlBHISS90=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=","X-HELO":"mga02.intel.com","X-ExtLoop1":"1","From":"\"H.J. Lu\" ","To":"libc-alpha@sourceware.org","Subject":"[PATCH 04/58] Mark ____wcsto*_l_internal functions with\n\tattribute_hidden [BZ #18822]","Date":"Fri, 1 Sep 2017 10:59:35 -0700","Message-Id":"<20170901180029.9527-5-hjl.tools@gmail.com>","In-Reply-To":"<20170901180029.9527-1-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>"},"content":"Mark ____wcsto*_l_internal functions with attribute_hidden to allow\ndirect access to them within libc.so and libc.a without using GOT nor\nPLT.\n\n\t[BZ #18822]\n\t* include/wchar.h (____wcstof_l_internal): New prototype.\n\t(____wcstod_l_internal): Likewise.\n\t(____wcstold_l_internal): Likewise.\n\t(____wcstol_l_internal): Likewise.\n\t(____wcstoul_l_internal): Likewise.\n\t(____wcstoll_l_internal): Likewise.\n\t(____wcstoull_l_internal): Likewise.\n\t(____wcstof128_l_internal): Likewise.\n\t* sysdeps/ieee754/float128/wcstof128.c\n\t(____wcstof128_l_internal): Removed.\n\t* sysdeps/ieee754/float128/wcstof128_l.c\n\t(____wcstof128_l_internal): Likewise.\n\t* wcsmbs/wcstod.c (____wcstod_l_internal): Likewise.\n\t* wcsmbs/wcstod_l.c (____wcstod_l_internal): Likewise.\n\t* wcsmbs/wcstof.c (____wcstof_l_internal): Likewise.\n\t* wcsmbs/wcstof_l.c (____wcstof_l_internal): Likewise.\n\t* wcsmbs/wcstol_l.c (____wcstol_l_internal): Likewise.\n\t* wcsmbs/wcstold.c (____wcstold_l_internal): Likewise.\n\t* wcsmbs/wcstold_l.c (____wcstold_l_internal): Likewise.\n\t* wcsmbs/wcstoll_l.c (____wcstoll_l_internal): Likewise.\n\t* wcsmbs/wcstoul_l.c (____wcstoul_l_internal): Likewise.\n\t* wcsmbs/wcstoull_l.c (____wcstoull_l_internal): Likewise.\n---\n include/wchar.h | 23 +++++++++++++++++++++++\n sysdeps/ieee754/float128/wcstof128.c | 3 ---\n sysdeps/ieee754/float128/wcstof128_l.c | 3 ---\n wcsmbs/wcstod.c | 3 ---\n wcsmbs/wcstod_l.c | 3 ---\n wcsmbs/wcstof.c | 3 ---\n wcsmbs/wcstof_l.c | 3 ---\n wcsmbs/wcstol_l.c | 3 ---\n wcsmbs/wcstold.c | 3 ---\n wcsmbs/wcstold_l.c | 3 ---\n wcsmbs/wcstoll_l.c | 3 ---\n wcsmbs/wcstoul_l.c | 3 ---\n wcsmbs/wcstoull_l.c | 4 ----\n 13 files changed, 23 insertions(+), 37 deletions(-)","diff":"diff --git a/include/wchar.h b/include/wchar.h\nindex 7bf042c235..eb472daefb 100644\n--- a/include/wchar.h\n+++ b/include/wchar.h\n@@ -70,6 +70,26 @@ libc_hidden_proto (wcstoll)\n libc_hidden_proto (wcstoul)\n libc_hidden_proto (wcstoull)\n \n+extern float ____wcstof_l_internal (const wchar_t *, wchar_t **, int,\n+\t\t\t\t locale_t) attribute_hidden;\n+extern double ____wcstod_l_internal (const wchar_t *, wchar_t **, int,\n+\t\t\t\t locale_t) attribute_hidden;\n+extern long double ____wcstold_l_internal (const wchar_t *, wchar_t **,\n+\t\t\t\t\t int, locale_t) attribute_hidden;\n+extern long int ____wcstol_l_internal (const wchar_t *, wchar_t **, int,\n+\t\t\t\t int, locale_t) attribute_hidden;\n+extern unsigned long int ____wcstoul_l_internal (const wchar_t *,\n+\t\t\t\t\t\t wchar_t **,\n+\t\t\t\t\t\t int, int, locale_t)\n+ attribute_hidden;\n+extern long long int ____wcstoll_l_internal (const wchar_t *, wchar_t **,\n+\t\t\t\t\t int, int, locale_t)\n+ attribute_hidden;\n+extern unsigned long long int ____wcstoull_l_internal (const wchar_t *,\n+\t\t\t\t\t\t wchar_t **, int, int,\n+\t\t\t\t\t\t locale_t)\n+ attribute_hidden;\n+\n #if __HAVE_DISTINCT_FLOAT128\n extern __typeof (wcstof128_l) __wcstof128_l;\n libc_hidden_proto (__wcstof128_l)\n@@ -77,6 +97,9 @@ extern _Float128 __wcstof128_internal (const wchar_t *__restrict __nptr,\n \t\t\t\t wchar_t **__restrict __endptr,\n \t\t\t\t int __group) __THROW;\n \n+extern _Float128 ____wcstof128_l_internal (const wchar_t *, wchar_t **, int,\n+\t\t\t\t\t locale_t) attribute_hidden;\n+\n libc_hidden_proto (__wcstof128_internal)\n libc_hidden_proto (wcstof128)\n #endif\ndiff --git a/sysdeps/ieee754/float128/wcstof128.c b/sysdeps/ieee754/float128/wcstof128.c\nindex 49aa4d61ac..bab8c24040 100644\n--- a/sysdeps/ieee754/float128/wcstof128.c\n+++ b/sysdeps/ieee754/float128/wcstof128.c\n@@ -24,7 +24,4 @@\n /* Bring in _Float128 typedef if needed. */\n #include \n \n-extern _Float128 ____wcstof128_l_internal (const wchar_t *, wchar_t **, int,\n-\t\t\t\t\t locale_t);\n-\n #include \"strtof128.c\"\ndiff --git a/sysdeps/ieee754/float128/wcstof128_l.c b/sysdeps/ieee754/float128/wcstof128_l.c\nindex b295087efe..33fcccdaa6 100644\n--- a/sysdeps/ieee754/float128/wcstof128_l.c\n+++ b/sysdeps/ieee754/float128/wcstof128_l.c\n@@ -24,7 +24,4 @@\n \n #include \n \n-extern _Float128 ____wcstof128_l_internal (const wchar_t *, wchar_t **, int,\n-\t\t\t\t\t locale_t);\n-\n #include \"strtof128_l.c\"\ndiff --git a/wcsmbs/wcstod.c b/wcsmbs/wcstod.c\nindex 4604f51621..4c6343c040 100644\n--- a/wcsmbs/wcstod.c\n+++ b/wcsmbs/wcstod.c\n@@ -22,7 +22,4 @@\n \n #define\tUSE_WIDE_CHAR\t1\n \n-extern double ____wcstod_l_internal (const wchar_t *, wchar_t **, int,\n-\t\t\t\t locale_t);\n-\n #include \ndiff --git a/wcsmbs/wcstod_l.c b/wcsmbs/wcstod_l.c\nindex 7790f5abb7..25effe9681 100644\n--- a/wcsmbs/wcstod_l.c\n+++ b/wcsmbs/wcstod_l.c\n@@ -21,9 +21,6 @@\n #include \n \n \n-extern double ____wcstod_l_internal (const wchar_t *, wchar_t **, int,\n-\t\t\t\t locale_t);\n-\n #define\tUSE_WIDE_CHAR\t1\n \n #include \ndiff --git a/wcsmbs/wcstof.c b/wcsmbs/wcstof.c\nindex e91c09cd53..1f91ab5478 100644\n--- a/wcsmbs/wcstof.c\n+++ b/wcsmbs/wcstof.c\n@@ -21,7 +21,4 @@\n \n #define\tUSE_WIDE_CHAR\t1\n \n-extern float ____wcstof_l_internal (const wchar_t *, wchar_t **, int,\n-\t\t\t\t locale_t);\n-\n #include \ndiff --git a/wcsmbs/wcstof_l.c b/wcsmbs/wcstof_l.c\nindex 143b716d07..8b99b69e48 100644\n--- a/wcsmbs/wcstof_l.c\n+++ b/wcsmbs/wcstof_l.c\n@@ -23,7 +23,4 @@\n \n #define\tUSE_WIDE_CHAR\t1\n \n-extern float ____wcstof_l_internal (const wchar_t *, wchar_t **, int,\n-\t\t\t\t locale_t);\n-\n #include \ndiff --git a/wcsmbs/wcstol_l.c b/wcsmbs/wcstol_l.c\nindex 42bd8429d0..36eaf562b4 100644\n--- a/wcsmbs/wcstol_l.c\n+++ b/wcsmbs/wcstol_l.c\n@@ -23,7 +23,4 @@\n \n #define\tUSE_WIDE_CHAR\t1\n \n-extern long int ____wcstol_l_internal (const wchar_t *, wchar_t **, int, int,\n-\t\t\t\t locale_t);\n-\n #include \ndiff --git a/wcsmbs/wcstold.c b/wcsmbs/wcstold.c\nindex 7a14cd2871..481fcc4035 100644\n--- a/wcsmbs/wcstold.c\n+++ b/wcsmbs/wcstold.c\n@@ -21,7 +21,4 @@\n \n #define USE_WIDE_CHAR\t1\n \n-extern long double ____wcstold_l_internal (const wchar_t *, wchar_t **, int,\n-\t\t\t\t\t locale_t);\n-\n #include \ndiff --git a/wcsmbs/wcstold_l.c b/wcsmbs/wcstold_l.c\nindex a7ab025792..8192620bcc 100644\n--- a/wcsmbs/wcstold_l.c\n+++ b/wcsmbs/wcstold_l.c\n@@ -22,7 +22,4 @@\n \n #define USE_WIDE_CHAR\t1\n \n-extern long double ____wcstold_l_internal (const wchar_t *, wchar_t **, int,\n-\t\t\t\t\t locale_t);\n-\n #include \ndiff --git a/wcsmbs/wcstoll_l.c b/wcsmbs/wcstoll_l.c\nindex 598d3f5fff..4a71282346 100644\n--- a/wcsmbs/wcstoll_l.c\n+++ b/wcsmbs/wcstoll_l.c\n@@ -23,7 +23,4 @@\n \n #define QUAD\t1\n \n-extern long long int ____wcstoll_l_internal (const wchar_t *, wchar_t **,\n-\t\t\t\t\t int, int, locale_t);\n-\n #include \ndiff --git a/wcsmbs/wcstoul_l.c b/wcsmbs/wcstoul_l.c\nindex f9f3808b20..1a345d4bb0 100644\n--- a/wcsmbs/wcstoul_l.c\n+++ b/wcsmbs/wcstoul_l.c\n@@ -23,7 +23,4 @@\n \n #define UNSIGNED\t1\n \n-extern unsigned long int ____wcstoul_l_internal (const wchar_t *, wchar_t **,\n-\t\t\t\t\t\t int, int, locale_t);\n-\n #include \"wcstol_l.c\"\ndiff --git a/wcsmbs/wcstoull_l.c b/wcsmbs/wcstoull_l.c\nindex 412a9fcf0a..1666d5070e 100644\n--- a/wcsmbs/wcstoull_l.c\n+++ b/wcsmbs/wcstoull_l.c\n@@ -23,8 +23,4 @@\n \n #define UNSIGNED\t1\n \n-extern unsigned long long int ____wcstoull_l_internal (const wchar_t *,\n-\t\t\t\t\t\t wchar_t **, int, int,\n-\t\t\t\t\t\t locale_t);\n-\n #include \n","prefixes":["04/58"]}