{"id":808858,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808858/?format=json","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.0/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180029.9527-10-hjl.tools@gmail.com>","date":"2017-09-01T17:59:40","name":"[09/58] Mark internal wchar functions with attribute_hidden [BZ #18822]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1faa74b0f3d5499a725353d1fa98dcae5e664701","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/1.0/people/4387/?format=json","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-10-hjl.tools@gmail.com/mbox/","series":[{"id":1088,"url":"http://patchwork.ozlabs.org/api/1.0/series/1088/?format=json","date":"2017-09-01T18:00:21","name":"Hide internal functions in libc.so","version":1,"mbox":"http://patchwork.ozlabs.org/series/1088/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808858/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84055-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"AFkpmF7S\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRtF4xKzz9s7M\n\tfor ;\n\tSat, 2 Sep 2017 04:03:01 +1000 (AEST)","(qmail 84771 invoked by alias); 1 Sep 2017 18:00:49 -0000","(qmail 84562 invoked by uid 89); 1 Sep 2017 18:00:48 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=IBviQ2MgZi0sbvuXwbzwWfi9DKpNChN\n\tw/tNhI5XVJ77xLbCHGoYbspI/7VDSFUBfPHAnnAx+q9DgH+fSAobaN7OyPHVedmI\n\tlfz3MZE1gyncP1eoiGd2eWgHrwhOUgsMcbbY2wxvosMImofi+gszTmfHWgaz9Ztu\n\typjc40QUCjTU=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=AEzKht208fuWzKmVLRxc5SzbZtA=; b=AFkpm\n\tF7SPA527WhxNJRsPm+76YzrZgk9UJdqdJhc/sndPPFneqP0Xs9DURB02L7HTFAa2\n\tHWoyFvWbFJSDCsOWfhs70uvHnuiFZNtn+5rpoWmU8eSZOPP8HN1aUqXf/DdKqkN6\n\tAAY1dZm7qEvhH72M2dqRzxoRGuyrX8m17JbUN8=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3,\n\tSPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=H*m:gmail","X-HELO":"mga02.intel.com","X-ExtLoop1":"1","From":"\"H.J. Lu\" ","To":"libc-alpha@sourceware.org","Subject":"[PATCH 09/58] Mark internal wchar functions with attribute_hidden\n\t[BZ #18822]","Date":"Fri, 1 Sep 2017 10:59:40 -0700","Message-Id":"<20170901180029.9527-10-hjl.tools@gmail.com>","In-Reply-To":"<20170901180029.9527-1-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>"},"content":"Mark internal wchar functions with attribute_hidden to allow direct\naccess within libc.so and libc.a without using GOT nor PLT.\n\n\t[BZ #18822]\n\t* include/wchar.h (__wcsnlen): Add attribute_hidden.\n\t(__wcscat): Likewise.\n\t(__btowc): Likewise.\n\t(__wcrtomb): Likewise.\n\t(__mbsrtowcs): Likewise.\n\t(__wcsrtombs): Likewise.\n\t(__mbsnrtowcs): Likewise.\n\t(__wcsnrtombs): Likewise.\n\t(__wcsncpy): Likewise.\n\t(__wcpncpy): Likewise.\n\t(__wmemcpy): Likewise.\n\t(__wmempcpy): Likewise.\n\t(__wmemmove): Likewise.\n\t(__wcschrnul): Likewise.\n\t(__vfwscanf): Likewise.\n\t(__vswprintf): Likewise.\n\t(__fwprintf): Likewise.\n\t(__vfwprintf): Likewise.\n---\n include/wchar.h | 38 ++++++++++++++++++++++++--------------\n 1 file changed, 24 insertions(+), 14 deletions(-)","diff":"diff --git a/include/wchar.h b/include/wchar.h\nindex eb472daefb..24b2eaa5f9 100644\n--- a/include/wchar.h\n+++ b/include/wchar.h\n@@ -152,9 +152,10 @@ extern int __wcsncasecmp (const wchar_t *__s1, const wchar_t *__s2,\n __attribute_pure__;\n extern size_t __wcslen (const wchar_t *__s) __attribute_pure__;\n extern size_t __wcsnlen (const wchar_t *__s, size_t __maxlen)\n- __attribute_pure__;\n-extern wchar_t *__wcscat (wchar_t *dest, const wchar_t *src);\n-extern wint_t __btowc (int __c);\n+ attribute_hidden __attribute_pure__;\n+extern wchar_t *__wcscat (wchar_t *dest, const wchar_t *src)\n+ attribute_hidden;\n+extern wint_t __btowc (int __c) attribute_hidden;\n extern int __mbsinit (const __mbstate_t *__ps);\n extern size_t __mbrtowc (wchar_t *__restrict __pwc,\n \t\t\t const char *__restrict __s, size_t __n,\n@@ -162,34 +163,39 @@ extern size_t __mbrtowc (wchar_t *__restrict __pwc,\n libc_hidden_proto (__mbrtowc)\n libc_hidden_proto (__mbrlen)\n extern size_t __wcrtomb (char *__restrict __s, wchar_t __wc,\n-\t\t\t __mbstate_t *__restrict __ps);\n+\t\t\t __mbstate_t *__restrict __ps) attribute_hidden;\n extern size_t __mbsrtowcs (wchar_t *__restrict __dst,\n \t\t\t const char **__restrict __src,\n-\t\t\t size_t __len, __mbstate_t *__restrict __ps);\n+\t\t\t size_t __len, __mbstate_t *__restrict __ps)\n+ attribute_hidden;\n extern size_t __wcsrtombs (char *__restrict __dst,\n \t\t\t const wchar_t **__restrict __src,\n-\t\t\t size_t __len, __mbstate_t *__restrict __ps);\n+\t\t\t size_t __len, __mbstate_t *__restrict __ps)\n+ attribute_hidden;\n extern size_t __mbsnrtowcs (wchar_t *__restrict __dst,\n \t\t\t const char **__restrict __src, size_t __nmc,\n-\t\t\t size_t __len, __mbstate_t *__restrict __ps);\n+\t\t\t size_t __len, __mbstate_t *__restrict __ps)\n+ attribute_hidden;\n extern size_t __wcsnrtombs (char *__restrict __dst,\n \t\t\t const wchar_t **__restrict __src,\n \t\t\t size_t __nwc, size_t __len,\n-\t\t\t __mbstate_t *__restrict __ps);\n+\t\t\t __mbstate_t *__restrict __ps)\n+ attribute_hidden;\n extern wchar_t *__wcsncpy (wchar_t *__restrict __dest,\n-\t\t\t const wchar_t *__restrict __src, size_t __n);\n+\t\t\t const wchar_t *__restrict __src, size_t __n)\n+ attribute_hidden;\n extern wchar_t *__wcpcpy (wchar_t *__dest, const wchar_t *__src);\n extern wchar_t *__wcpncpy (wchar_t *__dest, const wchar_t *__src,\n-\t\t\t size_t __n);\n+\t\t\t size_t __n) attribute_hidden;\n extern wchar_t *__wmemcpy (wchar_t *__s1, const wchar_t *s2,\n-\t\t\t size_t __n);\n+\t\t\t size_t __n) attribute_hidden;\n extern wchar_t *__wmempcpy (wchar_t *__restrict __s1,\n \t\t\t const wchar_t *__restrict __s2,\n-\t\t\t size_t __n);\n+\t\t\t size_t __n) attribute_hidden;\n extern wchar_t *__wmemmove (wchar_t *__s1, const wchar_t *__s2,\n-\t\t\t size_t __n);\n+\t\t\t size_t __n) attribute_hidden;\n extern wchar_t *__wcschrnul (const wchar_t *__s, wchar_t __wc)\n- __attribute_pure__;\n+ attribute_hidden __attribute_pure__;\n \n extern wchar_t *__wmemset_chk (wchar_t *__s, wchar_t __c, size_t __n,\n \t\t\t size_t __ns) __THROW;\n@@ -197,17 +203,21 @@ extern wchar_t *__wmemset_chk (wchar_t *__s, wchar_t __c, size_t __n,\n extern int __vfwscanf (__FILE *__restrict __s,\n \t\t const wchar_t *__restrict __format,\n \t\t __gnuc_va_list __arg)\n+ attribute_hidden\n /* __attribute__ ((__format__ (__wscanf__, 2, 0)) */;\n extern int __vswprintf (wchar_t *__restrict __s, size_t __n,\n \t\t\tconst wchar_t *__restrict __format,\n \t\t\t__gnuc_va_list __arg)\n+ attribute_hidden\n /* __attribute__ ((__format__ (__wprintf__, 3, 0))) */;\n extern int __fwprintf (__FILE *__restrict __s,\n \t\t const wchar_t *__restrict __format, ...)\n+ attribute_hidden\n /* __attribute__ ((__format__ (__wprintf__, 2, 3))) */;\n extern int __vfwprintf (__FILE *__restrict __s,\n \t\t\tconst wchar_t *__restrict __format,\n \t\t\t__gnuc_va_list __arg)\n+ attribute_hidden\n /* __attribute__ ((__format__ (__wprintf__, 2, 0))) */;\n extern int __vfwprintf_chk (FILE *__restrict __s, int __flag,\n \t\t\t const wchar_t *__restrict __format,\n","prefixes":["09/58"]}