{"id":808853,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808853/?format=json","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.0/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901180029.9527-8-hjl.tools@gmail.com>","date":"2017-09-01T17:59:38","name":"[07/58] Mark internal grp/pwd/shadow functions with attribute_hidden [BZ #18822]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e104f84ea061389dfc76a8a48f378805c9ecbc7f","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/1.0/people/4387/?format=json","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-8-hjl.tools@gmail.com/mbox/","series":[{"id":1088,"url":"http://patchwork.ozlabs.org/api/1.0/series/1088/?format=json","date":"2017-09-01T18:00:21","name":"Hide internal functions in libc.so","version":1,"mbox":"http://patchwork.ozlabs.org/series/1088/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808853/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84050-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"XfCBvU7m\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRsC52Cwz9s7M\n\tfor ;\n\tSat, 2 Sep 2017 04:02:07 +1000 (AEST)","(qmail 84245 invoked by alias); 1 Sep 2017 18:00:47 -0000","(qmail 84031 invoked by uid 89); 1 Sep 2017 18:00:46 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=gK9hfxQtTgNadfqCh3OYgvtiDovV4Q2\n\t1hWZVimIdkje5Baht9VFAX/eEux78dN2ve+Rp9W2aKjU66vz+zYAfwWZVgdRSFWX\n\tkKN8S0WC6tYu6bWvgb6usMDDf4/pLrqWGu3J2Si5GxfEvv/Tpiqdubxcrb4cqQCX\n\tqXDCoxNrWelw=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=oaA6MUEmpdxj9Zfnbu7GNFsgafg=; b=XfCBv\n\tU7muxFQIVtRerNOLXu2dZFwH2xcsnvAH1hGv74rmcgQmBtUzr2m+ATzdCpZNUZPk\n\tomztN8ffRw1ERI6l8j1AgQQML7vw07TXMlsDIWtsw0S/vSkcajcW3B+x9dq5daO8\n\t2NTWc2iOHjrAzF3rU1YWo6WI/KfR8OVs0ns/GE=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3,\n\tSPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=H*m:gmail","X-HELO":"mga02.intel.com","X-ExtLoop1":"1","From":"\"H.J. Lu\" ","To":"libc-alpha@sourceware.org","Subject":"[PATCH 07/58] Mark internal grp/pwd/shadow functions with\n\tattribute_hidden [BZ #18822]","Date":"Fri, 1 Sep 2017 10:59:38 -0700","Message-Id":"<20170901180029.9527-8-hjl.tools@gmail.com>","In-Reply-To":"<20170901180029.9527-1-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>"},"content":"Mark internal grp/pwd/shadow functions with attribute_hidden to allow\ndirect access within libc.so and libc.a without using GOT nor PLT.\n\n\t[BZ #18822]\n\t* include/grp.h (__fgetgrent_r): Add attribute_hidden.\n\t(__getgrgid_r): Likewise.\n\t(__getgrnam_r): Likewise.\n\t* include/pwd.h (__getpwuid_r): Likewise.\n\t(__getpwnam_r): Likewise.\n\t(__fgetpwent_r): Likewise.\n\t* include/shadow.h (__getspnam_r): Likewise.\n\t(__sgetspent_r): Likewise.\n\t(__fgetspent_r): Likewise.\n---\n include/grp.h | 6 +++---\n include/pwd.h | 6 +++---\n include/shadow.h | 7 ++++---\n 3 files changed, 10 insertions(+), 9 deletions(-)","diff":"diff --git a/include/grp.h b/include/grp.h\nindex 0fb5c9a574..871701adbe 100644\n--- a/include/grp.h\n+++ b/include/grp.h\n@@ -12,12 +12,12 @@ extern int __old_getgrent_r (struct group *__resultbuf, char *buffer,\n \t\t\t size_t __buflen, struct group **__result);\n extern int __fgetgrent_r (FILE * __stream, struct group *__resultbuf,\n \t\t\t char *buffer, size_t __buflen,\n-\t\t\t struct group **__result);\n+\t\t\t struct group **__result) attribute_hidden;\n \n /* Search for an entry with a matching group ID. */\n extern int __getgrgid_r (__gid_t __gid, struct group *__resultbuf,\n \t\t\t char *__buffer, size_t __buflen,\n-\t\t\t struct group **__result);\n+\t\t\t struct group **__result) attribute_hidden;\n extern int __old_getgrgid_r (__gid_t __gid, struct group *__resultbuf,\n \t\t\t char *__buffer, size_t __buflen,\n \t\t\t struct group **__result);\n@@ -25,7 +25,7 @@ extern int __old_getgrgid_r (__gid_t __gid, struct group *__resultbuf,\n /* Search for an entry with a matching group name. */\n extern int __getgrnam_r (const char *__name, struct group *__resultbuf,\n \t\t\t char *__buffer, size_t __buflen,\n-\t\t\t struct group **__result);\n+\t\t\t struct group **__result) attribute_hidden;\n extern int __old_getgrnam_r (const char *__name, struct group *__resultbuf,\n \t\t\t char *__buffer, size_t __buflen,\n \t\t\t struct group **__result);\ndiff --git a/include/pwd.h b/include/pwd.h\nindex 3b0f72540c..fc995065d9 100644\n--- a/include/pwd.h\n+++ b/include/pwd.h\n@@ -10,19 +10,19 @@ extern int __old_getpwent_r (struct passwd *__resultbuf, char *__buffer,\n \t\t\t size_t __buflen, struct passwd **__result);\n extern int __getpwuid_r (__uid_t __uid, struct passwd *__resultbuf,\n \t\t\t char *__buffer, size_t __buflen,\n-\t\t\t struct passwd **__result);\n+\t\t\t struct passwd **__result) attribute_hidden;\n extern int __old_getpwuid_r (__uid_t __uid, struct passwd *__resultbuf,\n \t\t\t char *__buffer, size_t __buflen,\n \t\t\t struct passwd **__result);\n extern int __getpwnam_r (const char *__name, struct passwd *__resultbuf,\n \t\t\t char *__buffer, size_t __buflen,\n-\t\t\t struct passwd **__result);\n+\t\t\t struct passwd **__result) attribute_hidden;\n extern int __old_getpwnam_r (const char *__name, struct passwd *__resultbuf,\n \t\t\t char *__buffer, size_t __buflen,\n \t\t\t struct passwd **__result);\n extern int __fgetpwent_r (FILE * __stream, struct passwd *__resultbuf,\n \t\t\t char *__buffer, size_t __buflen,\n-\t\t\t struct passwd **__result);\n+\t\t\t struct passwd **__result) attribute_hidden;\n \n #include \n \ndiff --git a/include/shadow.h b/include/shadow.h\nindex 124a1ab50a..366ea83482 100644\n--- a/include/shadow.h\n+++ b/include/shadow.h\n@@ -11,16 +11,17 @@ extern int __old_getspent_r (struct spwd *__result_buf, char *__buffer,\n \t\t\t size_t __buflen, struct spwd **__result);\n extern int __getspnam_r (const char *__name, struct spwd *__result_buf,\n \t\t\t char *__buffer, size_t __buflen,\n-\t\t\t struct spwd **__result);\n+\t\t\t struct spwd **__result) attribute_hidden;\n extern int __old_getspnam_r (const char *__name, struct spwd *__result_buf,\n \t\t\t char *__buffer, size_t __buflen,\n \t\t\t struct spwd **__result);\n extern int __sgetspent_r (const char *__string,\n \t\t\t struct spwd *__result_buf, char *__buffer,\n-\t\t\t size_t __buflen, struct spwd **__result);\n+\t\t\t size_t __buflen, struct spwd **__result)\n+ attribute_hidden;\n extern int __fgetspent_r (FILE *__stream, struct spwd *__result_buf,\n \t\t\t char *__buffer, size_t __buflen,\n-\t\t\t struct spwd **__result);\n+\t\t\t struct spwd **__result) attribute_hidden;\n extern int __lckpwdf (void);\n extern int __ulckpwdf (void);\n \n","prefixes":["07/58"]}