{"id":808812,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808812/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"","date":"2017-09-01T16:39:16","name":"[iproute2,2/2] iplink: double the buffer size also in iplink_get()","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"a712cd14b4e1dc9cbc1158cda7beebdeac455d54","submitter":{"id":11892,"url":"http://patchwork.ozlabs.org/api/1.0/people/11892/?format=json","name":"Michal Kubecek","email":"mkubecek@suse.cz"},"delegate":{"id":389,"url":"http://patchwork.ozlabs.org/api/1.0/users/389/?format=json","username":"shemminger","first_name":"stephen","last_name":"hemminger","email":"shemminger@vyatta.com"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/a9d6a8d91f9b17690be6d1270f0db3def0574999.1504283683.git.mkubecek@suse.cz/mbox/","series":[{"id":1074,"url":"http://patchwork.ozlabs.org/api/1.0/series/1074/?format=json","date":"2017-09-01T16:39:16","name":"fix \"ip link show dev ...\" for NICs with many VFs","version":1,"mbox":"http://patchwork.ozlabs.org/series/1074/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808812/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkQ1w33H7z9t2x\n\tfor ;\n\tSat, 2 Sep 2017 02:39:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752239AbdIAQjU (ORCPT );\n\tFri, 1 Sep 2017 12:39:20 -0400","from mx2.suse.de ([195.135.220.15]:38413 \"EHLO mx1.suse.de\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751998AbdIAQjS (ORCPT );\n\tFri, 1 Sep 2017 12:39:18 -0400","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id 04632AE7C;\n\tFri, 1 Sep 2017 16:39:17 +0000 (UTC)","by unicorn.suse.cz (Postfix, from userid 1000)\n\tid A6F82A0F21; Fri, 1 Sep 2017 18:39:16 +0200 (CEST)"],"X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","Message-Id":"","In-Reply-To":"","References":"","From":"Michal Kubecek ","Subject":"[PATCH iproute2 2/2] iplink: double the buffer size also in\n\tiplink_get()","To":"Stephen Hemminger ","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org","Date":"Fri, 1 Sep 2017 18:39:16 +0200 (CEST)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Commit 72b365e8e0fd (\"libnetlink: Double the dump buffer size\") increased\nthe buffer size for \"ip link show\" command to 32 KB to handle NICs with\nlarge number of VFs. With \"dev\" filter, a different code path is taken and\niplink_get() still uses only 16 KB buffer.\n\nThe size of 32768 is not very future-proof as NICs supporting 120-128 VFs\nare already in use so that single RTM_NEWLINK message in the dump can\nexceed 30000 bytes. But it's what rtnl_talk() and rtnl_dump_filter_l() use\nso let's be consistent. Once this proves insufficient, all three sizes\nshould be increased.\n\nSigned-off-by: Michal Kubecek \n---\n ip/iplink.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/ip/iplink.c b/ip/iplink.c\nindex 790e3a138bb0..72c347932068 100644\n--- a/ip/iplink.c\n+++ b/ip/iplink.c\n@@ -1024,7 +1024,7 @@ int iplink_get(unsigned int flags, char *name, __u32 filt_mask)\n \t};\n \tstruct {\n \t\tstruct nlmsghdr n;\n-\t\tchar buf[16384];\n+\t\tchar buf[32768];\n \t} answer;\n \n \tif (name) {\n","prefixes":["iproute2","2/2"]}