{"id":808697,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808697/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170901140234.7840-3-sassmann@kpanic.de>","date":"2017-09-01T14:02:34","name":"[2/2] Revert \"i40e: remove WQ_UNBOUND and the task limit of our workqueue\"","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":true,"hash":"68d4e80c38ba737adfe3b914ebd561565c7bd7e0","submitter":{"id":7508,"url":"http://patchwork.ozlabs.org/api/1.0/people/7508/?format=json","name":"Stefan Assmann","email":"sassmann@kpanic.de"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170901140234.7840-3-sassmann@kpanic.de/mbox/","series":[{"id":1035,"url":"http://patchwork.ozlabs.org/api/1.0/series/1035/?format=json","date":"2017-09-01T14:02:32","name":"i40e: fix firmware update","version":1,"mbox":"http://patchwork.ozlabs.org/series/1035/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808697/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=kpanic.de","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=none smtp.mailfrom=sassmann@kpanic.de"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkLYB0lhsz9s7F\n\tfor ;\n\tSat, 2 Sep 2017 00:02:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752116AbdIAOCu (ORCPT );\n\tFri, 1 Sep 2017 10:02:50 -0400","from mx1.redhat.com ([209.132.183.28]:43070 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751966AbdIAOCs (ORCPT );\n\tFri, 1 Sep 2017 10:02:48 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DEEC77F350;\n\tFri, 1 Sep 2017 14:02:47 +0000 (UTC)","from w541.redhat.com (ovpn-116-204.ams2.redhat.com [10.36.116.204])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9DB5981F80;\n\tFri, 1 Sep 2017 14:02:46 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DEEC77F350","DKIM-Filter":"OpenDKIM Filter v2.11.0 mx1.redhat.com DEEC77F350","From":"Stefan Assmann ","To":"intel-wired-lan@lists.osuosl.org","Cc":"netdev@vger.kernel.org, davem@davemloft.net,\n\tjeffrey.t.kirsher@intel.com, sassmann@kpanic.de","Subject":"[PATCH 2/2] Revert \"i40e: remove WQ_UNBOUND and the task limit of\n\tour workqueue\"","Date":"Fri, 1 Sep 2017 16:02:34 +0200","Message-Id":"<20170901140234.7840-3-sassmann@kpanic.de>","In-Reply-To":"<20170901140234.7840-1-sassmann@kpanic.de>","References":"<20170901140234.7840-1-sassmann@kpanic.de>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tFri, 01 Sep 2017 14:02:48 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"This reverts commit 4d5957cbdecdbb77d24c1465caadd801c07afa4a.\n\nDue to this workqueue change the eeprom check right after flashing\nfirmware fails, although the flash itself completed successfully.\nThe error observed looks like this\ni40e 0000:88:00.0: eeprom check failed (-62), Tx/Rx traffic disabled\nThe NIC is fully operational after the flash and even after a cold boot\nany follow-up eeprom checks succeed.\n\nThis needs to be investigated, but for now it should be more important\nto make sure the firmware update works as expected.\n\nSigned-off-by: Stefan Assmann \n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 6498da8806cb..069b6683e1b0 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -12160,14 +12160,12 @@ static int __init i40e_init_module(void)\n \t\ti40e_driver_string, i40e_driver_version_str);\n \tpr_info(\"%s: %s\\n\", i40e_driver_name, i40e_copyright);\n \n-\t/* There is no need to throttle the number of active tasks because\n-\t * each device limits its own task using a state bit for scheduling\n-\t * the service task, and the device tasks do not interfere with each\n-\t * other, so we don't set a max task limit. We must set WQ_MEM_RECLAIM\n-\t * since we need to be able to guarantee forward progress even under\n-\t * memory pressure.\n+\t/* we will see if single thread per module is enough for now,\n+\t * it can't be any worse than using the system workqueue which\n+\t * was already single threaded\n \t */\n-\ti40e_wq = alloc_workqueue(\"%s\", WQ_MEM_RECLAIM, 0, i40e_driver_name);\n+\ti40e_wq = alloc_workqueue(\"%s\", WQ_UNBOUND | WQ_MEM_RECLAIM, 1,\n+\t\t\t\t i40e_driver_name);\n \tif (!i40e_wq) {\n \t\tpr_err(\"%s: Failed to create workqueue\\n\", i40e_driver_name);\n \t\treturn -ENOMEM;\n","prefixes":["2/2"]}