{"id":808660,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808660/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901115500.12654-3-quintela@redhat.com>","date":"2017-09-01T11:55:00","name":"[v4,2/2] tests: Make vmgenid test compile","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"26ee4a10cb03ddbbdfb1b42a4ad495a82c1479cb","submitter":{"id":2643,"url":"http://patchwork.ozlabs.org/api/1.0/people/2643/?format=json","name":"Juan Quintela","email":"quintela@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901115500.12654-3-quintela@redhat.com/mbox/","series":[{"id":1012,"url":"http://patchwork.ozlabs.org/api/1.0/series/1012/?format=json","date":"2017-09-01T11:55:00","name":"Fix tests on recent gcc","version":4,"mbox":"http://patchwork.ozlabs.org/series/1012/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808660/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=quintela@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkHky57Nbz9sRV\n\tfor ;\n\tFri, 1 Sep 2017 21:56:10 +1000 (AEST)","from localhost ([::1]:37331 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnkYS-0005o2-Qd\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 07:56:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38907)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnkXs-0005mH-Sn\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:55:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnkXo-0007wN-8e\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:55:32 -0400","from mx1.redhat.com ([209.132.183.28]:57510)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnkXo-0007wC-2p\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:55:28 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 18D101F570\n\tfor ; Fri, 1 Sep 2017 11:55:27 +0000 (UTC)","from secure.mitica (ovpn-117-188.ams2.redhat.com [10.36.117.188])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1546E7BB51;\n\tFri, 1 Sep 2017 11:55:24 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 18D101F570","From":"Juan Quintela ","To":"qemu-devel@nongnu.org","Date":"Fri, 1 Sep 2017 13:55:00 +0200","Message-Id":"<20170901115500.12654-3-quintela@redhat.com>","In-Reply-To":"<20170901115500.12654-1-quintela@redhat.com>","References":"<20170901115500.12654-1-quintela@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 01 Sep 2017 11:55:27 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v4 2/2] tests: Make vmgenid test compile","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Just make sure that nr_tables is size_t not int.\nOnce there, do the assert in the right place and be sure that we don't\nhave a division by zero.\n\nSuggested-by: Cédric Le Goater \nSigned-off-by: Juan Quintela \nTested-by: Cleber Rosa \n\n--\n\nDrop the s/g_new0/g_malloc0/ change.\nAvoid division by zero with assert (danp)\n---\n tests/vmgenid-test.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c\nindex 3d5c1c3615..918c82c82a 100644\n--- a/tests/vmgenid-test.c\n+++ b/tests/vmgenid-test.c\n@@ -40,7 +40,7 @@ static uint32_t acpi_find_vgia(void)\n AcpiRsdpDescriptor rsdp_table;\n uint32_t rsdt;\n AcpiRsdtDescriptorRev1 rsdt_table;\n- int tables_nr;\n+ size_t tables_nr;\n uint32_t *tables;\n AcpiTableHeader ssdt_table;\n VgidTable vgid_table;\n@@ -62,9 +62,9 @@ static uint32_t acpi_find_vgia(void)\n ACPI_ASSERT_CMP(rsdt_table.signature, \"RSDT\");\n \n /* compute the table entries in rsdt */\n+ g_assert_cmpint(rsdt_table.length, >, sizeof(AcpiRsdtDescriptorRev1));\n tables_nr = (rsdt_table.length - sizeof(AcpiRsdtDescriptorRev1)) /\n sizeof(uint32_t);\n- g_assert_cmpint(tables_nr, >, 0);\n \n /* get the addresses of the tables pointed by rsdt */\n tables = g_new0(uint32_t, tables_nr);\n","prefixes":["v4","2/2"]}