{"id":808656,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808656/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901112829.2571-14-apahim@redhat.com>","date":"2017-09-01T11:28:29","name":"[v8,13/13] qemu.py: don't launch again before shutdown()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"755dd8a8e1518c3578082308c5da5ebea98bc6e3","submitter":{"id":71999,"url":"http://patchwork.ozlabs.org/api/1.0/people/71999/?format=json","name":"Amador Pahim","email":"apahim@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901112829.2571-14-apahim@redhat.com/mbox/","series":[{"id":1006,"url":"http://patchwork.ozlabs.org/api/1.0/series/1006/?format=json","date":"2017-09-01T11:28:16","name":"scripts/qemu.py fixes and cleanups","version":8,"mbox":"http://patchwork.ozlabs.org/series/1006/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808656/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=apahim@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkHRt6bj4z9t1t\n\tfor ;\n\tFri, 1 Sep 2017 21:43:06 +1000 (AEST)","from localhost ([::1]:36488 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnkLn-0002X5-Iz\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 07:43:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59951)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnkBQ-0001ca-8n\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:32:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnkBP-00075l-Au\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:32:20 -0400","from mx1.redhat.com ([209.132.183.28]:37148)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnkBP-00075W-4T\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:32:19 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 37272356CE;\n\tFri, 1 Sep 2017 11:32:18 +0000 (UTC)","from t460p.pahim.org.com (ovpn-204-134.brq.redhat.com\n\t[10.40.204.134])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AF66C77DC1;\n\tFri, 1 Sep 2017 11:32:12 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 37272356CE","From":"Amador Pahim ","To":"qemu-devel@nongnu.org","Date":"Fri, 1 Sep 2017 13:28:29 +0200","Message-Id":"<20170901112829.2571-14-apahim@redhat.com>","In-Reply-To":"<20170901112829.2571-1-apahim@redhat.com>","References":"<20170901112829.2571-1-apahim@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 01 Sep 2017 11:32:18 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v8 13/13] qemu.py: don't launch again before\n\tshutdown()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, ldoktor@redhat.com, famz@redhat.com,\n\tehabkost@redhat.com, \n\tstefanha@gmail.com, Amador Pahim ,\n\tarmbru@redhat.com, mreitz@redhat.com, crosa@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"If a VM is launched, files are created and a cleanup is required before\na new launch. This cleanup is executed by shutdown(), so shutdown() must\nbe called even if the VM is manually terminated (i.e. using kill).\n\nThis patch creates a control to make sure launch() will not be executed\nagain if shutdown() is not called after the previous launch().\n\nSigned-off-by: Amador Pahim \n---\n scripts/qemu.py | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/scripts/qemu.py b/scripts/qemu.py\nindex 363f649a7e..05fca4d268 100644\n--- a/scripts/qemu.py\n+++ b/scripts/qemu.py\n@@ -52,6 +52,7 @@ class QEMUMachine(object):\n self._debug = debug\n self._qemu_full_args = None\n self._created_files = []\n+ self._pending_shutdown = False\n \n # This can be used to add an unused monitor instance.\n def add_monitor_telnet(self, ip, port):\n@@ -168,10 +169,14 @@ class QEMUMachine(object):\n if self.is_running():\n raise QEMUMachineError('VM already running')\n \n+ if self._pending_shutdown:\n+ raise QEMUMachineError('Shutdown pending after previous launch')\n+\n self._iolog = None\n self._qemu_full_args = None\n try:\n self._launch()\n+ self._pending_shutdown = True\n except:\n self.shutdown()\n \n@@ -217,6 +222,8 @@ class QEMUMachine(object):\n command = ''\n LOG.warn(msg, exitcode, command)\n \n+ self._pending_shutdown = False\n+\n underscore_to_dash = string.maketrans('_', '-')\n def qmp(self, cmd, conv_keys=True, **args):\n '''Invoke a QMP command and return the result dict'''\n","prefixes":["v8","13/13"]}