{"id":808654,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808654/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901112829.2571-13-apahim@redhat.com>","date":"2017-09-01T11:28:28","name":"[v8,12/13] qemu.py: launch vm only if it's not running","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"610f588c0e61b9cefcdb72833b882896f9d2b274","submitter":{"id":71999,"url":"http://patchwork.ozlabs.org/api/1.0/people/71999/?format=json","name":"Amador Pahim","email":"apahim@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901112829.2571-13-apahim@redhat.com/mbox/","series":[{"id":1006,"url":"http://patchwork.ozlabs.org/api/1.0/series/1006/?format=json","date":"2017-09-01T11:28:16","name":"scripts/qemu.py fixes and cleanups","version":8,"mbox":"http://patchwork.ozlabs.org/series/1006/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808654/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=apahim@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkHP964NWz9sRV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 21:40:45 +1000 (AEST)","from localhost ([::1]:36447 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnkJX-0000ET-VO\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 07:40:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59921)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <apahim@redhat.com>) id 1dnkBO-0001aX-2V\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:32:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <apahim@redhat.com>) id 1dnkBJ-00073p-HK\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:32:18 -0400","from mx1.redhat.com ([209.132.183.28]:52892)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <apahim@redhat.com>) id 1dnkBJ-00073d-BH\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:32:13 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5DFD4821C3;\n\tFri,  1 Sep 2017 11:32:12 +0000 (UTC)","from t460p.pahim.org.com (ovpn-204-134.brq.redhat.com\n\t[10.40.204.134])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E395877DC1;\n\tFri,  1 Sep 2017 11:32:08 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5DFD4821C3","From":"Amador Pahim <apahim@redhat.com>","To":"qemu-devel@nongnu.org","Date":"Fri,  1 Sep 2017 13:28:28 +0200","Message-Id":"<20170901112829.2571-13-apahim@redhat.com>","In-Reply-To":"<20170901112829.2571-1-apahim@redhat.com>","References":"<20170901112829.2571-1-apahim@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tFri, 01 Sep 2017 11:32:12 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v8 12/13] qemu.py: launch vm only if it's not\n\trunning","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"kwolf@redhat.com, ldoktor@redhat.com, famz@redhat.com,\n\tehabkost@redhat.com, \n\tstefanha@gmail.com, Amador Pahim <apahim@redhat.com>,\n\tarmbru@redhat.com, mreitz@redhat.com, crosa@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"A new call to launch() with a running VM will fall in exception and\nconsequently call shutdown().\n\nThis patch makes launch() to raise an exception when it's called with VM\nalready running.\n\nSigned-off-by: Amador Pahim <apahim@redhat.com>\n---\n scripts/qemu.py | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/scripts/qemu.py b/scripts/qemu.py\nindex 03e4cc34b7..363f649a7e 100644\n--- a/scripts/qemu.py\n+++ b/scripts/qemu.py\n@@ -165,6 +165,9 @@ class QEMUMachine(object):\n         Try to launch the VM and make sure we cleanup and expose the\n         command line/output in case of exception.\n         '''\n+        if self.is_running():\n+            raise QEMUMachineError('VM already running')\n+\n         self._iolog = None\n         self._qemu_full_args = None\n         try:\n","prefixes":["v8","12/13"]}