{"id":808645,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808645/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170901112829.2571-6-apahim@redhat.com>","date":"2017-09-01T11:28:21","name":"[v8,05/13] qemu.py: include debug information on launch error","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"026e543589989e1e0f45f4571578154d1be890c5","submitter":{"id":71999,"url":"http://patchwork.ozlabs.org/api/1.0/people/71999/?format=json","name":"Amador Pahim","email":"apahim@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901112829.2571-6-apahim@redhat.com/mbox/","series":[{"id":1006,"url":"http://patchwork.ozlabs.org/api/1.0/series/1006/?format=json","date":"2017-09-01T11:28:16","name":"scripts/qemu.py fixes and cleanups","version":8,"mbox":"http://patchwork.ozlabs.org/series/1006/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808645/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=apahim@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkHHx70Y9z9sRV\n\tfor ;\n\tFri, 1 Sep 2017 21:36:13 +1000 (AEST)","from localhost ([::1]:36394 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnkFA-0004QW-33\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 07:36:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59655)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnkAt-0001BH-EI\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:31:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnkAq-0006tS-8y\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:31:47 -0400","from mx1.redhat.com ([209.132.183.28]:57754)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnkAq-0006tK-2X\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:31:44 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 25CD768CE;\n\tFri, 1 Sep 2017 11:31:43 +0000 (UTC)","from t460p.pahim.org.com (ovpn-204-134.brq.redhat.com\n\t[10.40.204.134])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8D9FA77DC1;\n\tFri, 1 Sep 2017 11:31:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 25CD768CE","From":"Amador Pahim ","To":"qemu-devel@nongnu.org","Date":"Fri, 1 Sep 2017 13:28:21 +0200","Message-Id":"<20170901112829.2571-6-apahim@redhat.com>","In-Reply-To":"<20170901112829.2571-1-apahim@redhat.com>","References":"<20170901112829.2571-1-apahim@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tFri, 01 Sep 2017 11:31:43 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on\n\tlaunch error","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, ldoktor@redhat.com, famz@redhat.com,\n\tehabkost@redhat.com, \n\tstefanha@gmail.com, Amador Pahim ,\n\tarmbru@redhat.com, mreitz@redhat.com, crosa@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"When launching a VM, if an exception happens and the VM is not\ninitiated, it might be useful to see the qemu command line and\nthe qemu command output.\n\nThis patch creates that message. Notice that self._iolog needs to be\ncleaned up in the beginning of the launch() to make sure we will not\nexpose the qemu log from a previous launch if the current one fails.\n\nSigned-off-by: Amador Pahim \n---\n scripts/qemu.py | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/scripts/qemu.py b/scripts/qemu.py\nindex 670c048569..3ebe5ee0a4 100644\n--- a/scripts/qemu.py\n+++ b/scripts/qemu.py\n@@ -141,6 +141,7 @@ class QEMUMachine(object):\n \n def launch(self):\n '''Launch the VM and establish a QMP connection'''\n+ self._iolog = None\n self._qemu_full_args = None\n devnull = open(os.path.devnull, 'rb')\n qemulog = open(self._qemu_log_path, 'wb')\n@@ -160,6 +161,12 @@ class QEMUMachine(object):\n self._popen.wait()\n self._load_io_log()\n self._post_shutdown()\n+\n+ LOG.debug('Error launching VM')\n+ if self._qemu_full_args:\n+ LOG.debug('Command: %r', ' '.join(self._qemu_full_args))\n+ if self._iolog:\n+ LOG.debug('Output: %r', self._iolog)\n raise\n \n def shutdown(self):\n","prefixes":["v8","05/13"]}