{"id":808590,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808590/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20170901085856.2286-3-jiri@resnulli.us>","date":"2017-09-01T08:58:56","name":"[net-next,2/2] mlxsw: spectrum_router: Set abort trap in all virtual routers","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"bdedb2bca22a0e27525eda5fd681938241723fdd","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/1.0/people/15321/?format=json","name":"Jiri Pirko","email":"jiri@resnulli.us"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.0/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170901085856.2286-3-jiri@resnulli.us/mbox/","series":[{"id":977,"url":"http://patchwork.ozlabs.org/api/1.0/series/977/?format=json","date":"2017-09-01T08:58:54","name":"mlxsw: spectrum_router: Couple of fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/977/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808590/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"IrncCKB9\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkCpm4xYhz9t2r\n\tfor ;\n\tFri, 1 Sep 2017 18:59:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751687AbdIAI7L (ORCPT );\n\tFri, 1 Sep 2017 04:59:11 -0400","from mail-wr0-f195.google.com ([209.85.128.195]:36193 \"EHLO\n\tmail-wr0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751589AbdIAI7C (ORCPT\n\t); Fri, 1 Sep 2017 04:59:02 -0400","by mail-wr0-f195.google.com with SMTP id 40so981575wrv.3\n\tfor ; Fri, 01 Sep 2017 01:59:01 -0700 (PDT)","from localhost (jirka.pirko.cz. [84.16.102.26])\n\tby smtp.gmail.com with ESMTPSA id\n\tc139sm2151568wmh.32.2017.09.01.01.58.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 01 Sep 2017 01:59:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=PEJPH9tZPMHCYeseSaG24Hwlko4QB4aKwkhGspcXi1s=;\n\tb=IrncCKB9kkvN2xeiAQ9A5uB7waD3btcLZKRc9k5+hImIx7lLDWqzGhvb5RDsmw0yu3\n\t7nbVonXa6Y4BntwMonoAG8qzbWxnzVu6KykCLgc2QrT8YO3XncsoNmhFWE95eSD5Ttp7\n\tyLLOgT1SWRIDa4eox7RRFMi1MV9bsAv/WZJ6TW8lLB0kYe5RgE/ZLRyowUy3yqiLpN/n\n\tpoNJ8UiS08mkNEJpgrEdrmikuaP/mYARtzr69t7gxEDAkLPpvoh0ZVBbuDBGpjgi7j8M\n\tiq08H4Vr1Un8PisAyKbL8Cz+MOBnLE/dwxr9BmCuGuToEhDaOagdXg9+IbONT1ejn94f\n\tVqIw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=PEJPH9tZPMHCYeseSaG24Hwlko4QB4aKwkhGspcXi1s=;\n\tb=Y7jsds8Bf2VhkWH/1Oi8RJx6fhZJl6PP9aJusalZcvEnK20+BEOICWHGVqVXT4QuzS\n\tDHphQ2/qBPynERas23M/KRyk+XpHL1Rr31h5FEjUmGIiHkiDJEp+Drk+bIEgivhY0Qfk\n\tKCftXEF75YoQj87eglOLHv9gCcbuVq75icPtZn7pjzMw8229Ih2OV76oGUcOcpaHMcBn\n\td9vCh3oAbrSK1b+5xpTJbQSgi3nblH7JyCfhKzHLdul+VuY5xPOxkixRJ8fZAQNJ4cWr\n\tov5bdGUAquPO7wCC+XeJ0wzCxRfT/BzU/0c+Mv8zNQTZeKAbeKjqqR71NWePiZ1mK8Lh\n\tP++w==","X-Gm-Message-State":"AHPjjUhyZdsKLWe+xNXFfomQN9TJQeMj9akEdqzCEJtlXE3pHq9pjw0j\n\tOJNkrgd2Vx6UfFdP8pE=","X-Google-Smtp-Source":"ADKCNb4vhqxtKJ1X4PtI9aQihRkgh2chmHSf4Cfu18c+9Xx/QOHsOpVPmCeEhPEB00VI4lVgNM0n4A==","X-Received":"by 10.223.177.133 with SMTP id q5mr698997wra.135.1504256340616; \n\tFri, 01 Sep 2017 01:59:00 -0700 (PDT)","From":"Jiri Pirko ","To":"netdev@vger.kernel.org","Cc":"davem@davemloft.net, idosch@mellanox.com, mlxsw@mellanox.com","Subject":"[patch net-next 2/2] mlxsw: spectrum_router: Set abort trap in all\n\tvirtual routers","Date":"Fri, 1 Sep 2017 10:58:56 +0200","Message-Id":"<20170901085856.2286-3-jiri@resnulli.us>","X-Mailer":"git-send-email 2.9.3","In-Reply-To":"<20170901085856.2286-1-jiri@resnulli.us>","References":"<20170901085856.2286-1-jiri@resnulli.us>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Ido Schimmel \n\nWhen the abort mechanism is invoked a default route directing packets to\nthe CPU is programmed in all the virtual routers currently in use. This\ncan result in packet loss in case a new VRF is configured.\n\nUpon abort, program the default route in all virtual routers, whether\nthey are in use or not.\n\nThe patch is directed at net-next since post-abort fixes aren't critical\nand packet loss due to a missing default route will be insignificant\ncompared to packet loss caused by the CPU port policer.\n\nSigned-off-by: Ido Schimmel \nSigned-off-by: Jiri Pirko \n---\n drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\nindex 00e3aec..de15eac 100644\n--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\n+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\n@@ -3993,9 +3993,6 @@ static int __mlxsw_sp_router_set_abort_trap(struct mlxsw_sp *mlxsw_sp,\n \t\tchar raltb_pl[MLXSW_REG_RALTB_LEN];\n \t\tchar ralue_pl[MLXSW_REG_RALUE_LEN];\n \n-\t\tif (!mlxsw_sp_vr_is_used(vr))\n-\t\t\tcontinue;\n-\n \t\tmlxsw_reg_raltb_pack(raltb_pl, vr->id, proto, tree_id);\n \t\terr = mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(raltb),\n \t\t\t\t raltb_pl);\n","prefixes":["net-next","2/2"]}