{"id":808571,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808571/?format=json","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.0/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1504252841-2445-9-git-send-email-bmeng.cn@gmail.com>","date":"2017-09-01T08:00:39","name":"[08/10] spi-nor: intel-spi: Remove the unnecessary HSFSTS register RW","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5cf5fa40a4cce2c3dfa848b73d265076f624405a","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/1.0/people/64981/?format=json","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"delegate":{"id":63396,"url":"http://patchwork.ozlabs.org/api/1.0/users/63396/?format=json","username":"cpitchen","first_name":"Cyrille","last_name":"Pitchen","email":"cyrille.pitchen@atmel.com"},"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1504252841-2445-9-git-send-email-bmeng.cn@gmail.com/mbox/","series":[{"id":969,"url":"http://patchwork.ozlabs.org/api/1.0/series/969/?format=json","date":"2017-09-01T08:00:33","name":"spi-nor: intel-spi: Various fixes and enhancements","version":1,"mbox":"http://patchwork.ozlabs.org/series/969/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808571/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"DpaR9Rwl\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"N5fpS3a+\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkBVD2pQ4z9s81\n\tfor ;\n\tFri, 1 Sep 2017 17:59:48 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dngra-0003s1-0v; Fri, 01 Sep 2017 07:59:38 +0000","from mail-io0-x241.google.com ([2607:f8b0:4001:c06::241])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dngou-0001Yv-NS\n\tfor linux-mtd@lists.infradead.org; Fri, 01 Sep 2017 07:56:54 +0000","by mail-io0-x241.google.com with SMTP id 2so2154579ion.3\n\tfor ;\n\tFri, 01 Sep 2017 00:56:34 -0700 (PDT)","from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com.\n\t[147.11.156.139]) by smtp.gmail.com with ESMTPSA id\n\td187sm853502iod.7.2017.09.01.00.56.32\n\t(version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 01 Sep 2017 00:56:33 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=YGrC35fn53TgYSzdaDntXRv0dZNJ7klBN8vZ9pTb5Ag=;\n\tb=DpaR9RwlE2dmKcXnz+o66z5t75\n\tyNvfGPC4Bp2okM5Vu1yEEJn27+1ed6Y54RPJ84z71WDIohdi0nSah/Fv8y1nYjQciME1iXjBZa5vH\n\tRU/4HXCkoKhGseiq1Z0ikm7AlF/aB88TkiMaB/4SExIJbcwWGtfmTnmC8IPMmsULge5QZO6oRrlHJ\n\t1GCuEbJa0wk9ve9ppTmt5qRhCAa711xjCGToddyAV4dJAhnTQdB18RiAjl8Z98spAkjhxz7QAPTuY\n\t5S6gA/LnK0I+gSg4U5OECf4dKrWPGE9IHre15Q/lxpLyrYihmUieIj1lUD57lCeYkRCwhRa/COv9U\n\tsiTw2sog==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=JK0FEnHe8+L8HPZfr5IHryw6hHRVZc+ZZqW0IzWacfs=;\n\tb=N5fpS3a+nqd6sndXXrZ1UzY6KchhfiYnNFBvx3ocbfGyMjQKw3zAhOv0RJGyK+g2h5\n\trwGexZHSz1qxryUON+IciIWGi0/YSMJVFO7lts1/NcEUri88fKQsDQ9OnzF+9R3nBdON\n\tEj0BB3d8UjeucPwuCqboJse/ld6fY74CXf/8HysCs7RDTdoVA39AZRQvYCMeVdhRq05s\n\ta0eo4P+PDTXBmFDBuwNQhCo1SyFzL16INn04ItEvQKietCVQWT59khqDhUU7C8iamurP\n\tginiPnyHoetuUZh+4lk0OMTy/UaUuPdmgj172iTRAZfyO7hLRHwuVCcEhM4g7y9dTNAc\n\trV3w=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=JK0FEnHe8+L8HPZfr5IHryw6hHRVZc+ZZqW0IzWacfs=;\n\tb=KPPcc5ywcnznZVr43UIpqbZP9vcCsgJAtXtfR1Iw/Ssel73GVPiEbwPxJDo5jv+egh\n\tvPf4ooNf5QsJ12qFfewxCYgWTy8x6auOO1l5s6Nf/orBEFgfQkCNv5ph8NU0BKYj0l37\n\tjaSobrh1F8VTMsy8/vsIxXdHifhB2RttsiMBb5E/AN4C6aqjyfIaouIbTIfxUiACesTk\n\tOyBkwXYNUAAHc+QV8QXM9vAhA1uWAU50WE8b5L7DsOlNOOhGE9QjOGmITC4/i3T8yJTL\n\ttPqBDcHiH61E5eoXA+Th7d2v6ZEhphP3UQR2wvPRsbo7eERXKyCYEM10wzHgiAcfALF4\n\t9//A==","X-Gm-Message-State":"AHPjjUiKOZc0ZR2mkVm+sciRWmbaBdG/TW9rHYhy+lvWJ4Ukr3Qv8HEh\n\t5hFBpOJJPO2cIg==","X-Google-Smtp-Source":"ADKCNb7Dj+28fO8KoZ56F8kCaMy+Uub0SVUfemZe96x1wumE+eYJl8zx2kohvOdpddcjf4gj71xR7w==","X-Received":"by 10.36.66.148 with SMTP id i142mr654421itb.106.1504252594397; \n\tFri, 01 Sep 2017 00:56:34 -0700 (PDT)","From":"Bin Meng ","To":"Mika Westerberg ,\n\tCyrille Pitchen ,\n\tMarek Vasut ,\n\tBoris Brezillon ,\n\tBrian Norris ,\n\tRichard Weinberger ,\n\tDavid Woodhouse , \n\tlinux-mtd ,\n\tlinux-kernel ","Subject":"[PATCH 08/10] spi-nor: intel-spi: Remove the unnecessary HSFSTS\n\tregister RW","Date":"Fri, 1 Sep 2017 01:00:39 -0700","Message-Id":"<1504252841-2445-9-git-send-email-bmeng.cn@gmail.com>","X-Mailer":"git-send-email 1.7.9.5","In-Reply-To":"<1504252841-2445-1-git-send-email-bmeng.cn@gmail.com>","References":"<1504252841-2445-1-git-send-email-bmeng.cn@gmail.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170901_005652_828682_38021DAA ","X-CRM114-Status":"GOOD ( 10.50 )","X-Spam-Score":"-2.7 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2607:f8b0:4001:c06:0:0:0:241 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (bmeng.cn[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Stefan Roese ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"There is no code that alters the HSFSTS register content in between\nin intel_spi_write(). Remove the unnecessary RW to save some cycles.\n\nSigned-off-by: Bin Meng \n---\n\n drivers/mtd/spi-nor/intel-spi.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c\nindex 07146ab..91ceef7 100644\n--- a/drivers/mtd/spi-nor/intel-spi.c\n+++ b/drivers/mtd/spi-nor/intel-spi.c\n@@ -611,7 +611,6 @@ static ssize_t intel_spi_write(struct spi_nor *nor, loff_t to, size_t len,\n \t\tval |= HSFSTS_CTL_AEL | HSFSTS_CTL_FCERR | HSFSTS_CTL_FDONE;\n \t\tval |= (block_size - 1) << HSFSTS_CTL_FDBC_SHIFT;\n \t\tval |= HSFSTS_CTL_FCYCLE_WRITE;\n-\t\twritel(val, ispi->base + HSFSTS_CTL);\n \n \t\tret = intel_spi_write_block(ispi, write_buf, block_size);\n \t\tif (ret) {\n@@ -620,8 +619,8 @@ static ssize_t intel_spi_write(struct spi_nor *nor, loff_t to, size_t len,\n \t\t}\n \n \t\t/* Start the write now */\n-\t\tval = readl(ispi->base + HSFSTS_CTL);\n-\t\twritel(val | HSFSTS_CTL_FGO, ispi->base + HSFSTS_CTL);\n+\t\tval |= HSFSTS_CTL_FGO;\n+\t\twritel(val, ispi->base + HSFSTS_CTL);\n \n \t\tret = intel_spi_wait_hw_busy(ispi);\n \t\tif (ret) {\n","prefixes":["08/10"]}