{"id":808564,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808564/?format=json","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.0/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1504252841-2445-3-git-send-email-bmeng.cn@gmail.com>","date":"2017-09-01T08:00:33","name":"[02/10] spi-nor: intel-spi: Remove useless 'buf' parameter in the HW/SW cycle","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d2864ee34effa023b99a3d5196494b347e4ac2d6","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/1.0/people/64981/?format=json","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"delegate":{"id":63396,"url":"http://patchwork.ozlabs.org/api/1.0/users/63396/?format=json","username":"cpitchen","first_name":"Cyrille","last_name":"Pitchen","email":"cyrille.pitchen@atmel.com"},"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1504252841-2445-3-git-send-email-bmeng.cn@gmail.com/mbox/","series":[{"id":969,"url":"http://patchwork.ozlabs.org/api/1.0/series/969/?format=json","date":"2017-09-01T08:00:33","name":"spi-nor: intel-spi: Various fixes and enhancements","version":1,"mbox":"http://patchwork.ozlabs.org/series/969/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808564/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"qnZSRASE\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Pws55iMU\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkBRD5GsZz9s83\n\tfor ;\n\tFri, 1 Sep 2017 17:57:12 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dngp7-0001c1-Ii; Fri, 01 Sep 2017 07:57:05 +0000","from mail-io0-x244.google.com ([2607:f8b0:4001:c06::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dngoj-0001Ws-5p\n\tfor linux-mtd@lists.infradead.org; Fri, 01 Sep 2017 07:56:42 +0000","by mail-io0-x244.google.com with SMTP id f99so2172668ioi.0\n\tfor ;\n\tFri, 01 Sep 2017 00:56:23 -0700 (PDT)","from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com.\n\t[147.11.156.139]) by smtp.gmail.com with ESMTPSA id\n\td187sm853502iod.7.2017.09.01.00.56.21\n\t(version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 01 Sep 2017 00:56:22 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=CzVRQIeZ4PoMywiFnFfjgAlJ1C7jvyhekNace2sKIIk=;\n\tb=qnZSRASEa74aqvJbq7frMKS8eX\n\t02J0xWxxVdklpGN7Mi5xEKlj0G28gxfwT6MEwwsXz4vTf+yU0mp29EfWB2DEJwlOEQiiaI8khUM1j\n\tMTef6Ol3yiP3SNzvQeyql71EMtMVo2PEJE4hR4T9GZJjAAcfKokOVLQcK7Oi5GmoicNUxphCbULmF\n\tad6sJCaYjqidMA7dUsvwXuf9sVezfEtjiDqydLO4l4T5PRdHt2u6UT7dNBAuEV+Vxp1vsDgUafRz0\n\tE9GwemIEHae8utH62PHcbJw+chzYYQLdON7JaIqFt0HFL/fIrFWLirAcco7Z0hXsEC0hRQWYVRViH\n\tA90szo3A==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=wARteoxR66e9yQkngejVaokaLKx7cVKIA7GYfd7QEEM=;\n\tb=Pws55iMUvQDjFMD6JYFktG1/BP3k8RpvFmqRXq8K81UgJV+cli+qpV0+BDSBOszW8r\n\tk5ovig1LgaYp8emYW4eLe9J2wN6KzEf8SqWPkbtmsCkQrqJCj4sJYmFvV9pSz9fEwEE7\n\t25CDJ2BFU4rDemGNAVCEQVZnlWdSuwcucgWSUPUKLZGeFTAWmXv8/AyDWGdSzlTYCOES\n\tm8JmO0hfeUMJhujXaiYKEnp39A9qthL3LG1EgdDnAYtgbshKegcXIBgzcefXayJ4NWoj\n\tD2A+aiB36Lyi3j0MY8xPgkG8c2cs6GnmqjcD2KtSK7Rb5zh0i/DLodXNCdH9+wUSmAWe\n\thLeA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=wARteoxR66e9yQkngejVaokaLKx7cVKIA7GYfd7QEEM=;\n\tb=KmqhnQOZxqi/MA79R7VwkoOMFKVklUtydeC+K0Vmuz03qlKdlvvSy4h0a301wtFcFr\n\tQZ5vG+04m7zQLg1X6qg+klfP/kJVpnsfGwbuPbUneTy4xmm0MtqCcgfnm4fyheeTAouT\n\tev0iVUGKRtImNlgrl7Zszb0iyp31ZclC6qRtAGmabL9fx44k7iC/hH60kMLgtwZHLWgK\n\tWGDoTu9Vte1116yjNzRGZHPSxxdgqsA9MZS88xs9jkhUt+S0QAPwoM177xi1mBUJ/5gL\n\tdW4nB3UO6D7jOHPQnbx3kPqO+KIU8E5rCYsdy3Q5j7F/VQARur7vLH5yj50XFeZJ6RnA\n\tJ38g==","X-Gm-Message-State":"AHPjjUiaw3KR3zJKNohuACmUHUpaDERjtugemZxXM+TzYMzh9Fogs6r6\n\t81pA12pVW8i3uA==","X-Google-Smtp-Source":"ADKCNb4OATOFAI1adTf6jQ6TdxuzYkMjM1nUMhuOApV4XxvB8guVOgbHvrPPyIrY8yf1+4OyPSbXlg==","X-Received":"by 10.107.134.210 with SMTP id q79mr760160ioi.259.1504252583416; \n\tFri, 01 Sep 2017 00:56:23 -0700 (PDT)","From":"Bin Meng ","To":"Mika Westerberg ,\n\tCyrille Pitchen ,\n\tMarek Vasut ,\n\tBoris Brezillon ,\n\tBrian Norris ,\n\tRichard Weinberger ,\n\tDavid Woodhouse , \n\tlinux-mtd ,\n\tlinux-kernel ","Subject":"[PATCH 02/10] spi-nor: intel-spi: Remove useless 'buf' parameter in\n\tthe HW/SW cycle","Date":"Fri, 1 Sep 2017 01:00:33 -0700","Message-Id":"<1504252841-2445-3-git-send-email-bmeng.cn@gmail.com>","X-Mailer":"git-send-email 1.7.9.5","In-Reply-To":"<1504252841-2445-1-git-send-email-bmeng.cn@gmail.com>","References":"<1504252841-2445-1-git-send-email-bmeng.cn@gmail.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170901_005641_286374_5BF0BE23 ","X-CRM114-Status":"GOOD ( 10.13 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (bmeng.cn[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Stefan Roese ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"intel_spi_hw_cycle() and intel_spi_sw_cycle() don't use the parameter\n'buf' at all. Remove it.\n\nSigned-off-by: Bin Meng \n---\n\n drivers/mtd/spi-nor/intel-spi.c | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c\nindex e5b52e8..07626ca 100644\n--- a/drivers/mtd/spi-nor/intel-spi.c\n+++ b/drivers/mtd/spi-nor/intel-spi.c\n@@ -377,8 +377,7 @@ static int intel_spi_opcode_index(struct intel_spi *ispi, u8 opcode)\n \treturn -EINVAL;\n }\n \n-static int intel_spi_hw_cycle(struct intel_spi *ispi, u8 opcode, u8 *buf,\n-\t\t\t int len)\n+static int intel_spi_hw_cycle(struct intel_spi *ispi, u8 opcode, int len)\n {\n \tu32 val, status;\n \tint ret;\n@@ -418,8 +417,7 @@ static int intel_spi_hw_cycle(struct intel_spi *ispi, u8 opcode, u8 *buf,\n \treturn 0;\n }\n \n-static int intel_spi_sw_cycle(struct intel_spi *ispi, u8 opcode, u8 *buf,\n-\t\t\t int len)\n+static int intel_spi_sw_cycle(struct intel_spi *ispi, u8 opcode, int len)\n {\n \tu32 val, status;\n \tint ret;\n@@ -456,9 +454,9 @@ static int intel_spi_read_reg(struct spi_nor *nor, u8 opcode, u8 *buf, int len)\n \twritel(0, ispi->base + FADDR);\n \n \tif (ispi->swseq)\n-\t\tret = intel_spi_sw_cycle(ispi, opcode, buf, len);\n+\t\tret = intel_spi_sw_cycle(ispi, opcode, len);\n \telse\n-\t\tret = intel_spi_hw_cycle(ispi, opcode, buf, len);\n+\t\tret = intel_spi_hw_cycle(ispi, opcode, len);\n \n \tif (ret)\n \t\treturn ret;\n@@ -486,8 +484,8 @@ static int intel_spi_write_reg(struct spi_nor *nor, u8 opcode, u8 *buf, int len)\n \t\treturn ret;\n \n \tif (ispi->swseq)\n-\t\treturn intel_spi_sw_cycle(ispi, opcode, buf, len);\n-\treturn intel_spi_hw_cycle(ispi, opcode, buf, len);\n+\t\treturn intel_spi_sw_cycle(ispi, opcode, len);\n+\treturn intel_spi_hw_cycle(ispi, opcode, len);\n }\n \n static ssize_t intel_spi_read(struct spi_nor *nor, loff_t from, size_t len,\n","prefixes":["02/10"]}