{"id":808355,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808355/?format=json","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.0/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1504198860-12951-5-git-send-email-Dave.Martin@arm.com>","date":"2017-08-31T17:00:36","name":"[v2,04/28] arm64: Port deprecated instruction emulation to new sysctl interface","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bc94bcc9e69e94feb50ff2f1b8088e44b2f9d13c","submitter":{"id":26612,"url":"http://patchwork.ozlabs.org/api/1.0/people/26612/?format=json","name":"Dave Martin","email":"Dave.Martin@arm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/1504198860-12951-5-git-send-email-Dave.Martin@arm.com/mbox/","series":[{"id":882,"url":"http://patchwork.ozlabs.org/api/1.0/series/882/?format=json","date":"2017-08-31T17:00:32","name":"ARM Scalable Vector Extension (SVE)","version":2,"mbox":"http://patchwork.ozlabs.org/series/882/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808355/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83982-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"nyRQti5M\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjpkr3mGsz9s81\n\tfor ;\n\tFri, 1 Sep 2017 03:09:24 +1000 (AEST)","(qmail 122132 invoked by alias); 31 Aug 2017 17:09:17 -0000","(qmail 122109 invoked by uid 89); 31 Aug 2017 17:09:17 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-type:content-transfer-encoding;\n\tq=dns; s=default; b=U4afJC+ABvR+NgUemp7ybixkmuuV1qzfzw1mx9CHJNM\n\tOdtmS8pe2kHhC3zb9Z6GiBVM2u3bzQfQp/1Wsuc20s36ABgFUZFUmvgj8N48uUEB\n\tIeWOnQUYn2gTtjJw/xjY8+d08r/PDTT0yQo/hwAbJKMzt9Epyu1NbI9pJdAPnP3A\n\t=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-type:content-transfer-encoding;\n\ts=default; bh=5fNoLTvZsSYjqy1pu/nfhx3J/JI=; b=nyRQti5MY3KeNmKTR\n\tMAZJJjI3Z+dr3ay6j73r+ISQka87MfjohRFjGSgFt20YFeu2q9sFRxUtsmtwWZnx\n\teEgova2JiU59ubcvHo4VrupupETjpGlqXXjZI2GhdQUyQCIeZelfGg8auWbN806b\n\tapVpuQ4Oqh5AdrFXzHMV0t+jZc=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=0555,\n\tHx-languages-length:2139, life, charge","X-HELO":"foss.arm.com","From":"Dave Martin ","To":"linux-arm-kernel@lists.infradead.org","Cc":"Catalin Marinas , Will Deacon\n\t, \tArd Biesheuvel ,\n\t=?utf-8?q?Alex_Benn=C3=A9?= =?utf-8?q?e?= ,\n\tSzabolcs Nagy , Richard Sandiford\n\t, \tkvmarm@lists.cs.columbia.edu,\n\tlibc-alpha@sourceware.org, \tlinux-arch@vger.kernel.org","Subject":"[PATCH v2 04/28] arm64: Port deprecated instruction emulation to\n\tnew sysctl interface","Date":"Thu, 31 Aug 2017 18:00:36 +0100","Message-Id":"<1504198860-12951-5-git-send-email-Dave.Martin@arm.com>","In-Reply-To":"<1504198860-12951-1-git-send-email-Dave.Martin@arm.com>","References":"<1504198860-12951-1-git-send-email-Dave.Martin@arm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Currently, armv8_deprected.c takes charge of the \"abi\" sysctl\ndirectory, which makes life difficult for other code that wants to\nregister sysctls in the same directory.\n\nThere is a \"new\" [1] sysctl registration interface that removes the\nneed to define ctl_tables for parent directories explicitly, which\nis ideal here.\n\nThis patch ports register_insn_emulation_sysctl() over to the\nregister_sysctl() interface and removes the redundant ctl_table for\n\"abi\".\n\nSigned-off-by: Dave Martin \nReviewed-by: Alex Bennée \n\n[1] fea478d4101a (sysctl: Add register_sysctl for normal sysctl\nusers)\nThe commit message notes an intent to port users of the\npre-existing interfaces over to register_sysctl(), though the\nnumber of users of the new interface currently appears negligible.\n---\n arch/arm64/kernel/armv8_deprecated.c | 15 +++------------\n 1 file changed, 3 insertions(+), 12 deletions(-)","diff":"diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c\nindex f0e6d71..e15eb2d 100644\n--- a/arch/arm64/kernel/armv8_deprecated.c\n+++ b/arch/arm64/kernel/armv8_deprecated.c\n@@ -228,15 +228,7 @@ static int emulation_proc_handler(struct ctl_table *table, int write,\n \treturn ret;\n }\n \n-static struct ctl_table ctl_abi[] = {\n-\t{\n-\t\t.procname = \"abi\",\n-\t\t.mode = 0555,\n-\t},\n-\t{ }\n-};\n-\n-static void __init register_insn_emulation_sysctl(struct ctl_table *table)\n+static void __init register_insn_emulation_sysctl(void)\n {\n \tunsigned long flags;\n \tint i = 0;\n@@ -262,8 +254,7 @@ static void __init register_insn_emulation_sysctl(struct ctl_table *table)\n \t}\n \traw_spin_unlock_irqrestore(&insn_emulation_lock, flags);\n \n-\ttable->child = insns_sysctl;\n-\tregister_sysctl_table(table);\n+\tregister_sysctl(\"abi\", insns_sysctl);\n }\n \n /*\n@@ -644,7 +635,7 @@ static int __init armv8_deprecated_init(void)\n \tcpuhp_setup_state_nocalls(CPUHP_AP_ARM64_ISNDEP_STARTING,\n \t\t\t\t \"arm64/isndep:starting\",\n \t\t\t\t run_all_insn_set_hw_mode, NULL);\n-\tregister_insn_emulation_sysctl(ctl_abi);\n+\tregister_insn_emulation_sysctl();\n \n \treturn 0;\n }\n","prefixes":["v2","04/28"]}