{"id":808091,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808091/?format=json","project":{"id":44,"url":"http://patchwork.ozlabs.org/api/1.0/projects/44/?format=json","name":"skiboot firmware development","link_name":"skiboot","list_id":"skiboot.lists.ozlabs.org","list_email":"skiboot@lists.ozlabs.org","web_url":"http://github.com/open-power/skiboot","scm_url":"http://github.com/open-power/skiboot","webscm_url":""},"msgid":"<1504164285-15095-4-git-send-email-cclaudio@linux.vnet.ibm.com>","date":"2017-08-31T07:24:34","name":"[v2,03/14] libstb/stb.c: change sb_verify() to use flash_lookup_resource_name()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"cb7a2dfb9ccf2581c4218dff73ed513cc5b96152","submitter":{"id":69305,"url":"http://patchwork.ozlabs.org/api/1.0/people/69305/?format=json","name":"Claudio Carvalho","email":"cclaudio@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/skiboot/patch/1504164285-15095-4-git-send-email-cclaudio@linux.vnet.ibm.com/mbox/","series":[{"id":760,"url":"http://patchwork.ozlabs.org/api/1.0/series/760/?format=json","date":"2017-08-31T07:24:31","name":"libstb: simplify the initialization of cvc drivers","version":2,"mbox":"http://patchwork.ozlabs.org/series/760/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808091/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjYnt5FZcz9sNc\n\tfor ;\n\tThu, 31 Aug 2017 17:26:10 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjYnt4Ng4zDqXc\n\tfor ;\n\tThu, 31 Aug 2017 17:26:10 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjYmg09BfzDqGZ\n\tfor ; Thu, 31 Aug 2017 17:25:06 +1000 (AEST)","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7V7OiAO116221\n\tfor ; Thu, 31 Aug 2017 03:25:04 -0400","from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cpar7cq18-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 31 Aug 2017 03:25:03 -0400","from localhost\n\tby e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 31 Aug 2017 03:25:03 -0400","from b01cxnp23032.gho.pok.ibm.com (9.57.198.27)\n\tby e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 31 Aug 2017 03:25:00 -0400","from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com\n\t[9.57.199.109])\n\tby b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v7V7P09925559246\n\tfor ; Thu, 31 Aug 2017 07:25:00 GMT","from localhost (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with SMTP id E4578112040\n\tfor ; Thu, 31 Aug 2017 03:24:45 -0400 (EDT)","from legolas.ibm.com (unknown [9.85.193.48])\n\tby b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP id 1EA3E112056;\n\tThu, 31 Aug 2017 03:24:42 -0400 (EDT)"],"X-IMSS-HAND-OFF-DIRECTIVE":"127.0.0.1:10026","From":"Claudio Carvalho ","To":"skiboot@lists.ozlabs.org","Date":"Thu, 31 Aug 2017 04:24:34 -0300","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1504164285-15095-1-git-send-email-cclaudio@linux.vnet.ibm.com>","References":"<1504164285-15095-1-git-send-email-cclaudio@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17083107-0056-0000-0000-000003BF4002","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007640; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00910097; UDB=6.00456510;\n\tIPR=6.00690378; \n\tBA=6.00005562; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016938;\n\tXFM=3.00000015; UTC=2017-08-31 07:25:01","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17083107-0057-0000-0000-000007F5713B","Message-Id":"<1504164285-15095-4-git-send-email-cclaudio@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-31_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708310114","Subject":"[Skiboot] [PATCH v2 03/14] libstb/stb.c: change sb_verify() to use\n\tflash_lookup_resource_name()","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"},"content":"Secureboot verifies only containers stored in known partitions. With the\nflash_lookup_resource_name() function, the PNOR partition information\ndon't need to be duplicated in libstb for secureboot.\n\nThis replaces stb_resource_lookup() by flash_lookup_resource_name()\nin sb_verify().\n\nSigned-off-by: Claudio Carvalho \n---\n libstb/stb.c | 23 ++++++++---------------\n 1 file changed, 8 insertions(+), 15 deletions(-)","diff":"diff --git a/libstb/stb.c b/libstb/stb.c\nindex 41e6505..949f81c 100644\n--- a/libstb/stb.c\n+++ b/libstb/stb.c\n@@ -275,27 +275,20 @@ int tb_measure(enum resource_id id, void *buf, size_t len)\n \n int sb_verify(enum resource_id id, void *buf, size_t len)\n {\n-\tint r;\n-\tconst char *name = NULL;\n+\tconst char *name;\n \n \tif (!secure_mode) {\n \t\tprlog(PR_INFO, \"STB: %s skipped resource %d, \"\n \t\t \"secure_mode=0\\n\", __func__, id);\n \t\treturn STB_SECURE_MODE_DISABLED;\n \t}\n-\tr = stb_resource_lookup(id);\n-\tif (r == -1)\n-\t\t/**\n-\t\t * @fwts-label STBVerifyResourceNotMapped\n-\t\t * @fwts-advice Unregistered resources can be verified, but not\n-\t\t * measured. The resource should be registered in the\n-\t\t * resource_map[] array, otherwise the resource cannot be\n-\t\t * measured if trusted mode is on.\n-\t\t */\n-\t\tprlog(PR_WARNING, \"STB: verifying the non-expected \"\n-\t\t \"resource %d\\n\", id);\n-\telse\n-\t\tname = resource_map[r].name;\n+\n+\tname = flash_map_resource_name(id);\n+\tif (!name) {\n+\t\tprlog(PR_EMERG, \"STB: container NOT VERIFIED, \"\n+\t\t \"resource_id=%d unknown\\n\", id);\n+\t\tsb_enforce();\n+\t}\n \tif (!rom_driver || !rom_driver->verify) {\n \t\tprlog(PR_EMERG, \"STB: secure boot not initialized\\n\");\n \t\tsb_enforce();\n","prefixes":["v2","03/14"]}