{"id":808008,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808008/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170831035306.29170-7-f4bug@amsat.org>","date":"2017-08-31T03:53:05","name":"[6/7] hw/char/omap_uart: serial_mm_init() already check for null chr","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cb34158430f858886e8bad212d3d1096504bfa6d","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/1.0/people/70924/?format=json","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831035306.29170-7-f4bug@amsat.org/mbox/","series":[{"id":736,"url":"http://patchwork.ozlabs.org/api/1.0/series/736/?format=json","date":"2017-08-31T03:52:59","name":"serial: add serial_chr_nonnull()","version":1,"mbox":"http://patchwork.ozlabs.org/series/736/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808008/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"AUz8fd82\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjTBv0n7Hz9rvt\n\tfor ;\n\tThu, 31 Aug 2017 13:59:02 +1000 (AEST)","from localhost ([::1]:53807 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnGdA-000534-Ua\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 23:59:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55597)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dnGXs-0000lf-2m\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dnGXr-0006bn-7h\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:32 -0400","from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:33896)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnGXr-0006bf-3k; Wed, 30 Aug 2017 23:53:31 -0400","by mail-qk0-x242.google.com with SMTP id a77so6862452qkb.1;\n\tWed, 30 Aug 2017 20:53:30 -0700 (PDT)","from yoga.offpageads.com ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tx20sm5072398qtb.5.2017.08.30.20.53.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 20:53:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=KIodJgPfyDNKVJDKXwpUl9qXpUSHSusQbEpLvuy+wCM=;\n\tb=AUz8fd82/Y7Bmt9Cs5c6V4dHbIBAtchd8VzAHpA46xMEeYOTMqstyjlwww1DPyHxS2\n\tCC/oNb9z9PVJPb8HUBFj+b8QvBcW3/Toj9MjLd+/ofDyr9p5joLH/GNrZw1UCD5eJMak\n\t9vtqS9kjd7YCJx2B2HNO4w7qXuN2jrSXHANJk99P930E7Ns0I1TLdMposb+ifK+X4s/3\n\tfkQMGZjZzwH6MiK2sZylstHisdVhjBMc5okkpg0A2eWiqJLBGgJX0TVHAwJWsMudvS9W\n\tVUZ5fQAaGL1lw5DksmJQqRPTGfdN9SKiO0g+lDggMQB4N2zn/3Kk1T7oytIbCdwKImeV\n\te2Dw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=KIodJgPfyDNKVJDKXwpUl9qXpUSHSusQbEpLvuy+wCM=;\n\tb=nHyX4g98meCY2XhrWUws/Pp+kIW+11YnstD9waf+6P5eA0u3FVD7JZYxxJq4H3FRGK\n\t8DRkazZOSdIOD1upqSzknaKTTSbdmvzT57GBUiuY/bHhXE8ypZxRwvA6rVeVGSDH1KW9\n\tY6J/ZLOKOg0yYiLCzcR0vRZRmvtYhLIhgruVh0D4tDaR5IjBHaSeUEqJiBrW6mEm26QK\n\tr+grfq/F2g0KfHAo4/iHZzHCXhvd/sbhFgH49bh/RgvNBzmrCcat/aRUGRNbCFGNIBVx\n\tC68Pq2VPXVGXYs4+cM6eCLhzX2uI3UF73aP8Fc2Y4lqpeZupzOCTIQBsoT4RemKKh/72\n\tk/XQ==","X-Gm-Message-State":"AHYfb5iE2nHsqyqkHKBRKLraeRtOPV2YWZPbAxOw7KIu2smahFy4ETwF\n\tmzrYC7yY9Syog/nxqftG0w==","X-Received":"by 10.55.74.194 with SMTP id x185mr1965505qka.237.1504151610556; \n\tWed, 30 Aug 2017 20:53:30 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Paolo Bonzini ,\n\tPeter Maydell ","Date":"Thu, 31 Aug 2017 00:53:05 -0300","Message-Id":"<20170831035306.29170-7-f4bug@amsat.org>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170831035306.29170-1-f4bug@amsat.org>","References":"<20170831035306.29170-1-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::242","Subject":"[Qemu-devel] [PATCH 6/7] hw/char/omap_uart: serial_mm_init()\n\talready check for null chr","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tqemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Signed-off-by: Philippe Mathieu-Daudé \n---\n hw/char/omap_uart.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/char/omap_uart.c b/hw/char/omap_uart.c\nindex 6fd1b9cf6b..1f0ac0a053 100644\n--- a/hw/char/omap_uart.c\n+++ b/hw/char/omap_uart.c\n@@ -63,8 +63,7 @@ struct omap_uart_s *omap_uart_init(hwaddr base,\n s->irq = irq;\n s->serial = serial_mm_init(get_system_memory(), base, 2, irq,\n omap_clk_getrate(fclk)/16,\n- chr ?: qemu_chr_new(label, \"null\"),\n- DEVICE_NATIVE_ENDIAN);\n+ chr, DEVICE_NATIVE_ENDIAN);\n return s;\n }\n \n@@ -183,6 +182,5 @@ void omap_uart_attach(struct omap_uart_s *s, Chardev *chr)\n /* TODO: Should reuse or destroy current s->serial */\n s->serial = serial_mm_init(get_system_memory(), s->base, 2, s->irq,\n omap_clk_getrate(s->fclk) / 16,\n- chr ?: qemu_chr_new(\"null\", \"null\"),\n- DEVICE_NATIVE_ENDIAN);\n+ chr, DEVICE_NATIVE_ENDIAN);\n }\n","prefixes":["6/7"]}