{"id":808007,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808007/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170831035306.29170-8-f4bug@amsat.org>","date":"2017-08-31T03:53:06","name":"[7/7] hw/xtensa: serial_mm_init() already check for null chr","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3959eaeb783fd68db725de3694e13b1a1b6969dc","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/1.0/people/70924/?format=json","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831035306.29170-8-f4bug@amsat.org/mbox/","series":[{"id":736,"url":"http://patchwork.ozlabs.org/api/1.0/series/736/?format=json","date":"2017-08-31T03:52:59","name":"serial: add serial_chr_nonnull()","version":1,"mbox":"http://patchwork.ozlabs.org/series/736/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808007/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"BCUYxlXG\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjT8P4ZPdz9s3w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 13:56:53 +1000 (AEST)","from localhost ([::1]:53798 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnGb5-0003OX-P8\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 23:56:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55638)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dnGXu-0000o8-IT\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:37 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dnGXt-0006cj-IB\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:34 -0400","from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:37215)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dnGXt-0006cW-EL\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:33 -0400","by mail-qk0-x242.google.com with SMTP id a21so24332qkg.4\n\tfor <qemu-devel@nongnu.org>; Wed, 30 Aug 2017 20:53:33 -0700 (PDT)","from yoga.offpageads.com ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tx20sm5072398qtb.5.2017.08.30.20.53.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 20:53:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=VWpx4VAn+V+H7Td+8qmumLGf4KCoYe0j7GppFOQo3Rs=;\n\tb=BCUYxlXG7AjHRVbWgewZzsvY2fpAaxkgAhXIHlsOubt3nlIGJOAfvB4Y8EiF0d9shw\n\t+8aQ2qU6MFZ6wQBXY1ZGjzGosT7651kMBiGXS2r86RyCT8m5VldGYTm4iG7A0wCpGhYe\n\tvHe0lygl2hQLl1nazxbeijI8hwrKHbRJFIPIyxThfvuBRnW32/DkxN5EfkWfwvYhpv+K\n\tGuRDpAZhSlvFNju9WGAXbUtu59ouAHmWBVjAuzAibKH59IzguEXyds1qGD95BJHVHEeH\n\trqTFwUfss4xNqE+UDZjiBFnN0jG74ubWFYiMAnVtJXc+WEznjl7r1waFa6NkDNvwcO8p\n\t4lPg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=VWpx4VAn+V+H7Td+8qmumLGf4KCoYe0j7GppFOQo3Rs=;\n\tb=ai06ygCCrCTftBw1PwJUjkz7dQux4k1YBVsq2d7wWPg1oBUQkFBqeMUNNrXQ1PzqNj\n\tBz5CdkAo9EOBkijOuYX4k960WPuU/6sSLz9GTJGdtm/voZPnlqUZd7K2CHnN2+0wdkIQ\n\tn635yi238xs5jb/Y4YdrUIIvDnvJ/+Pd7I+DhPjwr9omo2rLOjcQZ2E+JxXZ5SJ4WvBK\n\tmdk3AIXMztNgqXij859K9Rqp4iwIaAMMSL1jbbt7UcAOeIVcrjSeDpjnunce+kPco/X4\n\txYDFGaehjHY/oK49IegACteMNVQVKnQvyxoGZWQTAr1W9I6DOSouJvVeY/PtxDyMOl0Y\n\tMFlA==","X-Gm-Message-State":"AHYfb5j4M0QCKt1eaQHdlcMcDLRl3H4XeX2zDmk1rA/V7FOOMDLKjPV9\n\tNa0g4qspjzKGlA==","X-Received":"by 10.55.73.213 with SMTP id w204mr1902779qka.231.1504151612953; \n\tWed, 30 Aug 2017 20:53:32 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>","To":"Paolo Bonzini <pbonzini@redhat.com>,\n\tPeter Maydell <peter.maydell@linaro.org>,\n\tMax Filippov <jcmvbkbc@gmail.com>","Date":"Thu, 31 Aug 2017 00:53:06 -0300","Message-Id":"<20170831035306.29170-8-f4bug@amsat.org>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170831035306.29170-1-f4bug@amsat.org>","References":"<20170831035306.29170-1-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::242","Subject":"[Qemu-devel] [PATCH 7/7] hw/xtensa: serial_mm_init() already check\n\tfor null chr","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>,\n\tqemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n---\n hw/xtensa/xtfpga.c | 4 ----\n 1 file changed, 4 deletions(-)","diff":"diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c\nindex 635a4d4ec3..223f396902 100644\n--- a/hw/xtensa/xtfpga.c\n+++ b/hw/xtensa/xtfpga.c\n@@ -263,10 +263,6 @@ static void lx_init(const LxBoardDesc *board, MachineState *machine)\n                 xtensa_get_extint(env, 1), nd_table);\n     }\n \n-    if (!serial_hds[0]) {\n-        serial_hds[0] = qemu_chr_new(\"serial0\", \"null\");\n-    }\n-\n     serial_mm_init(system_io, 0x0d050020, 2, xtensa_get_extint(env, 0),\n             115200, serial_hds[0], DEVICE_NATIVE_ENDIAN);\n \n","prefixes":["7/7"]}