{"id":808004,"url":"http://patchwork.ozlabs.org/api/1.0/patches/808004/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20170831035306.29170-5-f4bug@amsat.org>","date":"2017-08-31T03:53:03","name":"[4/7] hw/mips/malta: use serial_chr_nonnull()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c5a2fc0648cee880b17f41cda1d0635d5092fa71","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/1.0/people/70924/?format=json","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831035306.29170-5-f4bug@amsat.org/mbox/","series":[{"id":736,"url":"http://patchwork.ozlabs.org/api/1.0/series/736/?format=json","date":"2017-08-31T03:52:59","name":"serial: add serial_chr_nonnull()","version":1,"mbox":"http://patchwork.ozlabs.org/series/736/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808004/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"C4h+kC2Z\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjT5L56pWz9s3w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 13:54:14 +1000 (AEST)","from localhost ([::1]:53785 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnGYW-0000mX-Q7\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 23:54:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55574)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dnGXq-0000kT-E1\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dnGXm-0006aN-6E\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:30 -0400","from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:33082)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dnGXm-0006aA-2D\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 23:53:26 -0400","by mail-qk0-x241.google.com with SMTP id k126so3514674qkb.0\n\tfor <qemu-devel@nongnu.org>; Wed, 30 Aug 2017 20:53:25 -0700 (PDT)","from yoga.offpageads.com ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tx20sm5072398qtb.5.2017.08.30.20.53.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 20:53:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=5DQdd00AJTXwPFuImthUxG3CuA9Qds7GlB6RWCDBigg=;\n\tb=C4h+kC2ZY/FEviwakq99b70n0ZlZPd9K7iv2KoToShDFwakUL2w5FzDNo0NzOINskQ\n\tVMQcGFD9Bu6N2HGbnO/v2rmHf2bfjomr9qHlmxAgqu3D26PsYOxLvhcqwgKaKu05HYmi\n\tA0J+KDpZhem9YU8oV5DUx1kDspNX+LroZlVnIEeVapxiEjwjqSbu+EImJW2wZlbvxtaa\n\tc4TgBS3lFiMiKvRlAE7Gux4o5lZ5kZncVLN4kIKfmJrOJHlSch6MQFExuIKiBGMu1ZHT\n\txX03tagVxIvtxzH4fG9neKINhpAxIFk0h4MYtas4P0HwPSalUZOCinyGCGxd9b96Ht/v\n\tvaLg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=5DQdd00AJTXwPFuImthUxG3CuA9Qds7GlB6RWCDBigg=;\n\tb=dshokUXV0JqNs2EKTE4eYVNnW+GLyWVoY7Lmsz5tTpkGN/j511WwX+QPNUAmksGYAp\n\tPgeYgm6WZjK5KXhgs5yakEBB7f6Z4uPWA4QPe0hJ72I37fRQr/+GfM13QYy/ZB+FHTOC\n\tSbdE51PrAkOGgreyV5aspxh06hqOYNr4VEkVB2IOsqAL+/zLypzU8Sr94T9m6+L3RPd2\n\tggbPb06GarXrSmqc0rSCgt21PeXPmAun4DATgIVoUqfsWakQySvek79//ia1luBaNeJ0\n\tj3pqaUo40wZQLdvFQqzJeeZ5P0AAw2EzSHRgfJwdyGkU82zdO1od8R7eFO3auJ+vzAav\n\tiwwQ==","X-Gm-Message-State":"AHPjjUiV+MTkCaL9Gw6sW8Guaqq0EtJJV0MSj7Ntt/Vcf5BltHEBwYal\n\tym79F454EsPvWw==","X-Received":"by 10.55.71.130 with SMTP id u124mr1928391qka.159.1504151605510; \n\tWed, 30 Aug 2017 20:53:25 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>","To":"Paolo Bonzini <pbonzini@redhat.com>,\n\tPeter Maydell <peter.maydell@linaro.org>,\n\tAurelien Jarno <aurelien@aurel32.net>,\n\tYongbok Kim <yongbok.kim@imgtec.com>","Date":"Thu, 31 Aug 2017 00:53:03 -0300","Message-Id":"<20170831035306.29170-5-f4bug@amsat.org>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170831035306.29170-1-f4bug@amsat.org>","References":"<20170831035306.29170-1-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::241","Subject":"[Qemu-devel] [PATCH 4/7] hw/mips/malta: use serial_chr_nonnull()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>,\n\tqemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n---\n hw/mips/mips_malta.c | 6 +-----\n 1 file changed, 1 insertion(+), 5 deletions(-)","diff":"diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c\nindex af678f5784..8620e9c42c 100644\n--- a/hw/mips/mips_malta.c\n+++ b/hw/mips/mips_malta.c\n@@ -1035,11 +1035,7 @@ void mips_malta_init(MachineState *machine)\n \n     /* Make sure the first 3 serial ports are associated with a device. */\n     for(i = 0; i < 3; i++) {\n-        if (!serial_hds[i]) {\n-            char label[32];\n-            snprintf(label, sizeof(label), \"serial%d\", i);\n-            serial_hds[i] = qemu_chr_new(label, \"null\");\n-        }\n+        serial_hds[i] = serial_chr_nonnull(serial_hds[i]);\n     }\n \n     /* create CPU */\n","prefixes":["4/7"]}